Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation and file classification in parallel threads (#695)
Merged #695 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/695#event-2355426236___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation and file classification in parallel threads (#695)
Maybe third time's the charm... while walking the dog I remembered the hash table added in commit e33045e35c09cda530a9e665c367693e285b6511 that wasn't there when these patches were created needs thread protection now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/695#issuecomment-49222___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation and file classification in parallel threads (#695)
@pmatilai pushed 1 commit. b42103a0f539c600a8b3de423d9db76501623b98 fixup! Run file classification in parallel threads -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/695/files/e6c79e5d48e5373aa86ef28b8dae9f072208..b42103a0f539c600a8b3de423d9db76501623b98 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation and file classification in parallel threads (#695)
@ffesti spotted a bug in the binaryPackages() for loop logic, fixed in the first push but then a regression introduced in commit 0f21bdd0d7b2c45564ddb5a24bbebd530867bd54 caused one test to fail. Now rebased on top of the regression fix... pffft. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/695#issuecomment-492195330___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation and file classification in parallel threads (#695)
I just wonder, how this influences the console output. Will it be still always readable or will there happen some output race conditions and it won't be readable anymore? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/695#issuecomment-490771644___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation and file classification in parallel threads (#695)
Added parallel file classification, which is beneficial for some cases. Most of the time, the dependency generator is the biggest bottle-neck however. That's a *much* tougher nut to crack though: there are huge gains to be made even without parallelisation there, but it needs a massive overhaul to make that possible. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/695#issuecomment-490506159___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
