Re: [Rpm-maint] [rpm-software-management/rpm] Uninformative error message on %include'd and generated spec content (Issue #2714)

2024-03-20 Thread Panu Matilainen
Not going to do major refactoring for this in 4.20, drop the milestone.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2714#issuecomment-2008969429
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Uninformative error message on %include'd and generated spec content (Issue #2714)

2023-11-07 Thread Panu Matilainen
The problem is of course far wider than just this one error message. To solve 
this, we need to refactor all spec-error reporting to a variable argument 
helper function which can then report filename, line number and such 
consistently though rpmlog().

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2714#issuecomment-1798019266
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Uninformative error message on %include'd and generated spec content (Issue #2714)

2023-10-11 Thread Panu Matilainen
includetest.spec:
```
Name: includetest
Version: 1.0
Release: 1
License: Testing
%include badsummary.inc

%description
%{summary}
```

badsummary.inc:
```
Xummary: Include test
```

> [pmatilai︎localhost SPECS]$ rpmbuild -bb badsummary.inc 
> error: line 1: Unknown tag: Xummary: Include test

That's just terrible because there's no indication of the file where the 
problem is. %include is rare because this is not the only problem it has, but 
dynamically generated spec content suffers from this same issue (although in 
that case there's at least a hint of the file in the output, just not in the 
error message)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2714
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint