Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@n3npq , you being the original author of where this originates from, would you mind review the implementation, while also share some insights and thoughts on the matter? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-378561401___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
> Lua is the embedded language of rpm, end of story. That's a statement, not an argument. Specific issues related to iplementation were raised in #25 when closing it, only partially addressed in #196, then fully addressed in this PR. Your arbitrate statement cannot be considered as a valid reason for closing this PR without a relevant discussion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-371975799___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Closed #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1492074446___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
I would've thought closure of #25 and #96 made it fairly clear that it's the functionality that is not wanted. The problem here isn't so much with the implementation but the fact that we *don't want to* enable arbitrary embedded language support in specs and macros. Lua is *the* embedded language of rpm, end of story. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-368513569___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Reopened #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1481746956___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Closed #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1481746644___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@Conan-Kudo could you take care of reopening this one? I'm currently -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-366877938___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Reopened #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1215322179___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Closed #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1215322143___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@junaruga @proyvind It might need to be closed and reopened to trigger the CI system to see it. I think @ignatenkobrain did that for a couple of other PRs... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-323909107___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Thank you for that. But it seems that the CI test is not run for this PR.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-323131071___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
rebased.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-323117737___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 227 commits.
6b6b507 Drop dead-on-arrival untrustedkeys formatting from signature checking
886c417 Add a test for non-verbose signature check output
7de6172 Drop missing key formatting from non-verbose signature checking output
7488d88 Drop the ambiguous and bogus RSA/DSA algorithm info from sigcheck
output
e0457ca Eliminate redundant rasprintf()
5121665 Consolidate signature disabler handling to a helper function
231302b Honor RPMVSF_NEEDPAYLOAD in signature checking
16c8ce0 Filter out non-digests and signatures centrally in sinfoDisabled() too
d1359d0 Clean up signature checking readFile()
0b794d5 Separate the act of signature checking from the output, step 1
0194384 Implement a callback hook into signature checking, use for rpm -K
output
f7d4b2b Assimilate sigtagname() into formatDefault(), nothing else needs it
29c48e1 Add mode for updating with minimal writing (RhBug:783480)
1a88377 Remove unnecessary memset
bae912e Support passing private data pointer through the signature callback
4c98731 Fixup SHA1 order in rpmSigTag enum
b7e1101 Issue signature check callbacks for invalid signature data too
aa5cf0c Use signature element type for filtering instead of hashalgo
e795899 debugedit: Only output comp_dir under build dir (once).
b802edc Make sinfoDisabled() internally available
2c21593 Reorder struct rpmsinfo_s members to group by static and parsed data
d809fd5 Move signature information into a table
b91b636 Add a headerGet()-style helper for fetching signature data
c233ca8 Only look for known signatures and digests in signature checking
25e506c Move NOTFOUND -> OK translation to rpm -K specific callback
5f23f6b Implement a crude API for dealing with sets of signatures outside
headers
4429801 Switch rpm -K to use the new signature set API
acfde0d Add an internal, limited-functionality headerGet() for raw headerblob
9821de1 Look mom, no hands! Err, headers ...
a67e667 Assimilate rpmsinfoGet() into rpmsisetAppend()
d63fb16 Now that we can, initialize all digests before starting verifications
5cc9d88 fix memleak in systemd_inhibit plugin
7e5932e Support allocating FD digest bundle on get
1ba4ce0 Switch sigchecking system to use digest bundles instead of fd's
b791df8 Internal signature API renames
f2c6c10 Lift all the new signature stuff into new rpmvs.[ch] source + header
42ece09 Preparation for minimal writing for %config files (part 1)
5fa7888 Preparation for minimal writing for %config files (part 2)
f669e4e Preparation for minimal writing for %config files (part 3)
4a50cd9 Minimal writing for %config files
b60ce10 Only add rpmsq-handled signals into the rpmsq-caught set
9e3256d Fix testsuite with newer NSS versions which require /dev/urandom
8f7f85f Don't warn about getting killed by SIGPIPE
6278fcf Use bash-style 128 + signum exit code when exiting on signals
5e51d2b Add some SIGPIPE test cases
585be2a Stop NSPR from messing with our signals
d5701c4 Implement SIG_DFL/SIG_IGN/SIG_ERR counterparts in rpmsq
9085009 Fix regression on SIGPIPE from scriptlet killing (RhBug:1264198)
80f31c2 Change sinfoLookup() to return an index into rpmvfyitems
d6f75a4 Fix hex strings not getting validated
af6e08d Remove redundant assignment
fe16b02 Split tag-specific information out of rpmsinfo struct
7ae8f89 Fix unintended double-colon on failed digest messages
2286ed6 Add bunch of tests for corrupted package verification
b4b8f33 Fix the armv5tl arch compatibility list
4842adf Untangle unique build options in find-debuginfo.sh
538cecf Support debugsource subpackages
980749f Support debuginfo subpackages
a517554 Also add directories to split debuginfo packages
bc58b5c Add a vanilla testcase for install + erase ordering
51f5093 Add a bunch of installation mode tests (manifests, notfound, corrupted
etc)
91d04a4 Honor RPMVSF_NEEDPAYLOAD in signature checking
d8de8d3 Optionally import and return merged header from
rpmpkgVerifySignatures()
bad2ef4 Return "not an rpm" NOTFOUND silently on signature checking too
101cba0 Use dribbles as heuristics for header/package output differentation
3ccd9cc Use the signature checking code to read all package files
c293a0f Rename rpmpkgVerifySignatures() (sort of back) to rpmpkgRead()
763d3e4 Use rpmvs for headerCheck() too
1897770 Bury remaining internal signature API inside rpmvs.c
75f124c Account for arrays when generating verify item id
3441324 Oops, rpmvs.c is missing from POTFILES
117b337 Remember flags passed to rpmExpandMacros() in the expansion state
buffer
9ae7d1d Expand parameterized macro arguments one by one after splitting
767d61c Preserve %%-escapes when expanding parametric macro arguments (#217)
d7e74c4 Do not call rpmfcPrint() with an uninitialized buffer in rpmdeps
de61c64 Use conditional to access %{_docdir} in macros.in
a6a71bf fix comparison between signed and unsigned integer expressions
2329af6 Generalize primary user/group for platforms (#210)
b71d63e Consolidate
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Hello, @proyvind I am not a maintainer of this project. However this project started to use CI recently. So, it might be good to rebase your branch for PR on top of master branch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-322180192___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
This PR is now four months old, where not a single comment on it has been made. The implementation is completely unintrusive and at possibility to even create regressions, yet not a single feedback..? What gives? In contrast to the preceeding rpmpython PR, this one has addresses all issues with and require no additional linking or anything at all, while leaving the responsibility of optioinally implementing the rpminterp plugin interface to third parties and outside of rpm upstream with additional maintenance and complexity from. In stead by leaving it up to third parties, it encourages further development and benefits from being made outside and indepedent of rpm itself, having the potential for some serious developments in rpm packaging with the ability to improve it drastically left in the hands of those doing the packaging and hence knowing it best. Please finally review and give feedback on anything that would like to be seen changed and I'll attend to ASAP. Waiting several months without PRs invested a lot of time with great ambitions for, only to have it ignored is extremely demotivating, not encouraging further contributions and has the hallmark of poor project leadership, especially considering I'm not the only one experiencing such little interest and appreciation in time and efforts invested into my contributions.. If anything is unfair about what I wrote, I surely and strongly encourage anyone who thinks I'm unreasonable and out of line to please comment on this in this PR as discussions taking place on IRC in stead is completely unfruitful and the completely wrong place to conduct such anyways. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-321230563___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 1 commit. fa515fc dlopen with RTLD_DEEPBIND -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/de807fa860a667ee1e09b1bcf97a2a555a76a1fd..fa515fcd83b2c8cbe1399b55b1b8fd00f060fa00 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 1 commit. de807fa drop md5 digest from download url -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/8215b221dd5508ef58c86b34966c4f5e1bb06203..de807fa860a667ee1e09b1bcf97a2a555a76a1fd ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 5 commits. da5ac98 move 'extern "C"' to top of file e1a6125 use flexible array member for rpminterp->name b94a62c fix enum 0cad264 add api doc for rpminterpLoad() 8215b22 revert variable array member change as it breaks C++ compatibility -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/2e190d5365f433ac9b55c997fdf8b11a5e9af591..8215b221dd5508ef58c86b34966c4f5e1bb06203 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 1 commit. 2e190d5 move handle out out of rpminterp API -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/49f8f80ae6427bc648e040a41b73f0eabb3bb9e0..2e190d5365f433ac9b55c997fdf8b11a5e9af591 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 1 commit. 49f8f80 work around python setuptools not supporting unlimited jobs in pyspec() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/dd27e485420b22a23f57e965f21081ada5426277..49f8f80ae6427bc648e040a41b73f0eabb3bb9e0 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 2 commits. 3750cb5 add md5 verification to pyspec() dd27e48 really default to automatic archive selection for pyspec() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/03755b5516a967e66b1aa3502b69745e376e6953..dd27e485420b22a23f57e965f21081ada5426277 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@proyvind pushed 1 commit. 03755b5 automatically pick latest version and preferred file format for pyspec() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/190/files/27a107c7b14d8792a382736b1e45ace53f454077..03755b5516a967e66b1aa3502b69745e376e6953 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
