Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Merged via commit 45103f84764b2a293b068eb0f59456f553ec45d8 with a more elaborate commit message + Python version requirement updated. Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1465910141 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Closed #2408. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#event-8730224332 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
This is a nice example of even the most innocuous looking one-liner needing review... Py_hash_t was only introduced in Python 3.2, which means we need to bump our Python requirement for this. 3.2 is old enough that we can just shrug and bump, but it needs to be documented. > python/header-py.c:744:2: error There aren't that many lines in current header-py.c so must be from compiling some other version than git master. It doesn't make the patch any less correct but addressing a flaw on a non-existent line would look weird. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1465792947 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Accidentally closed, sorry about that (one of *those* Mondays it seems) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1465779717 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Reopened #2408. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#event-8729323904 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Closed #2408. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#event-8729206542 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Please make a note of that in the commit message, just for future reference. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1459754648 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
> What tooling/versions is giving this error? I don't doubt that Py_hash_t is > the more proper type here, just that I've never seen the compiler complain > about this. clang16+ -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1458361863 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
What tooling/versions is giving this error? I don't doubt that Py_hash_t is the more proper type here, just that I've never seen the compiler complain about this. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1458064636 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Fixes python/header-py.c:744:2: error: incompatible function pointer types initializing hashfunc (aka int (*)(struct _object *)) with an expression of type long (PyObject *) (aka long (struct _object *)) [-Wincompatible-function-pointer-types] | hdr_hash, /* tp_hash */ | ^~~~ You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2408 -- Commit Summary -- * python: Use Py_hash_t instead of long in hdr_hash -- File Changes -- M python/header-py.c (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2408.patch https://github.com/rpm-software-management/rpm/pull/2408.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408 You are receiving this because you are subscribed to this thread. Message ID: rpm-software-management/rpm/pull/2...@github.com ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
