Re: [Rpm-maint] Obsoletes handling in depends.c:rpmdbProvides()

[Panu Matilainen]

On 04/18/2012 06:10 PM, Michael Schroeder wrote:


Hi Panu et al,

I'm a bit confused about commit 9fb81eac. If dep is an
Obsoletes dependency, it uses RPMDBI_NAME instead of
RPMDBI_PROVIDENAME. It then still calls rpmdsMatchesDep().

Is that really correct? It seems to me that rpmdsMatchesDep()
always expects the ix argument to be an index into the
provides error, how can that work with a different db index?

Also, shouldn't it call rpmdsNVRMatchesDep() in the
obsoletes case instead of rpmdsMatchesDep() to be more
consistent with addObsoleteErasures()?


It does look fishy alright, thanks for pointing that out. Note the 
commit message: I did have a feeling there might be something more to it 
so it doesn't say its correct but (more) correct :)


- Panu -

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] Obsoletes handling in depends.c:rpmdbProvides()

[Michael Schroeder]

Hi Panu et al,

I'm a bit confused about commit 9fb81eac. If dep is an
Obsoletes dependency, it uses RPMDBI_NAME instead of
RPMDBI_PROVIDENAME. It then still calls rpmdsMatchesDep().

Is that really correct? It seems to me that rpmdsMatchesDep()
always expects the ix argument to be an index into the
provides error, how can that work with a different db index?

Also, shouldn't it call rpmdsNVRMatchesDep() in the
obsoletes case instead of rpmdsMatchesDep() to be more
consistent with addObsoleteErasures()?

Cheers,
  Michael.

-- 
Michael Schroeder   m...@suse.de
SUSE LINUX Products GmbH,  GF Jeff Hawn, HRB 16746 AG Nuernberg
main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);}
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint