Re: [Rpm-maint] [rpm-software-management/rpm] Add builtin macro %undefine_all (#820)

2019-08-23 Thread Panu Matilainen
I gave you some hints already, I'm not going to spell it all out for you, why 
don't you think about it by yourself a bit?

 It'd indeed be trivial to implement, and looks like an easy solution to a 
common problem on first sight, but in the bigger picture such an operator would 
be harmful to rpm in more than one way. I can think of 3-4 offhand.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/820#issuecomment-524185258___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add builtin macro %undefine_all (#820)

2019-08-23 Thread Panu Matilainen
Closed #820.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/820#event-2578624539___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add builtin macro %undefine_all (#820)

2019-08-22 Thread pavlinamv
> Please, how does it break the stack semantics?

I am asking because I think that it is easy to implement such a builtin macro.
E.g. popMacro() can be changed such that it returns 1 if an macro was deleted 
and 0 if no macro was deleted. After that it will be easy to call popMacro() in 
some function similar to doUndefine() until popMacro() returns 0. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/820#issuecomment-523944629___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add builtin macro %undefine_all (#820)

2019-08-22 Thread pavlinamv
Please, how it breaks the stack semantics?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/820#issuecomment-523881821___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add builtin macro %undefine_all (#820)

2019-08-22 Thread Panu Matilainen
The thought has crossed my mind too, but there's a reason such a thing is not 
implemented: it breaks the stack semantics, which various parts of rpm rely on. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/820#issuecomment-523880858___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint