Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
yup, wontfix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#issuecomment-372293010___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
Closed #392. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#event-1516097945___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
Then you are stuck: it's your workload, not the rpmspec parser implementation, that is the root cause. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#issuecomment-366440232___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
If I would be querying them sequentially, then it would take hour or so -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#issuecomment-366439874___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
> Since your program appears to be multithreaded, try splitting the 4000 > specfile queries across 10-20 worker threads. That's exactly what it does. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#issuecomment-366439857___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
@n3npq it's not single spec.. Its 4000+ different specs. What I wrote there if you run `rpmspec`, then tool is taking 2 minutes to do the job. If you remove execution of rpmspec, then tool takes 3 seconds. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#issuecomment-366437766___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
@n3npq believe me, it is slowest part in my tool ;)
```
287.25user 152.95system 2:11.94elapsed 333%CPU (0avgtext+0avgdata
68724maxresident)k
13648inputs+0outputs (53major+30349595minor)pagefaults 0swaps
```
```diff
diff --git a/src/main.rs b/src/main.rs
index 4b0f2ff..9306517 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -79,6 +79,7 @@ fn run(opt: ) -> Result<(), Error> {
let atime = author.when();
let datetime =
FixedOffset::east(atime.offset_minutes() * 3600 /
60).timestamp(atime.seconds(), 0);
+/*
let output = Command::new("rpmspec")
.args(&[
"--srpm",
@@ -92,6 +93,7 @@ fn run(opt: ) -> Result<(), Error> {
workdir.join().to_str().unwrap(),
])
.output()?;
+*/
let mut chlog_header = format!(
"* {} {} <{}>",
@@ -99,11 +101,13 @@ fn run(opt: ) -> Result<(), Error> {
author.name().unwrap_or("Nobody"),
author.email().unwrap_or("nob...@fedoraproject.org"),
);
+/*
if output.status.success() {
chlog_header.push_str(!(" - {}",
String::from_utf8_lossy()));
} else {
eprintln!("{}", String::from_utf8_lossy());
}
+*/
let chlog_entry = format!("- {}", commit.summary().unwrap());
Ok(Some(format!("{}\n{}", chlog_header, chlog_entry)))
```
```
13.41user 2.05system 0:03.20elapsed 482%CPU (0avgtext+0avgdata
66184maxresident)k
0inputs+0outputs (0major+495394minor)pagefaults 0swaps
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/392#issuecomment-366431860___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: implement fast mode for getting EVR (#392)
Um, spec file parsing is not exactly slow (even with lightly used %include) and there already is a means to query EVR from a spec file. Presumably you are seeking the EVR used on every %changelog entry by brute force: try being more clever, by (say) pickling a store in the git directory incrementally. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/392#issuecomment-366388365___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
