Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Merged #2406 into rpm-4.18.x. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#event-8732507709 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Oh, well... Commit e31fb5b75898bfa09180dba02475c6d01764d94f already was on the `rpm-4.18.x` branch :facepalm: So we need to make the above change a separate commit. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1466238948 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
One last fixup: amend upstream commit e31fb5b75898bfa09180dba02475c6d01764d94f so that `Home-page` in the newly added `rpm.egg-info.in` is hardcoded (we don't define `@PACKAGE_URL@` so the field would've been empty). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-146623 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
@dmnks pushed 79 commits.
f4400993780890a37ccad9856340946bb7f9b0c5 Generate Python egg-info from
automake builds
6432673bb96761d41905bd741d7028a2d10cba4d Document need to do history research
on behavior changes
ca4406bd3f6793389de8cb1c9982eefeb4e137c9 Add more on pull requests to
CONTRIBUTING
8733025ef47ad979be318e8e681f80abff67a122 Fix potential uninitialized variable
use in rpmtsImportPubkey()
13e87891c41dc54ae6077794ffa26251da76f55e fapolicyd: Make write() nonblocking
30390c254c56b2508328f976285a03d372045b75 Fix typo in macros manual
70ed2369b0f4d1fe63a4c6d23e2ff4e2f470747c Permit building rpm from git without
pandoc
9f66d008ad2ab2e473719620ea8760fc1b65b2c9 Add a handler for libselinux log
messages (RhBug:2123719, RhBug:2050774)
6dce9697c3994938cc08826528a6658ddf7b8419 Add a whole bunch of epoch behavior
install tests
15d459a237d96b68200d09178d5cd772541e81ff Handle downgrade within V-R when
epoch goes away (RhBug:1845069)
425ae1102cb82488826e6852b61a229f2a29d2b3 Add mode string documentation to
Fopen()/Fdopen()
5e72fe1c65f85834dd9ea502ce027e992aa8c891 Add payload compression macro
documentation
601b8141fc1e71642494b7d7736cc7fae1edd4bc Add a blurb to hello.spec cautioning
against its use
8a4dc9db4b329bd6edd6eecd895895b8092e24da Doh, unbreak CI from commit
190354cb19af6ecdfec6f7eaa454d6afcf381128
27e4f6732f20195c19169571519d25b6b9582ed6 Docs: macros: backtick-fence more
literals in body
90712eff1ea51746ed4c02f32a8e3ddbe1178aa9 Docs: Macros: Attempt to fix literal
backslash
1d46a0e274c102fa923bd1ff009beaf7a728253b Docs: macros: Add some missing
fencing, fix grammar
1077f3a3dcfcec9dee1ffc5b6b081cace991d342 Avoid type confusion when verifying
signatures
02726daff5e0b771caa75d30a0e3b2a6035ab11a Check packet types of signatures and
public keys
cac1cc1a93abd977275a70690c169e16e5b30bcd Reject multiple PGPTAG_PUBLIC_KEY
packets
ed7a60f2635912ac71dbf0294adedc17a7986197 Avoid bashisms in test-suite specs
3ba4d521df515c088748e7a22530b7970f34ad78 Eliminate remaining %{u2p:...} uses
a644702d0ae52a8ffc43b1ce70e2391c517b549d Make CPU and thread-related macros
available on all platforms
0b11f7e6fd42f9c1163b7d744ba210d202960200 Make %_smp_mflags build rather than
parse time determined
4334b982046292e1a3479d4f179e2b9c949ec23b Fix rpmkeys type confusion test.
2e624ae8a9c02466821842226b4812fbb644d3d5 Enable malloc checking with random
perturb in the test-suite
e2737420cfe6496dcdafa4e87873a73a30b52298 Remove unrelated %undefine output
from macro scoping test
bce38aeee019ed0dc9fbac73778a6a5de213d5be tests: add test for %verify in %files
ab69ebe9c3daa76dafc1ae6e58e9d562aed4ccb1 tests: add test for Obsoletes
3a0ca5d4d62104e20053afb9196a1320c42e7fbe Fix regression: -bp should check
BuildRequires
f17c24b23eaab4be9d1a303a0b58d8f398c022f1 Test if BuildDependencies are checked
for %prep
9d3d3900b15cd1a964ad2a0b43dcf6d1c60bd475 Add some basic tests for OpenPGP v3
signatures
2a5d58dd6c4c45097ca0270bbf4a7e0ec92fdde2 Fix header leak in rpmInstall()
503d6bf6b7a32105499e6a103f3e4541660cce3d Fix eiu->sourceURL info leak in
rpmInstall()
77a7631bf052dfd310e09c3d335d3c63d2ee8065 Fix file leak when src rpm in URL
format is used for installation
4bc4abc989edd9ff46da06c91ec96fa8e5bfd779 Fix h->blob leak when installing
source rpms
c70ab8396dc2256fab5924e9b6135a0e0031e952 Issue a warning when signing created
an OpenPGP v3 signature
7668a613b835726472e803eff101c4a6ec6d2226 Bump CI to Fedora 37
40b15e6dc6ac23275d5dfc833d55c6ab22072962 Fix markdown syntax typo
98f15f78c73e8e37a57ad7ad82c473a662742c77 Fix broken markdown quoting …
7b050436d6f2a3bd58c6e6b2382be6cdcd930039 Add missed full stop.
67e3ce8f54312a2795beb5bd37b7f8e27c9b98e6 Fix Header leak when running rpm2cpio
8059e32186cc5eff7aed8e18c2d8974fe9df63ee Fix BANames leak in handlePreambleTag
0cd3c97e5ee130fd22e71edd3cd1fe2d0632e95f Fix prog leak in parseScript
895e552937bc415612a46990143acc4e9c4d88bc Fix elf leak in getElfColor
64beb3a30f97fc3c72da2271289b11fbbc8497fe Fix *sbp leak when running rpmbuild
with --quiet
1f37231ac592bebb740332603a70f9d6fa4527d5 Fix memleak when running
%generate_buildrequires
6d4f4163a6138e8ad9d3966a58566b714d7d83b2 Fix memleak when fsmRename failed in
fsmCommit
c56aec0836ad9512210a8974c7af92da2a141ab8 Fix fileleak and memleak in rpmInstall
fc566ba98bb3a72a773659fec1cf7f4f08e3b722 Fix fileleak when urlGetFile fails in
rpmInstall
70c646064d72619da861162b80d795e6fda2fc0c Fix typo in macros.in
4deca7581de035a0bf2170c7f1f3d14bb6fd4374 brp-remove-la-files: use -0 to work
on macOS
81e49016124f98686398d2503c2466c4a63aaa2b Use proper macro conditional negation
syntax in the manual
1aa74307492c49423643dd9d37d68a86ec752eef Un-deprecate %_changelog_trimtime
75fd0d256760fbdabc2c78f9429bcd8815349cf9 Quote source file names in %setup
29df15fa4dfc0f814c50d107a82399129d5e7717 Testcases: rpmbuild source name with
space
5b78850dd7314aaad9c6a108c2b2d8073f8afd8a Revise ISANAME for loongarch
f6f
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
@pmatilai approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#pullrequestreview-1336774698 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Another update, this time removing the following: 8a74780c0 check-buildroot: harden $tmp creation fb6ad2c74 check-buildroot script: use if-then-else f2b4c647c check-buildroot: Redirect xargs stderr to $tmp 11458278a check-buildroot script: Double-Quote the variables fd3ef9b09 check-buildroot script: use export to set LANG e7e0b4df8 Split testing population into a shell-script 3a280308b Drop historic remnants from test-suite PATH 1e1e93ee5 Avoid buggy (if harmless) bin symlink in test when using /usr prefix 00c1bdfd7 Try to use pre-compiled libmagic, fall back to recreating if not found -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1463747788 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
@dmnks pushed 78 commits.
2c0459a25aa9174373bb514bd8bb4246b03b56c0 Document need to do history research
on behavior changes
49b5fffd958c532497d7e223ff1c9429e9f31a17 Add more on pull requests to
CONTRIBUTING
dae67690507ef192d64b0029105614615418293a Fix potential uninitialized variable
use in rpmtsImportPubkey()
d68129e550d7ba220bee76603241203226cb65ea fapolicyd: Make write() nonblocking
76773176648b7ee27ef2e3801bbae935bc4c3fa3 Fix typo in macros manual
7a415883f68aad0fd86a9001e1de2a4a88eccd74 Permit building rpm from git without
pandoc
65990f985a60050dfefd45c712f9507c500e85ed Add a handler for libselinux log
messages (RhBug:2123719, RhBug:2050774)
fe33f968162ae523b2cd2013bfd1215c3b4ecadb Add a whole bunch of epoch behavior
install tests
50def208729ee186e9a2bb68bd4a62404e745404 Handle downgrade within V-R when
epoch goes away (RhBug:1845069)
154f6b2c23bfd92d88b05a1900886f55a8541835 Add mode string documentation to
Fopen()/Fdopen()
575cc82c0a4268e8fa3b74384b02efdc95ef3b74 Add payload compression macro
documentation
7881ef6a0ece37a9f10169306ef16824683f271b Add a blurb to hello.spec cautioning
against its use
07f6f65ef0e5b3c24a284f8ec9e3727e97dc408d Doh, unbreak CI from commit
190354cb19af6ecdfec6f7eaa454d6afcf381128
7bccb28ab668cd03140587182c6ca95d6552b974 Docs: macros: backtick-fence more
literals in body
740dba4a09df086763943b749c6f1604e4864291 Docs: Macros: Attempt to fix literal
backslash
5f621ff1a07788a5d6650c373664885408b20540 Docs: macros: Add some missing
fencing, fix grammar
55fe12f8fcaa3cfefb546aa2528b20d0c1fbc453 Avoid type confusion when verifying
signatures
bf3817df0dff826790dcd952a81c36cc7b836c16 Check packet types of signatures and
public keys
d3ed114c8522bd576994434d50c12b2ebf5ae235 Reject multiple PGPTAG_PUBLIC_KEY
packets
4d6b1329e66bcd4faf8c84ec1a2abcbbb6156515 Avoid bashisms in test-suite specs
cf45054dfa4c245033c54b245e44a320dcfb8f5a Eliminate remaining %{u2p:...} uses
4610cb54eda7bf5a6d6683de7b879c550e9d4d6f Make CPU and thread-related macros
available on all platforms
c55d3eb692340809889b9c8fd1ea359da19858e0 Make %_smp_mflags build rather than
parse time determined
78a7803e1f8b2a66af4a8ac277ccb5e2399e0620 Fix rpmkeys type confusion test.
fd8fb74315f7e6a4671e286b1ffdf0e323d829cc Enable malloc checking with random
perturb in the test-suite
39d95b885a7fbbe14dafc219f0c53d50d29f3a5d Remove unrelated %undefine output
from macro scoping test
d87aea2c088171e7f026abb23640b3eb588ce943 tests: add test for %verify in %files
6e5a1d2babe344dd2ae0bbcfc14a143790300541 tests: add test for Obsoletes
d4b5cc7c266a357b2f7d958dc8a1daadd61f06fb Fix regression: -bp should check
BuildRequires
17987604e0662d1d4db0740533f06d17b687819d Test if BuildDependencies are checked
for %prep
288b8a5431b04bc1bdaa5d2cb541fd30a2cb7bfb Add some basic tests for OpenPGP v3
signatures
90ad35918f06452c81a37de5170bf36af31a1c81 Fix header leak in rpmInstall()
fa29cb3bf268f9b72e80978046f2a4bf25932da2 Fix eiu->sourceURL info leak in
rpmInstall()
f78211798ea584ab04d6eca63b565ab5b80c4195 Fix file leak when src rpm in URL
format is used for installation
ca8008f327a079606130ca5bb4f204d5fb71f70c Fix h->blob leak when installing
source rpms
9ca47465a61ba881f18d5aae2bfb7cba6b47fcf6 Issue a warning when signing created
an OpenPGP v3 signature
7131fd086ae89a2c292a3d730c8ac7b7d4243ea5 Bump CI to Fedora 37
a608dba610fd57db7481960381e7eae0c160b72e Fix markdown syntax typo
92f0fa6ec3990329ff2557e4a732397b43ebcd26 Fix broken markdown quoting …
4c5052b9f6a7c205c4110e17f0423bb55ed275f9 Add missed full stop.
8e1b98c24d2c01a8f7764a7ef22e2e2b385489ce Fix Header leak when running rpm2cpio
788e37856934e56d20209446d3eafe14e12af819 Fix BANames leak in handlePreambleTag
11b68e5acddff2feb5a391e47020441cd15eae6f Fix prog leak in parseScript
62bf1f27875e287c4233265ebca755811fc74a1f Fix elf leak in getElfColor
a304de3ec87562b98a03895af35075684c7c3ea4 Fix *sbp leak when running rpmbuild
with --quiet
9576005efa6647246ba3a14a91dc2f9395684fa8 Fix memleak when running
%generate_buildrequires
1c478d4fe9963d148c5b7ff95356b168d4def6f7 Fix memleak when fsmRename failed in
fsmCommit
fcb78677923cf6f72b4be8501c8857e0b8502ff1 Fix fileleak and memleak in rpmInstall
cba15fbc86199b91977520c63ddc0a7510fb97ed Fix fileleak when urlGetFile fails in
rpmInstall
d870c393fc68298dd67c88f52c1c4a53c5cdc95d Fix typo in macros.in
50d1949673e3611cb26f4643c3a536308963ac94 brp-remove-la-files: use -0 to work
on macOS
cf0ebf8ea53be6b19ee5bb8c7220227a520625d2 Use proper macro conditional negation
syntax in the manual
f4355cac8e093aa5e2e6508049c79d5f8bcf398e Un-deprecate %_changelog_trimtime
213d8d3946ea90497f488faeb22a48667aa248fd Quote source file names in %setup
4d7503e38d2fd27c42c289dec8b98baf1584031d Testcases: rpmbuild source name with
space
e971f4dfd92f1428015ff6eff26aa9567d653ffc Revise ISANAME for loongarch
f5e1ce270824937610a501ef2478bcda85464435 Fix install of block and character
special files
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
> If you want to trim your budget more: > > * the check-buildroot cleanups, that script has been there for > 20 years > without those changes... Oh, truly. Let me drop that, too, then. One can never be overly conservative with updates :smile: > * split testing population into a script > > * drop historic remnants from test-suite PATH (unless something later > depends on these two test-suite changes) > > > Not that I think those are harmful, just seem unnecessary. Other than that I > think it looks good. True, I think I included them originally just to avoid future cherry pick conflicts regarding the test suite, but all in all, it seems unnecessary, so let me try to drop those as well. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1463528303 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
If you want to trim your budget more: - the check-buildroot cleanups, that script has been there for > 20 years without those changes... - split testing population into a script - drop historic remnants from test-suite PATH (unless something later depends on these two test-suite changes) Not that I think those are harmful, just seem unnecessary. Other than that I think it looks good. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1463453636 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
@dmnks pushed 56 commits. 53733da3609df63557c035717faa18249cc6523e Make %_smp_mflags build rather than parse time determined df6359235215095f6a93993393320f59aad2cec8 Fix rpmkeys type confusion test. 8c7029da19ffe724001be361456725374fa5e47e Enable malloc checking with random perturb in the test-suite 816ce3295d9d6b987a3403ad441f3fe0b16d4227 Remove unrelated %undefine output from macro scoping test b6cff652e6f2f8dded407015ea64fb6ac1408217 tests: add test for %verify in %files 0d39942ea6a1600c916f26d150503f1342095380 tests: add test for Obsoletes 71e7fdc7bcbc8b80511e73b3a246c521a35037eb Fix regression: -bp should check BuildRequires abb0ba1bc693383317d493a4f67c5d9f5299936b Test if BuildDependencies are checked for %prep c90a97ee6821a1723e6008063730ab7ada1cfbf3 Add some basic tests for OpenPGP v3 signatures bb7d8c9aadd5262d889f7746b48605c619f2075d Fix header leak in rpmInstall() 4ada8995a09332858c383f4c541718ddf5b08540 Fix eiu->sourceURL info leak in rpmInstall() 8eedd0f91cfd9ac919ad273a847b86e32ff73d66 Fix file leak when src rpm in URL format is used for installation 8c0f72eecaf4753db4912001e2cb804ef9cab641 Fix h->blob leak when installing source rpms 656c64e18cc98731f027905689b69698269bf023 Issue a warning when signing created an OpenPGP v3 signature 2797ec886d2b5dd7aa7ae5971ece7acc5d4ab6dc Bump CI to Fedora 37 0e02da2380ae6f74275bd381f53ad660decc5113 Fix markdown syntax typo 9bd637a3ef47e7cf344dc0bae3dd64dbdc7e02d5 Fix broken markdown quoting … efb886006c51f81a9335d4d4a80c352720d26018 Add missed full stop. 9f79a81d5be82e855cc4160ca3faba535451fe9e Fix Header leak when running rpm2cpio 1b9a8b8177e0c8df506efb38fa9aec45b1f8b919 Fix BANames leak in handlePreambleTag 1af6dd86808dc6ffe04c34e79566b7c8975b43f3 Fix prog leak in parseScript 3193285c501af92289e2070a23fb8cfee53d529b Fix elf leak in getElfColor 4f9864d15c980eda166f852d57193b848dc40a02 Fix *sbp leak when running rpmbuild with --quiet 20fbc5d98930832bea4254aba566cb55eb57ca95 Fix memleak when running %generate_buildrequires dcfe035022544dc88fc58d8c6a43809d682dc437 Fix memleak when fsmRename failed in fsmCommit 02de70bda9486f8d37a9ec2523127e5c5368f80d Fix fileleak and memleak in rpmInstall 33362f9e1fa6c5157add88797a38d8f23f7943d3 Fix fileleak when urlGetFile fails in rpmInstall 3c5e0609d336b7eb32c34648f994ec9c197d11ee Fix typo in macros.in fcfb67e20b908ff58426ac2cb14d93bf2353f273 brp-remove-la-files: use -0 to work on macOS 833ada0e8684602db0a5f360966ba1b565acd929 Use proper macro conditional negation syntax in the manual 725620cd6b0455ae3f8cd5d23dcd52c36a470370 Un-deprecate %_changelog_trimtime b292880252874fbc676c90075d1232d10acafc1b Quote source file names in %setup 1404102252777bb3596ea621b7c77093d7e4c103 Testcases: rpmbuild source name with space 28e3ab7495fbeed2b8c22d56c6cd255204bde851 Revise ISANAME for loongarch 2b4399b64806ce0224de41fc7eafb57748351ba6 Fix install of block and character special files (#2195, #2275) 8e0d9dfee5b89c98e611b0c66b165e98facd3a03 Use fd-based ops for metadata in FA_TOUCH mode too, when possible 920601f8f01b6244a6d9af05d310b06243ecef39 Never follow links in path-based chown() f7e370907c58161f95d24b98674fda71dde10ce0 Add a test for special device node installation a198e39e7ac21271f3f6242037dd2bee31a1735c Explicitly specify O_RDONLY when opening files for setmeta 7848985cb64b4daae5f5a6e940d31a32f9972e9f Use our O_DIRECTORY equivalent when opening files for setmeta 5c33e4bac288c66a0d46c5bad785543272319cff Convert most of our examples to use a modern %patch syntax fe2752424dad1dc12d2f930e45e498f9aa78cd95 Briefly document %setup and %patch in reference manual 3c7c7f65765681b45eb9c1d4797ce648fbc45639 Issue deprecation warnings on %patchN syntax 0f9ff820ba5a266462721d366f8489f2c59b8cc5 Fix macro scoping level on re-entry from %[] expresssion (#2354) d74c395786523970a311a2fa9f4e0b61dc03690c Update comments e1166a7c30c0d2272d8cbc91099a85deb69c136e Split ___build_pre macro to make mocking rpm build environment easier 8eae05af6bb809461f50424e72f22c0a71556aa3 support for POSIX getopt() behaviour 4c2d1272aba8cd279ffeba2845756b94db175b37 Document rpm codebase comment style 2a6955f9d40c3d3ab31193cfaeb98669a79b3678 fix typo 97f8fdc1f35b1525377bcb46f65acd885fb7242f Exclude kernel modules from ELF dependency generation 3b625e7ed138f96395a132b72c29c0b8151245a9 Disable debuginfod server lookups in build and dependency generator scripts 97fb98c4f7af6e6b79696e86513a4651a22878f1 docs: update grammar in dependency_generators.md d3c1ccd7c03923cc98970ef4cab721a96e0a8141 Don't repeat %patchN deprecation warning 4d4839bf940f8432e1cca1e84a8ac6555337e7fd Fix signature reserved space not restored on --delsign (#2382) 0688c4666e38982a05adae8a058dfd681fb99864 Copy original lead on signing instead of recreating 7781668fce3310174dca59178510aaf1b465a2bc Preparing for rpm 4.18.1 -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406/files/8573f154
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
OK, changes pushed, dropping the following ones: b0c9b3d87 Calculate number of threads to use during build, not spec parse d0867bcea Fix OpenMP enablement in librpmbuild (broken by cmake transition) 37ec18d86 Fix silent wait when missing input RPM package The second one is a noop without the first one, the third one is related to the `rpm2archive` changes that I decided to drop in my previous comments. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1462414681 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Oh, and I'll also drop b0c9b3d87 since that's not needed to fix the intended regression, as per #2344. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1462018833 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Should we also consider #2408? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1461930609 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
I decided to go through the picks once again and *actually* view them from the "is this an important bugfix" perspective, and removed a couple of less important commits as a result, namely these: c4eb357fe Drop a leftover mcheck.h include 4eb26a828 Drop redundant _GNU_SOURCE definitions from ndb c890b4482 Refactor db iterator locked to single rpmte to a common helper function 32fabe9b2 Remove duplicated code in doSetupMacro 37b963fa5 Allow piping from rpm2archive 8e6108a59 Use unsigned integers more consistently in the handling of tag data 5e22e0c58 rpm2archive: Properly parse popt options 7feccb696 rpm2archive: Don't print usage on no arguments In addition, as mentioned in my previous comment, I've added these two: be950eabb Fix signature reserved space not restored on --delsign (#2382) 0c02e4899 Copy original lead on signing instead of recreating I believe that should be it and we should be now good to go. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1461848531 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
@dmnks pushed 80 commits.
506d4e600de99a010884724b782b1538e51f66bf Permit building rpm from git without
pandoc
d964136eb221306cb3c1c2e0a2ce3bb06c295308 Add a handler for libselinux log
messages (RhBug:2123719, RhBug:2050774)
c5b73532e98cca1a00f0804da94a64c404d0cdb7 Split testing population into a
shell-script
e9cb47a90aa3ca6b2a59354cdeb36d40216c84fe Drop historic remnants from
test-suite PATH
31f290c2567c172c52cebde4a3159074d787d48e Add a whole bunch of epoch behavior
install tests
4f2fff809f9e591af007fbc50dbbed0d55731fe7 Handle downgrade within V-R when
epoch goes away (RhBug:1845069)
bb6db8822b722fbb03962ab25cf3feeebc72d35d Add mode string documentation to
Fopen()/Fdopen()
c807a383b6a5aa682ec58150f84e28220be9eac0 Add payload compression macro
documentation
04d6fd4f96f26bf8e6c1a40b16d650a5e9a4063d Add a blurb to hello.spec cautioning
against its use
9e5caf04201580239bdd4fb2fbfcf4e8f9b033b1 Doh, unbreak CI from commit
190354cb19af6ecdfec6f7eaa454d6afcf381128
168740c122f4697cd27d65152e5695b653b4eac5 Docs: macros: backtick-fence more
literals in body
f04dc54960a9beecdfb9141e81acc702878e3732 Docs: Macros: Attempt to fix literal
backslash
1fbb744276c91ff7dfb4c2ae4c1f6f05df9150a0 Docs: macros: Add some missing
fencing, fix grammar
ee65cf0b1063ce104b098cfd506897997e6431f7 Avoid type confusion when verifying
signatures
d85e98d086d3f765fba4908af4933797982d2366 Check packet types of signatures and
public keys
50c1cc3d73586594bff82bb2c43148c743f51c1d Reject multiple PGPTAG_PUBLIC_KEY
packets
b77da685bd8c386568eb3dd0740b92e5a3945e1f Avoid buggy (if harmless) bin symlink
in test when using /usr prefix
abf655002723353fbc077ec52559d46398b643b5 Try to use pre-compiled libmagic,
fall back to recreating if not found
3fc4eaee5e260a51f9ffc42bff4905f503e175c4 Avoid bashisms in test-suite specs
85691faaf7f85f5e409b0e65099f5d340a4d5350 Eliminate remaining %{u2p:...} uses
83217fcdc3c0f957e2d21837f7831f4a3f1a8b62 Make CPU and thread-related macros
available on all platforms
cb17b1005f280aa22808aec61efe7c890ae6a3d3 Calculate number of threads to use
during build, not spec parse
791d0588214836c8673a3986250206187fe531cb Make %_smp_mflags build rather than
parse time determined
64b63eb69e29ffe7bfd78ffe21d2b4850b037b7f Fix rpmkeys type confusion test.
971e724952d37f8f37a45d5c02894e7d55ae371c Enable malloc checking with random
perturb in the test-suite
72d16d49a954ad5f6117063bdaec113377dd14dc Remove unrelated %undefine output
from macro scoping test
08305159bced5393b4094259ca38b5f4a0bdc23e tests: add test for %verify in %files
fda38b277ef1b5e21cb8bdb022917b8da47297c5 tests: add test for Obsoletes
de253b791079bab3b3cd37092c1cd74ad29635ad Fix regression: -bp should check
BuildRequires
048946e37bd602305962f418302607642fbe8ebe Test if BuildDependencies are checked
for %prep
332f3100e6ad11f0a8475dd5ecce460c59445ba8 Fix OpenMP enablement in librpmbuild
a9bbc6e22b16ea2dd7a39f44ed2ee4552c05851b Add some basic tests for OpenPGP v3
signatures
2b4e0444b10b86f9f7be0c4e15a9e54317e758dd Fix header leak in rpmInstall()
5025ff39810435c48fe5cb033b0daa04b01c6525 Fix eiu->sourceURL info leak in
rpmInstall()
285fec3aecfec0ac4cbfa0386d5126efed25ffa9 Fix file leak when src rpm in URL
format is used for installation
cb90d9022e23dec69a3594f3740404cf76f9328e Fix h->blob leak when installing
source rpms
c4f5a065e12acb53f54134d04333a575fd3f280d Issue a warning when signing created
an OpenPGP v3 signature
a9c97de3de69afd2f8cf6cfa7ae584bab3565400 Bump CI to Fedora 37
50e7022ee46478f8c7facf0cd64762138ad7dc57 Fix markdown syntax typo
295297864fc02dd4f93368d16eb9074b35bfd9f3 Fix broken markdown quoting …
d5f258ed53838af21491b5bc07424bd820e3535d Add missed full stop.
849b2f037fd15dbb2baf9a4f97de1f8f389d98ba Fix Header leak when running rpm2cpio
194a1c44d87f0a480780103ad8a2259b1c69329f Fix BANames leak in handlePreambleTag
d54d96d7cc0b690677593e78c9198602349b72ce Fix prog leak in parseScript
f7cc5eff55903d8b783325d86f410cc2dd2f7d9f Fix elf leak in getElfColor
de2b73da10d8f45d72ee58b74dbcf24b2a09ad8e Fix *sbp leak when running rpmbuild
with --quiet
f566ce38533cab34d30b3b11c05fa1d1c5ff905e Fix memleak when running
%generate_buildrequires
f78c3b22fc25f239666224cc9eed097aa9b8be09 Fix memleak when fsmRename failed in
fsmCommit
e091796a195c68469f73649ab34e1d3e673c9fef Fix fileleak and memleak in rpmInstall
b1c8e55a1bc6a37fa90170cfa4b3cb360b0473ad Fix fileleak when urlGetFile fails in
rpmInstall
91724d7a358290e7bdf0e8743e2e9a3b53b183d2 Fix typo in macros.in
87cc67c20b71bd96282bb7a86dada9a576bf6ece brp-remove-la-files: use -0 to work
on macOS
40282035a3628e4e4259b750ad95e028611fb12f Use proper macro conditional negation
syntax in the manual
0e21632ab2dc17ff3e450698b303a76b597b3db7 Fix silent wait when missing input
RPM package
1286f05fdf2ca69eef2da75dd4097f423641715d Un-deprecate %_changelog_trimtime
0b6e6e69d7e049dc0cc792fa983ce7d0cb3d6da0 Quote source file names in %setup
f3e775d757
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Not too late, really, it's actually just in time! Let's pick these `rpmsign` fixes too, then, they seem to be important enough for some folks and are regression fixes so typically a good choice for a maintenance update. Thanks for the note, @eaon! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1461836374 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Maybe a bit too late of an addition, but since #2396 was merged today (thank you!), I wondered if it could also make it into this release, with it being a fix for a regression and all. It would really help us out, thank you! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1458311797 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
Makes sense, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1453149586 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)
> I was also wondering if we shouldn't have done a soname bump before 4.18.0 > due to the following commits which have changed or removed some public > interfaces Those interfaces are not considered public, even if the symbols may be visible in the DSOs. The rpm criteria for a public interface is whether something is present in our public headers or not. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1453139175 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
