Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)
OK, should be fixed now. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991531934 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)
Thanks, I'll update the PR accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991244835 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)
findutil() doesn't fail on purpose because we don't really want all those silly little utilities in /usr/bin/ as build-dependencies of rpm itself, most of them are only relevant for installed rpmbuild. But, clearly some of the utilities are more important than others. The easiest solution is probably adding a "required" argument to findutil() which it just passes down to find_program(). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991226157 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)
> Plain awk is commonly available, but it's quite possible to have eg a minimal > image where it's not installed. So I think we should check for it explicitly > and fail if not found. OK, I admit I was just being a bit lazy here :sweat_smile: The point of (cmake) configuration is not to *assume* but to *verify*. In that case, though, there's at least one other direct call to awk in our build process (in the test-suite) which we should also treat the same way then (so I'll handle that as part of this PR). > ... actually we _are_ already looking for awk, we just don't check the > outcome: > > ``` > findutil(__AWK awk) > ``` > > We _could_ also use the tool discovered here for this particular task I guess > Yep, although `findutil()` doesn't fail, like you said, so we either need to have it always fail, or based on a boolean argument. Which leads me to thinking - shouldn't we always fail in `findutil()`? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991212427 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)
Plain awk is commonly available, but it's quite possible to have eg a minimal image where it's not installed. So I think we should check for it explicitly and fail if not found. ... actually we *are* already looking for awk, we just don't check the outcome: ``` findutil(__AWK awk) ``` -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1990877991 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
