Re: rpmio not compiling

2011-08-10 Thread Anders F Björklund
Jeff Johnson wrote:

>> It came from splitting vendor configuration into autotools configuration:
>> https://blueprints.launchpad.net/rpm/+spec/rpm-split-vendor-config-in-autofu
>> 
>> Actual config is the same.
>> 
>> Not sure it's a good idea.
>> 
> Could you be a bit more specific about what isn't a good idea?

I'm not sure that moving from setting preprocessor macros to
autoconf variables was needed, both for RPM_VENDOR and these ?

i.e. using a --enable-rpmvercmp-digits-beat-alpha versus just
setting -DRPMVERCMP_DIGITS_BEAT_ALPHA=1 in CPPFLAGS directly.

...
> But somehow per-vendor configuration needs to be merged/dropped imho: blaming
> RPM (and me) for bugs and lack of support on code that isn't well used/tested,
> and where "vendor support" isn't an actuality, is, well, not such a good idea.

Right, I actually think the move from vendor to config is
a good idea - more uncertain about the cpp vs configure...

But obviously the "VENDOR" file isn't used anymore, and
the defined(RPM_VENDOR_*) are getting crowded for some.

The original idea of moving stuff from downstream vendor
patches to upstream conditional code was sound, I think.

But it doesn't help with the problem (= different code),
it just makes it more obvious when looking at the source.

--anders

__
RPM Package Managerhttp://rpm5.org
User Communication List rpm-users@rpm5.org


Re: rpmio not compiling

2011-08-10 Thread Jeff Johnson

On Aug 10, 2011, at 6:56 AM, Anders F Björklund wrote:

> Jeff Johnson:
> 
>>> 6. Configure RPM:
>>> -
>>> # ./configure --prefix=/usr --libdir=/usr/lib64 --with-uuid=/usr/lib64 
>>> --with-xar=/usr/lib64 \
>>>   --enable-rpm-lua-extensions-based-on-rpmlib 
>>> --enable-fast-install --enable-shared \
>>>  --enable-rpmvercmp-digits-beat-alpha --with-expat=/usr/lib64 
>>> --with-neon=/usr/lib64 \
>> 
>> Hmmm … I did not know there is a --enable-rpmvercmp-digits-beat-alpha
>> or a --enable-rpm-lua-extensions-based-on-rpmlib option.
>> 
>> I'm not at all sure what they are supposed to do or who added (its likely 
>> from RSE and OpenPKG several
>> years back). It's sure to be  some pretty arcane functionality ...
> 
> Actually it's quite new...
> http://rpm5.org/cvs/chngview?cn=15680  optional-dirname-and-symlink-deps
> http://rpm5.org/cvs/chngview?cn=15735  
> rpm-lua-extensions-based-on-rpm-lib-functionality
> http://rpm5.org/cvs/chngview?cn=16017  old-comparision-behaviour
> 
> It came from splitting vendor configuration into autotools configuration:
> https://blueprints.launchpad.net/rpm/+spec/rpm-split-vendor-config-in-autofu
> 
> Actual config is the same.
> 
> Not sure it's a good idea.
> 

Could you be a bit more specific about what isn't a good idea?

Per-vendor configuration: an excuse to not work through
the best solution. Its always based on a "Not time, we know what we are doing …"
mind-set. I don't mind the divergence if "we" did not include "me" doing
support and development.

AutoFu: I've always believed that compiled in options need to become run-time
options. The problem with compiled in options is the assumption that you
can re-compile. That is often not the case any more. And its not as simple
as adding a macro somewhere when there are deep semantic changes like version
comparison, or removing "colors" and not attaching dependencies to files etc:
configuration should be about file paths, or verbosity levels, and other UI
issues, not fundamental changes to RPM.

But somehow per-vendor configuration needs to be merged/dropped imho: blaming
RPM (and me) for bugs and lack of support on code that isn't well used/tested,
and where "vendor support" isn't an actuality, is, well, not such a good idea.

73 de Jeff

__
RPM Package Managerhttp://rpm5.org
User Communication List rpm-users@rpm5.org


Re: rpmio not compiling

2011-08-10 Thread Anders F Björklund
Jeff Johnson:

>> 6. Configure RPM:
>> -
>>  # ./configure --prefix=/usr --libdir=/usr/lib64 --with-uuid=/usr/lib64 
>> --with-xar=/usr/lib64 \
>>--enable-rpm-lua-extensions-based-on-rpmlib 
>> --enable-fast-install --enable-shared \
>>   --enable-rpmvercmp-digits-beat-alpha --with-expat=/usr/lib64 
>> --with-neon=/usr/lib64 \
> 
> Hmmm … I did not know there is a --enable-rpmvercmp-digits-beat-alpha
> or a --enable-rpm-lua-extensions-based-on-rpmlib option.
> 
> I'm not at all sure what they are supposed to do or who added (its likely 
> from RSE and OpenPKG several
> years back). It's sure to be  some pretty arcane functionality ...

Actually it's quite new...
http://rpm5.org/cvs/chngview?cn=15680  optional-dirname-and-symlink-deps
http://rpm5.org/cvs/chngview?cn=15735  
rpm-lua-extensions-based-on-rpm-lib-functionality
http://rpm5.org/cvs/chngview?cn=16017  old-comparision-behaviour

It came from splitting vendor configuration into autotools configuration:
https://blueprints.launchpad.net/rpm/+spec/rpm-split-vendor-config-in-autofu

Actual config is the same.

Not sure it's a good idea.

--anders

__
RPM Package Managerhttp://rpm5.org
User Communication List rpm-users@rpm5.org