[Bug 467] Package Review: Mosaic - Web Browser
http://bugzilla.rpmfusion.org/show_bug.cgi?id=467 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #19 from Lubomir Rintel lkund...@v3.sk 2009-04-24 09:04:18 --- Imported and built. Thanks for review! -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 547] review request: LCD patches from Ubuntu finally in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=547 --- Comment #17 from Kevin Kofler kevin.kof...@chello.at 2009-04-24 20:11:59 --- FYI, Qt 4.5.1-3 will support Freetype LCD filters if freetype-freeworld is available at runtime. The VRGB/VBGR bug got fixed in Qt 4.5.1, and we patched Qt to support the LCD filters even if Qt was built against a freetype (such as the Fedora freetype) which doesn't support them (4.5.1 checks again at runtime anyway). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 285] Review Request: VirtualBox-OSE - A general-purpose full virtualizer for PC hardware
http://bugzilla.rpmfusion.org/show_bug.cgi?id=285 --- Comment #36 from Lubomir Rintel lkund...@v3.sk 2009-04-24 22:30:38 --- (In reply to comment #35) Done. Thanks for pointing that out. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 563] Review request: xorg-x11-drv-catalyst - AMD's proprietary driver for ATI graphic cards
http://bugzilla.rpmfusion.org/show_bug.cgi?id=563
--- Comment #5 from NicolasChauvet kwiz...@gmail.com 2009-04-25 01:17:16 ---
(In reply to comment #4)
...
(In reply to comment #3)
1* Does this file remains needed with 9.4? (should be set as %config at
least)
%{_sysconfdir}/udev/makedev.d/40-catalyst-dri.nodes
(in other words, Is the module capable to create it own devices on
/dev/dri/card? )
the file need to be removed then the initrd regenerated in order to test
for
this feature.
Will test at home tonight.
What tell the testing ?
structure so we could create/destroy these files using r-c-d... I will try to
continue working on this soon, and if it works then the need for files like
udev creation and other power management files shoudn't be the priority for
now.
7* deprecated Obsoletes/Provides from fglrx package history:
This doesn't have to be introduced in the new package (could be dropped in
fglrx also actually.)
...
If we get rid of these, then FreshRPM users who install RPM Fusion will have
no
upgrade path... If we no longer wish to support this upgrade path on new
branches (ie, F-11), I'm OK with that but I think that we need to keep it for
F-9/F-10.
Wrong., only fglrx should have kept them, not catalyst. We could also assume
users have upgraded since now. Furthermore, according that F-11 users aren't
supposed to upgrade from F-9 (but from a step by F-10), we can even drop it
from F-11 fglrx package.
So to sum-up , I expect this package to be introduced in F-10/F-11 (F-9?).
F-10 and F-11 right away (will migrate from old to new scheme eventually), and
F-9 afterwards (but kept at the old scheme).
Most of the above notes at pretty trivial to fix. (since that's just few
tweaks
from a fglrx-catalyst rename) But I note this is for the old scheme. I
really
think we need to work on the new scheme for both F-10/F-11.
+1 - this is partially my fault, I don't have much time... I'm finishing the
semester mid-may, at that point I'll have much more time to finish the last
bits of r-c-d.
Okay, so we need to keep it the old way, and to convert eventually convert it
later (keeping Conflicts for now)
I'm still testing the new scheme on Rawhide with nvidia.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 478] Review Request: dosemu - dos emulator for Linux
http://bugzilla.rpmfusion.org/show_bug.cgi?id=478 --- Comment #11 from solarflo...@gmail.com 2009-04-25 02:54:59 --- (In reply to comment #10) Justin, I've sponsored your account. Please add source to the package as described above and apply for CVS. Thanks! ok, its been completed, from the info page it says I have to wait for it to be approved now. Here is the link for the updated files: http://jzygmont.fedorapeople.org/ Thanks, -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 563] Review request: xorg-x11-drv-catalyst - AMD's proprietary driver for ATI graphic cards
http://bugzilla.rpmfusion.org/show_bug.cgi?id=563
--- Comment #6 from Stewart Adam s.a...@diffingo.com 2009-04-25 03:54:42 ---
(In reply to comment #5)
(In reply to comment #4)
...
(In reply to comment #3)
1* Does this file remains needed with 9.4? (should be set as %config at
least)
%{_sysconfdir}/udev/makedev.d/40-catalyst-dri.nodes
(in other words, Is the module capable to create it own devices on
/dev/dri/card? )
the file need to be removed then the initrd regenerated in order to
test for
this feature.
Will test at home tonight.
What tell the testing ?
9.4 works well without the udev configuration file, and overall the driver
seems to run much more smoothly.
If we get rid of these, then FreshRPM users who install RPM Fusion will
have no
upgrade path... If we no longer wish to support this upgrade path on new
branches (ie, F-11), I'm OK with that but I think that we need to keep it
for
F-9/F-10.
Wrong., only fglrx should have kept them, not catalyst. We could also assume
users have upgraded since now. Furthermore, according that F-11 users aren't
supposed to upgrade from F-9 (but from a step by F-10), we can even drop it
from F-11 fglrx package.
Okay, that makes sense - provides/obsoletes removed in the package below.
Okay, so we need to keep it the old way, and to convert eventually convert it
later (keeping Conflicts for now)
That will be best for now, we can implement the new scheme for fglrx once the
power management script integration in r-c-d is finished.
SPEC: http://downloads.diffingo.com/rpmfusion/xorg-x11-drv-catalyst.spec
SRPM:
http://downloads.diffingo.com/rpmfusion/xorg-x11-drv-catalyst-9.4-2.fc10.src.rpm
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 532] Review Request: xmms2-nonfree - Nonfree plugins for XMMS2
http://bugzilla.rpmfusion.org/show_bug.cgi?id=532 Orcan Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #10 from Orcan Ogetbil oget.fed...@gmail.com 2009-04-25 05:30:41 --- There you go.. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 475] Review Request: terminatorX - Realtime Audio Synthesizer
http://bugzilla.rpmfusion.org/show_bug.cgi?id=475 Orcan Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #4 from Orcan Ogetbil oget.fed...@gmail.com 2009-04-25 05:31:28 --- Package in repos. Closing the bug. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 32] Review request: vdr-dvd - DVD playback plugin for VDR
http://bugzilla.rpmfusion.org/show_bug.cgi?id=32 Orcan Ogetbil oget.fed...@gmail.com changed: What|Removed |Added CC||oget.fed...@gmail.com --- Comment #5 from Orcan Ogetbil oget.fed...@gmail.com 2009-04-25 07:05:48 --- Ping? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 396] Review request: paintdotnet - A mono port of the Paint.NET image editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=396
--- Comment #15 from Eric Moret eric.mo...@gmail.com 2009-04-25 07:24:24 ---
Thank you for spending the time reviewing this package. Please see inline
below.
(In reply to comment #14)
Thanks. A few comments:
* Upstream provides a tarball on their website:
http://code.google.com/p/paint-mono/downloads/list
Any reason why that one is not used?
Upstream posted its first file on March 25th while this package was submitted
in February. I have since moved to using upstream´s release.
* Is it really not possible to replace the offending artwork by some free
artwork?
I would like to think so, there is an open request for icon replacement at the
fedora wiki
https://fedoraproject.org/wiki/Artwork/DesignService#Paint.NET_icon_replacement
* Any possible license issues with Sources 3-6 ? You should explain where and
how to get them in the SPEC file.
I created a script to extract those icons.
* Similarly, the patches should be explained, and if they are not Fedora
specific, sent upstream. Links from their upstream should be provided.
It *seems* to me the change to using upstream´s tarball has taken care of this
patch therefore I have removed this patch but I do not currently have access to
an x86_64 box to test. Prior to including this patch I had also created an
upstream bug as seen at the following link:
http://code.google.com/p/paint-mono/issues/detail?id=20
* Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
ok
* Please don't use a --vendor flag on desktop-file-install
I had to include this for me to be able to build on CentOS5 which is one of my
target systems. What is the workaround there?
* %attr(0644,root,root) is not needed
! %dir %{_libdir}/%{name}
%{_libdir}/%{name}/*
can be replaced by just
%{_libdir}/%{name}/
ok
* Any reason why you use
./configure --prefix=%{_prefix} --libdir=%{_libdir}
instead of just
%configure
?
The configure script provided by upstream only supported the above 2 options
(has moved to only supporting --prefix now)
* Please update to the latest icon cache scriptlets:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
ok
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 478] Review Request: dosemu - dos emulator for Linux
http://bugzilla.rpmfusion.org/show_bug.cgi?id=478 --- Comment #12 from Lubomir Rintel lkund...@v3.sk 2009-04-25 07:26:06 --- I already approved this (see bottom of comment #1, and it blocks bug #4, which means it is accepted). So, to reiterate: APPROVED -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
