Re: When to close a review request?

[Andrea Musuruane]

On Tue, Jun 28, 2011 at 7:37 PM, Richard Shaw hobbes1...@gmail.com wrote:
 I was looking through bugs 3 and 4 and noticed that my review request
 for imagination was will open. I couldn't remember what the proper
 procedure was to close it. Looking at the rpmfusion contributor
 page[1] didn't seem to say one way or the other. Imagination is still
 in free-testing so should I wait until it makes it into the stable
 repo?

No. From the Contributors page:
Once the package built successfully, go back to your bug review and
add a comment to the review to notify the import and build have been
done correctly. Then close the bug as RESOLVED FIXED. 

Regards,

Andrea.

[Bug 32] Review request: vdr-dvd - DVD playback plugin for VDR

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=32


Andrea Musuruane musur...@gmail.com changed:

   What|Removed |Added

 CC||musur...@gmail.com
 Status|ASSIGNED|RESOLVED
 Resolution||WONTFIX




--- Comment #7 from Andrea Musuruane musur...@gmail.com  2011-06-29 09:41:51 
---
(In reply to comment #6)
 The URLs to the spec and source rpm are broken. Should this review request be
 closed?

This review request has been without a response from the submitter for more
than 2 years therefore I'm going to close it.

If the submitter wants to update the package following the reviewer requests he
is free to do and to reopen this bug.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

Re: When to close a review request?

[Richard Shaw]

On Wed, Jun 29, 2011 at 2:37 AM, Andrea Musuruane musur...@gmail.com wrote:
 No. From the Contributors page:
 Once the package built successfully, go back to your bug review and
 add a comment to the review to notify the import and build have been
 done correctly. Then close the bug as RESOLVED FIXED. 

Thanks for pointing that out! I missed it.

That's pretty important and I'm not sure having that information under
Request a Build, perhaps it would be better to make it more
prominent and add another section (3.8) for things that need to be
done after a successful build.

Thanks,
Richard

[Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702


Richard hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




--- Comment #23 from Richard hobbes1...@gmail.com  2011-06-29 15:11:25 ---
Packages for all active branches are in the testing repos.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

Reminder: End Of Life for F-13 has passed

[Nicolas Chauvet]

Hi,

This is a reminder that Fedora 13 is now EOL;
http://lists.fedoraproject.org/pipermail/devel-announce/2011-June/000811.html

This worth for RPM Fusion packages also, no new updates will be provided.



Nicolas (kwizart)

[Bug 1829] Review request: deadbeef-0.5.1 - A music player with *.cue support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829


Xavier Bachelot xav...@bachelot.org changed:

   What|Removed |Added

 CC||xav...@bachelot.org




--- Comment #1 from Xavier Bachelot xav...@bachelot.org  2011-06-30 00:46:35 
---
I'm not a sponsor but I can try to help with the first steps of the review. RPM
Fusion packages are subject to the same packaging guidelines as Fedora, so
please make sure to take a look at them. It'll explain a lot of what you need
to do with the below rpmlint warnings.
https://fedoraproject.org/wiki/Packaging:Guidelines

 rpmlint deadbeef-0.5.1-1.fc15.i686.rpm

rpmlint should be run on the SRPM too. This will list some more things to fix
in the spec, but let's start with what you listed first.
https://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint

 deadbeef.i686: E: explicit-lib-dependency alsa-lib
 deadbeef.i686: E: explicit-lib-dependency imlib2
 deadbeef.i686: E: explicit-lib-dependency libX11
 deadbeef.i686: E: explicit-lib-dependency libcddb
 deadbeef.i686: E: explicit-lib-dependency libcdio
 deadbeef.i686: E: explicit-lib-dependency libcurl
 deadbeef.i686: E: explicit-lib-dependency libmad
 deadbeef.i686: E: explicit-lib-dependency libmms
 deadbeef.i686: E: explicit-lib-dependency libogg
 deadbeef.i686: E: explicit-lib-dependency libsamplerate
 deadbeef.i686: E: explicit-lib-dependency libsndfile
 deadbeef.i686: E: explicit-lib-dependency libvorbis
 deadbeef.i686: E: explicit-lib-dependency libzip
 deadbeef.i686: E: explicit-lib-dependency pulseaudio-libs
 deadbeef.i686: E: explicit-lib-dependency zlib

You don't need to require the libs, they will be autodetected at build time and
the proper requires added automatically. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

 deadbeef.i686: E: description-line-too-long C (though now it also runs in 
 plain
 console without X, in FreeBSD, and in OpenSolaris).
 deadbeef.i686: E: description-line-too-long C It is mainly written by Alexey
 Yakovenko, with contributions from a lot of different people

The lines in the description should not have more than 80 characters. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

 deadbeef.i686: W: incoherent-version-in-changelog Yakovenko ['0.5.1-1.fc15',
 '0.5.1-1']

Please add the version and release to all changelog entries.
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/sndfile.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/supereq.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/wavpack.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vfs_zip.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vorbis.a
 deadbeef.i686: W: devel-file-in-non-devel-package
 /usr/lib/deadbeef/ddb_gui_GTK2.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/pulse.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/musepack.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/mms.a
 deadbeef.i686: W: devel-file-in-non-devel-package
 /usr/lib/deadbeef/dsp_libsrc.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/ffmpeg.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/tta.a
 deadbeef.i686: W: devel-file-in-non-devel-package 
 /usr/lib/deadbeef/converter.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/hotkeys.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/flac.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/cdda.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/adplug.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vtx.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/lastfm.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/nullout.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/alsa.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/mpgmad.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/oss.a
 deadbeef.i686: W: devel-file-in-non-devel-package
 /usr/include/deadbeef/deadbeef.h
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/notify.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/artwork.a
 deadbeef.i686: W: devel-file-in-non-devel-package
 /usr/include/deadbeef/gtkui_api.h
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/gme.a
 deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/dca.a
 deadbeef.i686: W: devel-file-in-non-devel-package
 /usr/lib/deadbeef/converter_gtkui.a
 deadbeef.i686: W: devel-file-in-non-devel-package