[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com AssignedTo|rpmfusion-package-review@rp |ktdre...@ktdreyer.com |mfusion.org | --- Comment #1 from Ken Dreyer ktdre...@ktdreyer.com 2012-07-01 08:35:38 CEST --- I will take this review. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366
--- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com 2012-07-01 11:34:19 CEST
---
Just for reference, the original mythtv review was at Bug 27.
Package Review (generated by fedora-review 0.1.3)
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
No %build section.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
Bundles a couple Javascript libs, but Javascript is exempt from Fedora's
bundled libs policies.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[-]: MUST Package is not known to require ExcludeArch.
[!]: MUST Permissions on files are set properly.
See rpmlint output. Some 775 directories need to be set to 755.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
The license of this package is simpler than the main mythtv package; details at
the bottom of my review.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint mythweb-0.25-1.fc18.src.rpm
mythweb.src: W: no-%build-section
mythweb.src: W: invalid-url Source0: MythTV-mythweb-v0.25-0-g1d056f7.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint mythweb-0.25-1.fc18.noarch.rpm
mythweb.noarch: E: non-standard-dir-perm /usr/share/mythweb/skins/haze_dark/img
0775L
(... snipped the hundred non-standard-dir-perm errors identical to above ...)
mythweb.noarch: E: incorrect-fsf-address
/usr/share/mythweb/modules/music/mp3act_main.php
mythweb.noarch: E: incorrect-fsf-address /usr/share/mythweb/includes/mobile.php
mythweb.noarch: E: non-executable-script
/usr/share/mythweb/modules/coverart/handler.pl 0644L /usr/bin/perl
mythweb.noarch: E: zero-length /usr/share/mythweb/skins/default/video.css
1 packages and 0 specfiles checked; 106 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
Package source is generated by developer.
MythTV-mythweb-v0.25-0-g1d056f7.tar.gz: 370bf39a67c1d405d455e4ff74180cba
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]:
[Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
https://bugzilla.rpmfusion.org/show_bug.cgi?id=34 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Blocks||2053 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
https://bugzilla.rpmfusion.org/show_bug.cgi?id=34 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com Blocks||33 --- Comment #10 from Ken Dreyer ktdre...@ktdreyer.com 2012-07-01 14:40:43 CEST --- Package Change Request == Package Name: mythtv New Branches: EL-6 Updated EPEL Owners: hobbes1...@gmail.com ktdre...@ktdreyer.com -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
https://bugzilla.rpmfusion.org/show_bug.cgi?id=34 --- Comment #11 from Ken Dreyer ktdre...@ktdreyer.com 2012-07-01 14:41:11 CEST --- Package Change Request == Package Name: xmltv New Branches: EL-6 Updated EPEL Owners: hobbes1...@gmail.com ktdre...@ktdreyer.com -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366
Richard hobbes1...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #3 from Richard hobbes1...@gmail.com 2012-07-01 16:53:23 CEST ---
(In reply to comment #2)
Must: Please add a %build section. Interestingly your spec crashed
fedora-review :) https://bugzilla.redhat.com/836772
Should we add something just to placate fedora-review? As far as I know it
isn't strictly needed, unless there's a guideline I missed? It could be added
manually just to fix fedora-review (which I assume you did) but I'd rather not
put it in permanently if there's no requirement to do so.
Must: Please fix the directory permissions. Something like this should do the
trick: find . -type d -print0 | xargs -0 chmod 755
Strange, this seems to have been done on purpose by Jarod. I'm not sure why.
%defattr(-,apache,apache,0775)
%{_datadir}/mythweb/
I took it out. I don't think it should break anything.
Must: Please adjust the licensing, since it differs slightly from the main
MythTV package. From what I see it is just GPLv2 and LGPLv2 and MIT.
Done.
Nice-to-have items, that do not block approval, in order of preference:
You may want to put a note in the comments on how to generate
mythweb-fixes.patch. I imagine it's just a git diff TAG1..TAG2 thing?
Added... Since HEAD is assumed I use:
git diff -p --stat %{version} mythweb-fixes.patch
I'm not sure mythtv-backend is a strict requirement, since technically the web
interface could run on a separate box from the backend server. Same for the
Requires: mysql-server.
Yeah, here I have to choose from the best compromise situation since RPM
fails us here. People who run separate FE/BE configurations are more likely to
know what they're doing so and can probably build MythTV from source. I suppose
though that people who use the everything install via the mythtv meta package
are covered. I'll think about it.
Maybe add a note in the comments to give a hint for what githash3 and
githash4 are. Also, now that the package is split, can these variables be
renamed to githash1 and githash2?
Done.
This is just a minor style thing, but httpd 1.3 is very ancient. It would be
cleaner to remove the specific httpd version number and say Require: httpd.
Done.
If you want to silence the non-executable-script warning, you can use sed in
%prep: sed -i modules/coverart/handler.pl -e '/\/usr\/bin\/perl/d'
Done.
SPEC: https://dl.dropbox.com/u/34775202/mythweb/mythweb.spec
SRPM: https://dl.dropbox.com/u/34775202/mythweb/mythweb-0.25.1-2.fc16.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 1278] Review Request: mpg123 - MPEG audio player
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com Blocks||33 --- Comment #22 from Richard hobbes1...@gmail.com 2012-07-01 16:55:18 CEST --- Package Change Request == Package Name: mpg123 New Branches: EL-6 Updated EPEL Owners: hobbes1...@gmail.com ktdre...@ktdreyer.com -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 1278] Review Request: mpg123 - MPEG audio player
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 Richard hobbes1...@gmail.com changed: What|Removed |Added Blocks||2131 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366 Richard hobbes1...@gmail.com changed: What|Removed |Added Blocks|2 |3 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366
--- Comment #4 from Ken Dreyer ktdre...@ktdreyer.com 2012-07-01 20:54:39 CEST
---
(In reply to comment #3)
(In reply to comment #2)
Must: Please add a %build section. Interestingly your spec crashed
fedora-review :) https://bugzilla.redhat.com/836772
Should we add something just to placate fedora-review? As far as I know it
isn't strictly needed, unless there's a guideline I missed? It could be added
manually just to fix fedora-review (which I assume you did) but I'd rather not
put it in permanently if there's no requirement to do so.
Hmm. I can't find anything on the Fedora wiki about this, but rpmlint -I
no-%build-section gives some justification. It's pretty far-fetched, since
mythweb doesn't have debuginfo packages to begin with. I guess I would add it
for rpmlint's sake.
Must: Please fix the directory permissions. Something like this should do
the trick: find . -type d -print0 | xargs -0 chmod 755
Strange, this seems to have been done on purpose by Jarod. I'm not sure why.
%defattr(-,apache,apache,0775) %{_datadir}/mythweb/
I took it out. I don't think it should break anything.
Good catch on the defattr. That was probably a typo. We can change it to 755
and skip the find+chmod.
I'm not sure mythtv-backend is a strict requirement, since technically the
web interface could run on a separate box from the backend server. Same for
the Requires: mysql-server.
Yeah, here I have to choose from the best compromise situation since RPM
fails us here. People who run separate FE/BE configurations are more likely
to know what they're doing so and can probably build MythTV from source. I
suppose though that people who use the everything install via the mythtv meta
package are covered. I'll think about it.
Yeah, since this is a case where we have a meta package available to us, my
preference would be to let the meta package handle it. Not a big deal though.
SPEC: https://dl.dropbox.com/u/34775202/mythweb/mythweb.spec
SRPM: https://dl.dropbox.com/u/34775202/mythweb/mythweb-0.25.1-2.fc16.src.rpm
Looks good, APPROVED
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098 --- Comment #61 from Alec Leamas leamas.a...@gmail.com 2012-07-01 21:35:22 CEST --- The comment on how to generate Source0 is still incomplete, I cant check the upstream source -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098 --- Comment #62 from Alec Leamas leamas.a...@gmail.com 2012-07-01 22:24:27 CEST --- I. e., the comment for Source0 is there, adding a dependency on Source1. But the comment for Source1 doesn't really work. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098 --- Comment #63 from Alec Leamas leamas.a...@gmail.com 2012-07-01 22:37:35 CEST --- The tarball generated by the script get-source-from-git.sh doesn't match the tarball in the srpm: different size, large diff. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
RPM Fusion (Fedora - nonfree) Package Build Report 2012-07-01
Packages built and released for RPM Fusion (Fedora - nonfree) 17: 8 NEW catalyst-kmod-12.6-0.1.fc17 : AMD display driver kernel module catalyst-kmod-12.6-0.1.fc17.1 catalyst-kmod-12.6-1.fc17 nvidia-173xx-kmod-173.14.35-1.fc17.3 nvidia-kmod-295.59-1.fc17.3 wl-kmod-5.100.82.112-3.fc17.4 NEW xorg-x11-drv-catalyst-12.6-0.1.fc17 : AMD's proprietary driver for ATI graphic cards xorg-x11-drv-catalyst-12.6-1.fc17 Packages built and released for RPM Fusion (Fedora - nonfree) testing/17: 1 ufoai-2.4-1.fc17 Changes in RPM Fusion (Fedora - nonfree) 17: catalyst-kmod-12.6-0.1.fc17 --- * Sun Jun 24 2012 leigh scott leigh123li...@googlemail.com - 12.6-0.1 - Update to Catalyst 12.6 beta (internal version 8.98) * Thu Jun 21 2012 Nicolas Chauvet kwiz...@gmail.com - 11.11-1.15 - Rebuilt for updated kernel * Sun Jun 17 2012 Nicolas Chauvet kwiz...@gmail.com - 11.11-1.14 - Rebuilt for updated kernel * Tue Jun 05 2012 Nicolas Chauvet kwiz...@gmail.com - 11.11-1.13 - Rebuilt for updated kernel catalyst-kmod-12.6-0.1.fc17.1 - * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 12.6-0.1.1 - Rebuilt for updated kernel * Sun Jun 24 2012 leigh scott leigh123li...@googlemail.com - 12.6-0.1 - Update to Catalyst 12.6 beta (internal version 8.98) - patch for newer kernels (3.4.0) catalyst-kmod-12.6-1.fc17 - * Sat Jun 30 2012 leigh scott leigh123li...@googlemail.com - 12.6-1 - Update to Catalyst 12.6 release (internal version 8.98) nvidia-173xx-kmod-173.14.35-1.fc17.3 * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 173.14.35-1.3 - Rebuilt for updated kernel nvidia-kmod-295.59-1.fc17.3 --- * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 1:295.59-1.3 - Rebuilt for updated kernel wl-kmod-5.100.82.112-3.fc17.4 - * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 5.100.82.112-3.4 - Rebuilt for updated kernel xorg-x11-drv-catalyst-12.6-0.1.fc17 --- * Sun Jun 24 2012 leigh scott leigh123li...@googlemail.com - 12.6-0.1 - Update to Catalyst 12.6 beta (internal version 8.98) xorg-x11-drv-catalyst-12.6-1.fc17 - * Sat Jun 30 2012 leigh scott leigh123li...@googlemail.com - 12.6-1 - Update to Catalyst 12.6 release (internal version 8.98) Changes in RPM Fusion (Fedora - nonfree) testing/17: ufoai-2.4-1.fc17 * Fri Jun 29 2012 Karel Volny kvo...@redhat.com 2.4-1 - Version bump - Changelog: http://ufoai.org/wiki/index.php/Changelog/2.4 - Fixed duplicate packaging of md2tag_export.py - Added ufoslicer to -tools
RPM Fusion (Fedora - free) Package Build Report 2012-07-01
Packages built and released for RPM Fusion (Fedora - free) 17: 8 buildsys-build-rpmfusion-17-6 ndiswrapper-kmod-1.57-2.fc17.17 openafs-kmod-1.6.1-1.fc17.15 staging-kmod-3.4.2-1.fc17.3 VirtualBox-4.1.16-6.fc17 VirtualBox-kmod-4.1.16-1.fc17.4 west-chamber-kmod-0.0.1-7.20101017svn.fc17.20 xtables-addons-kmod-1.42-2.fc17.10 Changes in RPM Fusion (Fedora - free) 17: buildsys-build-rpmfusion-17-6 - * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 10:17-6 - rebuild for kernel 3.4.4-3.fc17 ndiswrapper-kmod-1.57-2.fc17.17 --- * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 1.57-2.17 - Rebuilt for updated kernel openafs-kmod-1.6.1-1.fc17.15 * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 1.6.1-1.15 - Rebuilt for updated kernel staging-kmod-3.4.2-1.fc17.3 --- * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 3.4.2-1.3 - Rebuilt for updated kernel VirtualBox-4.1.16-6.fc17 * Sat Jun 16 2012 Sérgio Basto ser...@serjux.com - 4.1.16-6 - Don't need patch10x in F17 or minor relverisons. * Sat Jun 16 2012 Sérgio Basto ser...@serjux.com - 4.1.16-5 - Kernel patches just for rawhide, so we don't need recompile kmods. - Update strings. * Wed Jun 13 2012 Sérgio Basto ser...@serjux.com - 4.1.16-4 - Upstreamed patches to fix compiles with 3.5 kernels, kindly alerted by virtualbox team. VirtualBox-kmod-4.1.16-1.fc17.4 --- * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 4.1.16-1.4 - Rebuilt for updated kernel west-chamber-kmod-0.0.1-7.20101017svn.fc17.20 - * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 0.0.1-7.20101017svn.20 - Rebuilt for updated kernel xtables-addons-kmod-1.42-2.fc17.10 -- * Thu Jun 28 2012 Nicolas Chauvet kwiz...@gmail.com - 1.42-2.10 - Rebuilt for updated kernel
[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366 --- Comment #5 from Richard hobbes1...@gmail.com 2012-07-02 00:36:35 CEST --- (In reply to comment #4) (In reply to comment #3) (In reply to comment #2) Must: Please add a %build section. Interestingly your spec crashed fedora-review :) https://bugzilla.redhat.com/836772 Should we add something just to placate fedora-review? As far as I know it isn't strictly needed, unless there's a guideline I missed? It could be added manually just to fix fedora-review (which I assume you did) but I'd rather not put it in permanently if there's no requirement to do so. Hmm. I can't find anything on the Fedora wiki about this, but rpmlint -I no-%build-section gives some justification. It's pretty far-fetched, since mythweb doesn't have debuginfo packages to begin with. I guess I would add it for rpmlint's sake. Interesting rpmlint shows it as a warning and not an error when it feels so strongly about the problem :) -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 2366] Review request: mythweb
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366 Richard hobbes1...@gmail.com changed: What|Removed |Added Blocks|3 |4, 33 --- Comment #6 from Richard hobbes1...@gmail.com 2012-07-02 00:39:46 CEST --- Package CVS request == Package Name: mythweb Short Description: The web interface to MythTV Owners: hobbes1...@gmail.com ktdre...@ktdreyer.com Branches: EL-6 InitialCC: -- License tag: free -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
