[Bug 3833] Review request: pianobar - "pianobar" is a free/open-source, console-based Pandora client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3833 --- Comment #1 from stephendh...@gmail.com 2015-11-07 00:42:24 CET --- Please ignore the rpmlint errors above, I figured out what rpmlint was trying to tell me and fixed it. I've updated spec / srpm and rpmlint now runs cleanly: $ rpmlint RPMS/x86_64/pianobar-2014.09.28-1.fc23.x86_64.rpm pianobar.x86_64: W: spelling-error %description -l en_US eventcmd -> eventide pianobar.x86_64: W: spelling-error %description -l en_US fm -> FM, Fm, gm pianobar.x86_64: W: invalid-license AS-IS 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 3833] New: Review request: pianobar - "pianobar" is a free/open-source, console-based Pandora client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3833 Bug #: 3833 Summary: Review request: pianobar - "pianobar" is a free/open-source, console-based Pandora client Classification: Unclassified Product: Package Reviews Version: Current Platform: All OS/Version: GNU/Linux Status: NEW Severity: normal Priority: P5 Component: Review Request AssignedTo: rpmfusion-package-rev...@rpmfusion.org ReportedBy: stephendh...@gmail.com CC: rpmfusion-package-rev...@rpmfusion.org * Full URLs to the spec file and source rpm of the package. Spec: https://www.dropbox.com/s/kczgg3fm1ajfjob/pianobar.spec?dl=0 SRPM: https://www.dropbox.com/s/kn4l1s0yz5ouui1/pianobar-2014.09.28-1.fc23.src.rpm?dl=0 * A short description for the package (usually, the %description from the spec file). Pianobar is a free/open-source, console-based client for the personalized online radio Pandora * play and manage (create, add more music, delete, rename, ...) stations * rate songs and explain why they have been selected * upcoming songs/song history * customize keybindings and text output * remote control and eventcmd interface (send tracks to last.fm, for example) * proxy support for listeners outside the USA * Why this package is not eligible to be included in Fedora. It depends on ffmpeg-libs which is not available in Fedora. * The output rpmlint gives on both the source and binary packages. Explain for each message why you've chosen to ignore it. $ rpmlint SRPMS/pianobar-2014.09.28-1.fc23.src.rpm pianobar.src: W: spelling-error %description -l en_US eventcmd -> eventide pianobar.src: W: spelling-error %description -l en_US fm -> FM, Fm, gm pianobar.src: W: invalid-license AS-IS 1 packages and 0 specfiles checked; 0 errors, 3 warnings. The spelling error warnings are not correct. The license warning is just complaining that it doesn't recognize "as-is" as a license type, but if you actually read COPYING you'll see it's about as simple and permissive as could possibly be. $ rpmlint RPMS/x86_64/pianobar-2014.09.28-1.fc23.x86_64.rpm pianobar.x86_64: E: explicit-lib-dependency ffmpeg-libs pianobar.x86_64: E: explicit-lib-dependency libao pianobar.x86_64: E: explicit-lib-dependency libgcrypt pianobar.x86_64: W: spelling-error %description -l en_US eventcmd -> eventide pianobar.x86_64: W: spelling-error %description -l en_US fm -> FM, Fm, gm pianobar.x86_64: W: incoherent-version-in-changelog 2014.09.28 ['2014.09.28-1.fc23', '2014.09.28-1'] pianobar.x86_64: W: invalid-license AS-IS 1 packages and 0 specfiles checked; 3 errors, 4 warnings. Same as above, with the addition of: The three explicit-lib errors are wrong, those are the names of the rpms in question, not libraries. The version is what the upstream project uses as a version. This is my first RPM Fusion package. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 3833] Review request: pianobar - "pianobar" is a free/open-source, console-based Pandora client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3833 stephendh...@gmail.com changed: What|Removed |Added Blocks||2 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827 Antonio Trande changed: What|Removed |Added Blocks||3820, 3821 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827 Antonio Trande changed: What|Removed |Added Blocks||33 --- Comment #3 from Antonio Trande 2015-11-06 17:25:40 CET --- Package CVS request == Package Name: rfpkg Short Description: RPMFusion utility for working with dist-git Owners: sagitter Branches: f22 f23 -- License tag: free -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827 --- Comment #2 from Antonio Trande 2015-11-06 17:23:46 CET --- New release: SPEC: https://sagitter.fedorapeople.org/rfpkg/rfpkg.spec SRPM:https://sagitter.fedorapeople.org/rfpkg/rfpkg-1.20-2.20151027git62a8b0.fc23.src.rpm -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
RPM Fusion (Fedora - free) Package Build Report 2015-11-06
Packages built and released for RPM Fusion (Fedora - free) 21: 3 gstreamer1-libav-1.4.5-2.fc21 mpg123-1.22.4-1.fc21 mythtv-0.27.5-2.fc21 Packages built and released for RPM Fusion (Fedora - free) testing/21: 8 avidemux-2.6.10-1.fc21 buildsys-build-rpmfusion-21-43 moc-2.6-0.6.alpha1.fc21 mythweb-0.27.5-1.fc21 ndiswrapper-kmod-1.59-10.fc21.3 staging-kmod-4.1.4-1.fc21.7 VirtualBox-kmod-4.3.32-1.fc21.1 xtables-addons-kmod-2.9-1.fc21.1 Changes in RPM Fusion (Fedora - free) 21: gstreamer1-libav-1.4.5-2.fc21 - * Sat Oct 31 2015 Hans de Goede - 1.4.5-2 - Update bundled libav to 10.7 mpg123-1.22.4-1.fc21 * Sat Oct 31 2015 Hans de Goede - 1.22.4-1 - New upstream release 1.22.4 (rf3802) mythtv-0.27.5-2.fc21 * Mon Jul 06 2015 Richard Shaw - 0.27.5-1 - Update to latest upstream release. - Move udisks requirement to the libs package where it's actually used. - Add systemd mythtv database optimization service and timer. Changes in RPM Fusion (Fedora - free) testing/21: avidemux-2.6.10-1.fc21 -- * Tue Jun 16 2015 Richard Shaw - 2.6.10-1 - Update to latest upstream release. - Disable GTK interface as it is unmaintained and does not build. buildsys-build-rpmfusion-21-43 -- * Fri Nov 06 2015 Nicolas Chauvet - 10:21-43 - rebuild for kernel 4.1.12-101.fc21 moc-2.6-0.6.alpha1.fc21 --- * Sun Nov 01 2015 Antonio Trande - 2.6-0.6.alpha1 - Hardened builds on - 0.27-5-1 - Update to latest upstream release. ndiswrapper-kmod-1.59-10.fc21.3 --- * Fri Nov 06 2015 Nicolas Chauvet - 1.59-10.3 - Rebuilt for kernel staging-kmod-4.1.4-1.fc21.7 --- * Fri Nov 06 2015 Nicolas Chauvet - 4.1.4-1.7 - Rebuilt for kernel VirtualBox-kmod-4.3.32-1.fc21.1 --- * Fri Nov 06 2015 Nicolas Chauvet - 4.3.32-1.1 - Rebuilt for kernel xtables-addons-kmod-2.9-1.fc21.1 * Fri Nov 06 2015 Nicolas Chauvet - 2.9-1.1 - Rebuilt for kernel
RPM Fusion (Fedora - nonfree) Package Build Report 2015-11-06
Packages built and released for RPM Fusion (Fedora - nonfree) 21: 2 mame-0.167-1.fc21 qmc2-0.57-1.fc21 Packages built and released for RPM Fusion (Fedora - nonfree) testing/21: 4 catalyst-kmod-15.9-2.fc21.3 nvidia-304xx-kmod-304.128-2.fc21.1 nvidia-340xx-kmod-340.93-2.fc21.1 nvidia-kmod-355.11-3.fc21.3 Changes in RPM Fusion (Fedora - nonfree) 21: mame-0.167-1.fc21 - * Thu Oct 29 2015 Julian Sikorski - 0.167-1 - Update 0.167 - Updated the smpfix patch qmc2-0.57-1.fc21 * Fri Oct 30 2015 Julian Sikorski - 0.57-1 - Updated to 0.57 - Dropped the dat files from ini patch now that mame-data-extras is retired Changes in RPM Fusion (Fedora - nonfree) testing/21: catalyst-kmod-15.9-2.fc21.3 --- * Fri Nov 06 2015 Nicolas Chauvet - 1:15.9-2.3 - Rebuilt for kernel nvidia-304xx-kmod-304.128-2.fc21.1 -- * Fri Nov 06 2015 Nicolas Chauvet - 304.128-2.1 - Rebuilt for kernel * Sun Oct 11 2015 Nicolas Chauvet - 304.128-2 - Bump for akmod nvidia-340xx-kmod-340.93-2.fc21.1 - * Fri Nov 06 2015 Nicolas Chauvet - 1:340.93-2.1 - Rebuilt for kernel * Sun Oct 11 2015 Nicolas Chauvet - 1:340.93-2 - Bump for akmod nvidia-kmod-355.11-3.fc21.3 --- * Fri Nov 06 2015 Nicolas Chauvet - 1:355.11-3.3 - Rebuilt for kernel
Re: Building MOC for F23
2015-11-04 22:56 GMT+01:00 Nicolas Chauvet : > OK so let's try to answear for all > Until F-21 is EOL at the end of the month, and if you have an update that > can goes for f21 and later with no update already done in git for a later > branch: > Please use cvs and plague to build. Then, either add a blocker to an > existing bug with this tracker > https://bugzilla.rpmfusion.org/show_bug.cgi?id=3820, or mention your > package in this bug. > > If your update is only relevant to f22 or f23 branch, please clone your > package from github.com/rpmfusion and submit a bugreport with the update > as an attachment. (using git format-patch) > Then block this bug: https://bugzilla.rpmfusion.org/show_bug.cgi?id=3821 > Ideally you should upload the source in the rpmfusion source cache > repository. > Then provenpackager should block bug 3820 for me to submit the package for > build. > > Hopefully this is temporary until the other sides of the infra are better > dealt with... > ( anyone to package https://github.com/rpmfusion-infra/rfpkg ?) > > Thx > Hello, what about pending CVS requests for F22 and more ? Regards, Mohamed
[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827 Hans de Goede changed: What|Removed |Added Blocks|5 |4 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 5] Review Request: linux-uvc - Linux driver for USB Video Class device
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5 Hans de Goede changed: What|Removed |Added Depends on|3827| -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 5] Review Request: linux-uvc - Linux driver for USB Video Class device
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5 Hans de Goede changed: What|Removed |Added Depends on||3827 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827
Hans de Goede changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||j.w.r.dego...@gmail.com
Blocks|2 |5
AssignedTo|rpmfusion-package-review@rp |j.w.r.dego...@gmail.com
|mfusion.org |
--- Comment #1 from Hans de Goede 2015-11-06 13:15:39
CET ---
Hi,
Thanks for doing this, it is great to see some movement wrt this.
Full review done :
Good:
-
- rpmlint checks return:
rfpkg-rpmfusion-free.noarch: W: no-documentation
rfpkg-rpmfusion-nonfree.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
-> All ok
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
I do not think that we need to support EPEL-5, as you say there is no pyrpkg
there, and I do not really expect anyone to be maintaining rpmfusion packages
on EPEL-5, they may maintain packages for EPEL-5 (although even that hardly
happens), but I do not expect them to be doing that on an actual EL5 system.
If we drop support for EPEL-5, the spec file can be cleaned up a lot. Then the
following can all be removed:
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
%if 0%{?rhel} == 5
Requires: python-kitchen
%endif
rm -rf $RPM_BUILD_ROOT (from %install)
%clean
rm -rf $RPM_BUILD_ROOT
Also the installing of the bash-completion support under /etc in rawhide seems
like a bug to me which should be fixed, and then:
%if 0%{?fedora} < 24 && 0%{?rhel} < 5
%dir %{_datadir}/bash-completion
%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/completions/rfpkg
%else
%dir %{_sysconfdir}/bash_completion.d
%config(noreplace) %{_sysconfdir}/bash_completion.d/rfpkg
%endif
Can be turned into just:
%dir %{_datadir}/bash-completion
%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/completions/rfpkg
None of this really is a blocker, so I'm going to approve this, but it would be
nice to get this fixed, either before importing the package, or immediately
after import.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
