[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965
leigh scott changed:
What|Removed |Added
Blocks||4
--- Comment #21 from leigh scott ---
APPROVED
Please fix Licence tag when you import (add "BSD (3 clause)")
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 267 files have
unknown license. Detailed output of licensecheck in
/home/leigh/Desktop/3965-miam-player/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
Bundled libs included are 1: qtsingleapplication (would be nice if you used the
system provided version)
2: qxt (no qt5 version available)
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in miam-player
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file
[Bug 4222] cAudio-freeworld - MP3 support for cAudio
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4222 --- Comment #4 from Ben Rosser --- Awesome, thanks. :) Package CVS request == Package Name: cAudio-freeworld Short Description: MP3 support for cAudio Owners: tc01 Branches: f25 f24 f23 epel7 InitialCC: -- License tag: free (cAudio is built for epel7 in Fedora; I don't know what the current state of RPM Fusion support for epel is, though). -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 4222] cAudio-freeworld - MP3 support for cAudio
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4222 Antonio Trande changed: What|Removed |Added Blocks|3 |4 --- Comment #3 from Antonio Trande --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 4222] cAudio-freeworld - MP3 support for cAudio
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4222 --- Comment #2 from Ben Rosser --- Updated license tag to "zlib and LGPLv2+". Spec URL: https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/cAudio-freeworld/cAudio-freeworld.spec SRPM URL: https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/cAudio-freeworld/cAudio-freeworld-2.3.1-2.fc24.src.rpm Since the libav ticket was closed, is there something else you'd be interested in a review swap for in either RPM Fusion or Fedora proper in exchange for this review? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965 --- Comment #20 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/miam-player.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/miam-player-0.8.1-0.5git8aba652.fc24.src.rpm %changelog * Sat Sep 17 2016 Martin Gansser - 0.8.1-0.5git8aba652 - Added BR pkgconfig(Qt5X11Extras) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965 --- Comment #19 from leigh scott --- You have missing builds deps Project ERROR: Unknown module(s) in QT: x11extras Makefile:46: recipe for target 'sub-src-Core-make_first-ordered' failed make: *** [sub-src-Core-make_first-ordered] Error 3 Please ensure that it builds in mock before you submit it again! -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965
--- Comment #18 from MartinKG ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/miam-player.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/miam-player-0.8.1-0.4git8aba652.fc24.src.rpm
%changelog
* Sat Sep 17 2016 Martin Gansser -
0.8.1-0.4git8aba652
- Use ${RPM_LD_FLAGS} for QMAKE_LFLAGS
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965
--- Comment #17 from leigh scott ---
(In reply to MartinKG from comment #16)
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/miam-player.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/miam-player-0.8.1-0.
> 3git8aba652.fc24.src.rpm
>
> %changelog
> * Sat Sep 17 2016 Martin Gansser -
> 0.8.1-0.3git8aba652
> - Update to 0.8.1-0.3git8aba652
> - Added BR libappstream-glib
> - Use ${RPM_OPT_FLAGS} instead of %%{optflags}
QMAKE_LFLAGS="${RPM_OPT_FLAGS} -Wl,--as-needed" \
should be
QMAKE_LFLAGS="${RPM_LD_FLAGS} -Wl,--as-needed" \
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 1742] Review Request: vo-aacenc - VisualOn AAC encoder library
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742
--- Comment #24 from Hans de Goede ---
(In reply to rc040203 from comment #22)
> (In reply to Hans de Goede from comment #21)
>
> - MUSTFIX: Building is non-verbose
> Please append --disable-silent-rules to %configure
Fixed in 0.1.3-2
> - /usr/lib64/pkgconfig/vo-aacenc.pc seems broken to me.
>
> It uses includedir=/usr/include,
Right, vo-amrwbenc does the same thing, the users expect to need to do:
#include
I just tried building gstreamer1-plugins-bad-freeworld with vo-aacenc support
enabled and that works fine.
> - Consider to remove the "rm -rf %{buildroot}" from %install
> It's not needed anymore unless you plan to build this package for really
> ancient rhels.
Fixed in 0.1.3-2
> - Consider to remove the "Group" tags. They aren't used for anything in
> Fedora.
Fixed in 0.1.3-2
Here is 0.1.3-2 :
* Sat Sep 17 2016 Hans de Goede - 0.1.3-2
- Pass --disable-silent-rules to %%configure
- Drop obsolete Group tags, rm -rf %%{buildroot}
- Use %%make_install
http://jwrdegoede.danny.cz/vo-aacenc.spec
http://jwrdegoede.danny.cz/vo-aacenc-0.1.3-2.fc26.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965
--- Comment #16 from MartinKG ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/miam-player.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/miam-player-0.8.1-0.3git8aba652.fc24.src.rpm
%changelog
* Sat Sep 17 2016 Martin Gansser -
0.8.1-0.3git8aba652
- Update to 0.8.1-0.3git8aba652
- Added BR libappstream-glib
- Use ${RPM_OPT_FLAGS} instead of %%{optflags}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965 Bug 3965 depends on bug 3964, which changed state. Bug 3964 Summary: Review request: qtav - A media playback framework based on Qt and FFmpeg http://bugzilla.rpmfusion.org/show_bug.cgi?id=3964 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
[Bug 3964] Review request: qtav - A media playback framework based on Qt and FFmpeg
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3964 MartinKG changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #17 from MartinKG --- The import and build have been done correctly. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965
leigh scott changed:
What|Removed |Added
CC||leigh123li...@gmail.com
--- Comment #15 from leigh scott ---
A couple of things.
you have this in the spec file.
%check
appstream-util validate-relax --nonet
%{buildroot}%{_datadir}/appdata/%{name}.appdata.xml
But have missed the build requires needed for it, add
BuildRequires: libappstream-glib
second is the wrong use of LDFLAGS
%build
%{_qt5_qmake} \
QMAKE_CFLAGS="%{optflags}" \
QMAKE_CXXFLAGS="%{optflags}" \
QMAKE_LFLAGS="%{optflags} -Wl,--as-needed" \
LIB_SUFFIX="$(echo %_lib | cut -b4-)" \
CONFIG+="no_rpath recheck config_libass_link debug"
%make_build
You use optflags when it should be ldflags, change to
%build
%{_qt5_qmake} \
QMAKE_CFLAGS="${RPM_OPT_FLAGS}" \
QMAKE_CXXFLAGS="${RPM_OPT_FLAGS}" \
QMAKE_LFLAGS="${RPM_LD_FLAGS} -Wl,--as-needed" \
LIB_SUFFIX="$(echo %_lib | cut -b4-)" \
CONFIG+="no_rpath recheck config_libass_link debug"
%make_build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 4222] cAudio-freeworld - MP3 support for cAudio
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4222
--- Comment #1 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- These files are involved in the build and released under a LGPLv2+
license:
cAudio-2.3.1/Plugins/mp3Decoder/mpaudec/bits.c
cAudio-2.3.1/Plugins/mp3Decoder/mpaudec/mpaudec.c
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or
generated", "zlib/libpng". 188 files have unknown license. Detailed
output of licensecheck in /home/sagitter/review-cAudio-
freeworld/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cAudio-
freeworld-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English
[Bug 4258] Review request: libav - Audio and video processing libraries
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4258 Antonio Trande changed: What|Removed |Added Status|NEW |RESOLVED Blocks|2 | Resolution|--- |WONTFIX Assignee|rosser@gmail.com|rpmfusion-package-review@rp ||mfusion.org --- Comment #9 from Antonio Trande --- Package refused. Thanks to all. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
