https://bugzilla.rpmfusion.org/show_bug.cgi?id=4958
Bug ID: 4958
Summary: Review request: sch_cake-kmod - Kernel module (kmod)
for sch_cake
Product: Package Reviews
Version: Current
Hardware: All
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-rev...@rpmfusion.org
Reporter: dagofthed...@gmail.com
CC: rpmfusion-package-rev...@rpmfusion.org
namespace: free
URLs:
https://github.com/survient/sch_cake/raw/master/sch_cake-kmod.spec
https://github.com/survient/sch_cake/raw/master/sch_cake.spec
https://github.com/survient/sch_cake/raw/master/sch_cake-kmod-0-1.fc28.src.rpm
https://github.com/survient/sch_cake/raw/master/sch_cake-0-1.fc28.src.rpm
Description:
Kernel Module containing Cake queueing discipline(qdisc).
https://www.bufferbloat.net/projects/codel/wiki/CakeTechnical/
Justification:
Kernel modules are not allowed in the stock Fedora Repositories
rpmlint:
$ rpmlint rpmbuild/SRPMS/sch_cake-kmod-0-1.fc28.src.rpm
sch_cake-kmod.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line
6)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# Not sure what warning is, checked for spaces and didn't see any where
specified in spec file
$ rpmlint rpmbuild/SRPMS/sch_cake-0-1.fc28.src.rpm
sch_cake.src: W: spelling-error Summary(en_US) kmod -> mod, k mod, mood
sch_cake.src: W: name-repeated-in-summary C sch_cake
sch_cake.src:1: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# Summary follows convention of other rpmfusion kmods including crystalhd
# Again not sure what spacing warning is, spec file looks clean
$ rpmlint rpmbuild/RPMS/x86_64/akmod-sch_cake-0-1.fc28.x86_64.rpm
akmod-sch_cake.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# No documentation provided upstream, usage info contained in source files
$ rpmlint rpmbuild/RPMS/x86_64/kmod-sch_cake-0-1.fc28.x86_64.rpm
kmod-sch_cake.x86_64: W: spelling-error Summary(en_US) Metapackage -> Meta
package, Meta-package, Prepackage
kmod-sch_cake.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# kmodtool generates Summary, no way to tweak it without it being fixed
upstream
# No documentation provided upstream
$ rpmlint rpmbuild/RPMS/x86_64/sch_cake-0-1.fc28.x86_64.rpm
sch_cake.x86_64: W: spelling-error Summary(en_US) kmod -> mod, k mod, mood
sch_cake.x86_64: W: name-repeated-in-summary C sch_cake
sch_cake.x86_64: E: no-binary
sch_cake.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
# Summary follows convention of other rpmfusion kmods
# userland package, no binaries included
# No documentation provided upstream
Notes:
This is my first RPMFusion package submission
I am seeking a sponsor
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
