[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
https://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Nicolas Chauvet kwiz...@gmail.com changed: What|Removed |Added Blocks|33 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Thorsten Leemhuis fed...@leemhuis.info changed: What|Removed |Added Blocks||4 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Orcan Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Blocks|4 | -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 --- Comment #19 from Sergio Pascual [EMAIL PROTECTED] 2008-11-18 11:18:05 --- Well, this pgplot is patched to look for pgxwin_server in /usr/libexec/pgplot Your program is compiled statically or dynamically? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
Re: [Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
On 18.11.2008 13:04, Michael Schwendt wrote: On Tue, 18 Nov 2008 11:07:05 +0100, RPM Fusion Bugzilla wrote: --- Comment #18 from Joachim Frieben [EMAIL PROTECTED] 2008-11-18 11:07:04 --- Since there is no component pgplot in Bugzilla yet, let me add a current issue here: Then somebody fix the owners.list file. /me did a s/pgplot/pgpplot/ HTH CU knurd
Re: [Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
On 18.11.2008 13:19, Thorsten Leemhuis wrote: On 18.11.2008 13:04, Michael Schwendt wrote: On Tue, 18 Nov 2008 11:07:05 +0100, RPM Fusion Bugzilla wrote: --- Comment #18 from Joachim Frieben [EMAIL PROTECTED] 2008-11-18 11:07:04 --- Since there is no component pgplot in Bugzilla yet, let me add a current issue here: Then somebody fix the owners.list file. /me did a s/pgplot/pgpplot/ Just looked closer -- that change was wrong afaics (and thus reverted). Does somebody see what's wrong with the entry in owner.list? Fedora|pgplot|Graphic library for making simple scientific graphs|[EMAIL PROTECTED]|| CU knurd P.S.:Sorry for the noise, but the bug is a bit confusing...
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 --- Comment #20 from Joachim Frieben [EMAIL PROTECTED] 2008-11-18 14:31:37 --- Looks like it doesn not work either way: a. All demo executables /usr/bin/pgdemo?* are not linked dynamically against the pgplot library. Yet, above error message appears. b. Some self-built test executable is dynamically linked against the (c)gpgplot libraries, ldd ./test | grep pg libcpgplot.so.5 = /usr/lib64/libcpgplot.so.5 (0x0011) libpgplot.so.5 = /usr/lib64/libpgplot.so.5 (0x02bb5000) but in this case, the same error message is issued, too. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
Re: [Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
On 18.11.2008 14:42, Sergio Pascual wrote: My email is wrong. The line should be Fedora|pgplot|Graphic library for making simple scientific graphs|[EMAIL PROTECTED]|| parsa - pasra Fixed. Cu thl On Tue, Nov 18, 2008 at 1:24 PM, Thorsten Leemhuis [EMAIL PROTECTED] wrote: On 18.11.2008 13:19, Thorsten Leemhuis wrote: On 18.11.2008 13:04, Michael Schwendt wrote: On Tue, 18 Nov 2008 11:07:05 +0100, RPM Fusion Bugzilla wrote: --- Comment #18 from Joachim Frieben [EMAIL PROTECTED] 2008-11-18 11:07:04 --- Since there is no component pgplot in Bugzilla yet, let me add a current issue here: Then somebody fix the owners.list file. /me did a s/pgplot/pgpplot/ Just looked closer -- that change was wrong afaics (and thus reverted). Does somebody see what's wrong with the entry in owner.list? Fedora|pgplot|Graphic library for making simple scientific graphs|[EMAIL PROTECTED]|| CU knurd P.S.:Sorry for the noise, but the bug is a bit confusing...
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Sergio Pascual [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #21 from Sergio Pascual [EMAIL PROTECTED] 2008-11-18 15:22:05 --- I'm closing the bug, now there's a pgplot component in bugzilla. Please resubmit this in a new bug report. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Sergio Pascual [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #17 from Sergio Pascual [EMAIL PROTECTED] 2008-11-15 11:23:18 --- Built in devel and in F-9 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Xavier Lamien [EMAIL PROTECTED] changed: What|Removed |Added Blocks|33 | --- Comment #15 from Xavier Lamien [EMAIL PROTECTED] 2008-11-13 09:15:06 --- cvs done. note that f-10 branch is not yet available. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124
--- Comment #8 from Orcan Ogetbil [EMAIL PROTECTED] 2008-11-12 16:10:57 ---
Thank you,
I have two last things to ask.
* Doesn't this clause from the TCL guidelines apply for this package:
If the extension does not provide a fooConfig.sh file, then the shared library
must not be installed directly in %{_libdir} , but in the package-specific
installation directory in %{tcl_sitearch} instead. This may require a patch to
update the extension's pkgIndex.tcl file to look for the shared library in the
correct location.
* Whenever we provide something we tend to give as much information as
possible, e.g. EVR.
I think for the Provides in tcl* packages you should add -%{release} to the
end. This isn't a rule but rather a general convention.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124
--- Comment #9 from Sergio Pascual [EMAIL PROTECTED] 2008-11-13 01:49:50 ---
(In reply to comment #8)
Thank you,
I have two last things to ask.
* Doesn't this clause from the TCL guidelines apply for this package:
Well, no. The fooConfig.sh of this package is missing (as was missing the
pkgIndex.tcl). The file tk-pgplot.pc provides the same funcionallity in a much
more clean way.
* Whenever we provide something we tend to give as much information as
possible, e.g. EVR.
I think for the Provides in tcl* packages you should add -%{release} to the
end. This isn't a rule but rather a general convention.
Done, this is the new spec:
http://guaix.fis.ucm.es/~spr/pgplot.spec
http://guaix.fis.ucm.es/~spr/pgplot-5.2.2-26.fc9.src.rpm
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124
--- Comment #10 from Orcan Ogetbil [EMAIL PROTECTED] 2008-11-13 02:27:40 ---
(In reply to comment #9)
(In reply to comment #8)
Thank you,
I have two last things to ask.
* Doesn't this clause from the TCL guidelines apply for this package:
Well, no. The fooConfig.sh of this package is missing (as was missing the
pkgIndex.tcl). The file tk-pgplot.pc provides the same funcionallity in a much
more clean way.
That's where I get confused. It says when the fooConfig.sh is missing the
shared library must *not* be installed in %{_libdir}, but right now it *is*
installed in %{_libdir} . Where is the catch?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 --- Comment #11 from Sergio Pascual [EMAIL PROTECTED] 2008-11-13 02:42:30 --- The guidelines presume that the tcl package is properly constructed. A properly constructed tcl package that provides a libdir library usually has a fooConfig.sh file that instructs how to compile against the library. If the package doesn't provide fooConfig.sh one can assume that the library is a plugin not designed to be used directly with programs. But the pgplot driver isn't a properly constructed package. It misses pkgIndex.tcl (and I had to add it). In fact, I needed to patch the source code to include a function that informs tcl that is a tcl package. But libtkpgplot.so is used as a libdir library. One of the examples in the tarball is pgtkdemo. You can check in the makefile that this file is linked with the libtkpgplot.a -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 --- Comment #13 from Orcan Ogetbil [EMAIL PROTECTED] 2008-11-13 03:21:55 --- This package pglot is APPROVED for rpmfusion-nonfree by oget I consistently make the same mistake for some unknown reason. To the CVS person: The package is called *pgplot* , not pglot. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124 Sergio Pascual [EMAIL PROTECTED] changed: What|Removed |Added Blocks||33 --- Comment #14 from Sergio Pascual [EMAIL PROTECTED] 2008-11-13 08:42:47 --- For astrophysicists, 42 is a good number also :) Thanks Orcan! Package CVS request == Package Name: pgpplot Short Description: Graphic library for making simple scientific graphs Owners: sergiopr Branches: F-10 F-9 InitialCC: -- License tag: nonfree -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124
Orcan Ogetbil [EMAIL PROTECTED] changed:
What|Removed |Added
Blocks|2 |3
Alias||pgplot
AssignedTo|rpmfusion-package- |[EMAIL PROTECTED]
|[EMAIL PROTECTED]|
--- Comment #4 from Orcan Ogetbil [EMAIL PROTECTED] 2008-11-11 08:24:31 ---
I saw the copyright.notice file in the original tarball. Please ignore the
previous message. The package is in good shape. Let us go through a few minor
things:
* rpmlint says:
pgplot.x86_64: E: non-standard-executable-perm
/usr/lib64/libcpgplot.so.5.2.2 0775
pgplot.x86_64: E: non-standard-executable-perm /usr/lib64/libpgplot.so.5.2.2
0775
pgplot-tk.x86_64: E: non-standard-executable-perm
/usr/lib64/libtkpgplot.so.5.2.2 0775
These need fixed (to 755)
* Please package the Changelog files. If you want, you can concatenate them
with something like
(for i in $(find . -name ver*.txt |sort -r); do cat $i; done) ChangeLog
* We prefer defattr(-,root,root,-)
* Please make use of macros extensively and consistenly, especially the %{name}
macro, also e.g.
%{__rm} -rf %{buildroot}
in one line and
rm -fr %{buildroot}
on the other breaks consistency.
! Parallel make must be supported whenever possible. Write a comment on the
spec file if parallel make is not supported. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
* Don't we need to put the copyright notice to all the subpackages, as is told
by the copyright notice itself?
* You are supplying external .pc files. I don't understand why you're editing
(sed'ding) them again.
* Everything that is in the %build section until the ./makemake line should
be moved into %prep .
* Definitions such as
%define lvfull 5.2.2
%define lvmajor 5
are usually put to the very beginning of the SPEC file. At least, somewhere
closer to the Version tag.
By the way, %{version} = %{lvfull} = 5.2.2 . Why are you defining the same
thing twice? I think you should do something like:
%define lvmajor 5
Name: pgplot
Version: 5.2.2
...
and then use %{version} below instead of %{lvfull}.
* The tcl conventions have changed in Fedora 9. Please follow:
http://fedoraproject.org/wiki/Packaging/Tcl
see naming, installation locations etc.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
