[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

Richard hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #28 from Richard hobbes1...@gmail.com 2015-01-14 22:51:40 CET ---
Closing due to inactivity, please reopen if you're interested in pursuing this
review request.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

Alexey Komissarov nomad7...@gmail.com changed:

   What|Removed |Added

URL|http://http://deadbeef.sour |http://deadbeef.sourceforge
   |ceforge.net/|.net/

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

--- Comment #26 from starws vsncn...@gmail.com 2012-03-24 13:50:29 CET ---
New spec file with bugfixes, tested on deadbeef 0.5.2/fedora 16.

- readded rpath removal script
- new build dependency: yasm
- fixed license info
- fixed devel package architecture
- new upstream version 0.5.2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

starws vsncn...@gmail.com changed:

   What|Removed |Added

 Attachment #765 is|0   |1
   obsolete||

--- Comment #27 from starws vsncn...@gmail.com 2012-03-24 13:52:18 CET ---
Created attachment 841
  -- https://bugzilla.rpmfusion.org/attachment.cgi?id=841
deadbeef spec file

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

--- Comment #24 from starws vsncn...@gmail.com 2011-11-24 12:12:22 CET ---
New spec file with some minor bugfixes and improvements.
Tested on deadbeef 0.5.1/fedora 16.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1829

starws vsncn...@gmail.com changed:

   What|Removed |Added

 Attachment #733 is|0   |1
   obsolete||

--- Comment #25 from starws vsncn...@gmail.com 2011-11-24 12:13:36 CET ---
Created attachment 765
  -- https://bugzilla.rpmfusion.org/attachment.cgi?id=765
deadbeef spec file

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829





--- Comment #22 from starws vsncn...@gmail.com  2011-10-18 12:29:32 ---
Created an attachment (id=733)
 -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=733)
deadbeef spec file


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829


starws vsncn...@gmail.com changed:

   What|Removed |Added

 CC||vsncn...@gmail.com




--- Comment #23 from starws vsncn...@gmail.com  2011-10-18 12:31:11 ---
(In reply to comment #21)
 1.
fixed

 2.
devel subpackage is arch independent

 3. 
seems like desktop-file-install can't help

 4. 
fixed

 5.
fixed

 6.
%exclude %{_docdir} here is an upstream configure script bug workaround, I hope
it will be fixed in the next release

.a files removed


New spec file in attachments


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829


Richard hobbes1...@gmail.com changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com




--- Comment #21 from Richard hobbes1...@gmail.com  2011-10-06 20:14:49 ---
Some comments on the spec file:

1. BuildRoot:, rm -rf $RPM_BUILD_ROOT can be removed from %install, %clean
can be removed entirely, and %defattr(-,root,root) can be removed from %files
unless your building for EL5.

2. In you devel subpackage the Require: should probably be arch dependent:

Requires: %{name} = %{version}-%{release}

to

Requires: %{name}%{?_isa} = %{version}-%{release}

3. Modifying the desktop file in %prep is odd. desktop-file-install can modify
desktop files on the fly, so if it's capable of removing the Unity parts then I
would use it instead. Just research it's options.

If desktop-file-install is not capable of making the needed edits and you still
need to resort to sed then at least move it to just above your
desktop-file-install command. 

Also, currently you're not modifying anything in the desktop file by the time
you get to desktop-file-install so you could use desktop-file-validate instead.

See:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

4. Ok, you definitely took Michael's comments to heart, but perhaps went a
little too far :)

I would only add comments in %files for unusual situations. You can drop #doc,
# Files, and # Dirs.

5. %{_defaultdocdir} can just be %{_docdir}

6. In the case of the extra doc directory there's no hard rule for this that I
know of but it's my opinion that %exclude use in %files should be limited to
excluding files from one package so they can be included in a sub-package.

For instance, you might run into a situation where it would be difficult or
overly verbose to work around files that you really want to go into a -devel or
-doc subpackage. Here %exclude could be used to exclude files or directors in
the main package so they can be included in -doc or -devel.

If you're not going to include files in a package at all then it's better to
just remove them in %install like you're already doing for .la files.

For the static libraries (.a) I would just remove them if there's nothing that
actually needs them. If you need them then they should go in a -static
subpackage not in -devel.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1829] Review request: deadbeef - A music player with cue sheet support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829


Nicolas Chauvet kwiz...@gmail.com changed:

   What|Removed |Added

Summary|Review request: deadbeef - A|Review request: deadbeef - A
   |music player with *.cue |music player with cue sheet
   |support |support




-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.