[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1927

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
  namespace||free
 Blocks|2   |
 Resolution|--- |EXPIRED

--- Comment #5 from Nicolas Chauvet  ---
Please reopen if this review is still relevant.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1927

Bug 1927 depends on bug 1922, which changed state.

Bug 1922 Summary: Review request: mediastreamer - A media streaming library for 
telephony applications
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1922

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||WONTFIX

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1927


Richard hobbes1...@gmail.com changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com




--- Comment #3 from Richard hobbes1...@gmail.com  2011-10-06 19:45:28 ---
Weeding though all the incorect fsf address (which needs to be reported
upstream) output:

usr/src/debug/linphone-3.4.3/gtk/chat.c
linphone-freeworld-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/linphone-3.4.3/gtk/update.c
linphone-freeworld-debuginfo.x86_64: E: wrong-script-end-of-line-encoding
/usr/src/debug/linphone-3.4.3/gtk/update.c

These should probably be fixed.

Reviewing the spec file:

1. Minor nit: Why the white space between several of the BuildRequires? If
you're grouping them in some sort of order then I would add comments between
instead of blank lines.

2. rm -rf $RPM_BUILD_ROOT can be removed from %install, %clean can be removed
entirely, and %defattr(-,root,root) can be removed from %files unless your
building for EL5.

3. --vendor in desktop-file-install should not be set[1]

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1927





--- Comment #4 from nucleo nuc...@fedoraproject.org  2011-10-06 19:52:21 ---
Most of spec file with spaces came from Fedora, but they can be removed.

--vendor also came from Fedora so I thought that this is not entirely new
package and as commented in your link then --vendor should be used.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1927





--- Comment #2 from nucleo nuc...@fedoraproject.org  2011-09-10 20:18:12 ---
Yes, mediastreamer builds with ffmpeg-0.8.2.
And looks like linphone-freeworld works fine.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1927





--- Comment #1 from Dominik 'Rathann' Mierzejewski r...@greysector.net  
2011-09-09 01:58:07 ---
Have you tested that it builds and works fine with FFmpeg-0.8.x?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1927


nucleo nuc...@fedoraproject.org changed:

   What|Removed |Added

Summary|Review request:linphone-|Review request: linphone-
   |freeworld - Phone anywhere  |freeworld - Phone anywhere
   |in the whole world by using |in the whole world by using
   |the Internet|the Internet




-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.