[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Richard hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||hobbes1...@gmail.com
 Blocks||2
 Resolution||WONTFIX
 AssignedTo|alexjn...@gmail.com |rpmfusion-package-review@rp
   ||mfusion.org

--- Comment #20 from Richard hobbes1...@gmail.com 2015-01-14 22:58:35 CET ---
Closing due to inactivity, please reopen if you're interested in pursuing this
review request.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #19 from Jeremy Newton alexjn...@gmail.com 2014-04-05 14:23:21 
CEST ---
Are you still interested in doing this? you could go to fedora to seek
sponsorship, but alas I'm not at that level yet.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #18 from Yajo yajo@gmail.com 2012-04-23 15:21:25 CEST ---
(In reply to comment #14)
 Well the version in Fedora right now is the official stable, there was just a
 delay in the announcement of it. I just updated it a little quicker than
 upstream updated their website ;)
 As of now though, it's been announced, so there should not be any more 
 excuses;
 upstream should be notified if they haven't fixed it yet.

They know it, but seems like it will take some time to fix it.
http://forum.stabyourself.net/viewtopic.php?p=20064#p20064

 I'll take a look once upstream gets it working with 0.8.0. Also I've assigned
 myself for reviewing this, as I wish to get this included :)
 Although I can't give it an official review until you get sponsored.

Speaking about that... Can you sponsor me? Or anyone around here? I prefer in
Fedora if possible, but I know no one from there (nor here)...

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #16 from Yajo yajo@gmail.com 2012-04-18 16:05:22 CEST ---
(In reply to comment #15)
 Just a quick note though, I noticed you used a convert command. If you use
 it, you need to add ImageMagick as a BuildRequire

It has BuildRequires: /usr/bin/convert. Is it not enough?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #17 from Jeremy Newton alexjn...@hotmail.com 2012-04-18 18:17:18 
CEST ---
(In reply to comment #16)
 (In reply to comment #15)
  Just a quick note though, I noticed you used a convert command. If you use
  it, you need to add ImageMagick as a BuildRequire
 
 It has BuildRequires: /usr/bin/convert. Is it not enough?
Ah I didn't see that.
Though that does work, the convention is to use ImageMagick, which in turn
installs GraphicsMagick. I don't see any rules or reasons not to do what you
did, so I guess never mind to what I said.

Note that:
The only reason I can think of this not working is if convert is not explicitly
installed into /usr/bin. Although this would only be an issue if the install
location is changed in the future, and considering the complete move to /usr in
F17, I doubt this will ever happen.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Jeremy Newton alexjn...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|rpmfusion-package-review@rp |alexjn...@hotmail.com
   |mfusion.org |

--- Comment #14 from Jeremy Newton alexjn...@hotmail.com 2012-04-18 03:57:58 
CEST ---
(In reply to comment #13)
 I see upstream reasonable here, so the best we can do is wait for LÖVE 0.8.0 
 to
 become officially stable. Right now I'm running the game by having separate
 stable and unstable versions of LÖVE.

Well the version in Fedora right now is the official stable, there was just a
delay in the announcement of it. I just updated it a little quicker than
upstream updated their website ;)
As of now though, it's been announced, so there should not be any more excuses;
upstream should be notified if they haven't fixed it yet.

 New SRPM in http://www.mediafire.com/?2erv9ub6c8wc24q
 
 Please check. If it's alright I'd thank some info about the sponsorship.

I'll take a look once upstream gets it working with 0.8.0. Also I've assigned
myself for reviewing this, as I wish to get this included :)
Although I can't give it an official review until you get sponsored.

As for sponsorship, you can either seek sponsorship in Fedora, in which you
will automatically be sponsored in RPMFusion, or you can just seek sponsorship
in just RPMFusion. I found that it was a lot faster to get sponsored in Fedora
than RPMFusion, but if you have no interest in that, then there's no need to do
it.

Generally the rules in RPMFusion are the same as Fedora, with a some
exceptions. Naturally you can generally take a look at the Fedora wiki's to get
an idea on how this works:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Note that all the RPMFusion specific stuff can be here:
http://rpmfusion.org/Contributors

On a side note, I submitted orthorobot if you're interested:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2219
I plan to submit Mari0 in the next day or two; I just need to post the review
request. I've had it uploaded to my dropbox quite a few weeks ago, but I've
been busy unfortunately.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #15 from Jeremy Newton alexjn...@hotmail.com 2012-04-18 04:12:45 
CEST ---
Just a quick note though, I noticed you used a convert command. If you use
it, you need to add ImageMagick as a BuildRequire

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #13 from Yajo yajo@gmail.com 2012-04-08 17:41:54 CEST ---
(In reply to comment #10)
 I would like to strongly note that you are not required to make a man page,
 though it's just highly suggested.

I saw yours, but it's a bit hard of understand when you never made one before.
If it is not required, and being the case that I don't think it would help at
all (as the executable has no arguments and descriptions are viewable from the
RPM), i think I'll skip this step.

If anyone wants to make one, I can include it though.


 On another note, the version of love I submitted for fedora, which is still in
 updates testing, is version 0.8.0. Though they have not advertised it on their
 website yet, love 0.8.0 has been tagged in their SCM (bitbucket). I'm not sure
 what this is all about.
 Anyway, Not tetris at the moment does not work on 0.8.0, and I contacted
 upstream about this. They said until love 0.8.0 is official released they
 don't plan to update Not Tetris.
 Naturally this issue puts this review on hold unless you would like to take a
 crack at making a patch yourself or would like to contact upstream for one.

I see upstream reasonable here, so the best we can do is wait for LÖVE 0.8.0 to
become officially stable. Right now I'm running the game by having separate
stable and unstable versions of LÖVE.

(In reply to comment #11)
 When you put an icon in /usr/share/pixmaps you don't need the icon cache
 scriptlets. But the preferred locations for icons is under
 /usr/share/icons/hicolor/apps/#x# so unless there is a specific reason not
 to put the icon there, please put it there.

Moved back there and scriptlets added.


 Right, %defattr is there in a lot of packages simply because it never got
 removed
 it is not needed anymore these days...

Thanks for the info. It's nice to have experts around.


New SRPM in http://www.mediafire.com/?2erv9ub6c8wc24q

Please check. If it's alright I'd thank some info about the sponsorship.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #11 from Hans de Goede j.w.r.dego...@gmail.com 2012-04-07 
09:48:01 CEST ---
(In reply to comment #10)
 (In reply to comment #9)

snip

   -You missing %post, %postun and %posttrans sections, which are required 
   for
   desktop files with icons: (you can also see my SPRM below)
   https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files
  
  Well, in 
  https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
  says that is to do when 'an application installs icons into one of the
  subdirectories in %{_datadir}/icons/', but that's not the case anymore. 
  Seeing
  your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous
  condition is not fulfilled anymore. For that reason, I did not add those
  scriptlets. Correct me if I'm wrong, please.
 
 I believe pixmaps is also a part of the icon cache, thus it still needs to be
 updated, though I am not completely sure on this. I'll let you know when I
 figure that out. I guess I just always assumed it should be there without
 checking.

When you put an icon in /usr/share/pixmaps you don't need the icon cache
scriptlets. But the preferred locations for icons is under
/usr/share/icons/hicolor/apps/#x# so unless there is a specific reason not
to put the icon there, please put it there.

   -To my knowledge %defattr(-, root, root) shouldn't be required, but to be
   honest I've never used it before.
  
  I never really understood that. I used to put it because I saw it in a lot 
  of
  places. Anyway I removed that.
 
 I believe that is for compatibility with RedHat EL 5, and unless you plan to
 package for EPEL 5, it's pointless. As well I'm only currently maintaining 
 love
 for Fedora 15, 16, 17, devel/rawhide

Right, %defattr is there in a lot of packages simply because it never got
removed
it is not needed anymore these days...

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

 CC||p...@city-fan.org

--- Comment #12 from Paul Howarth p...@city-fan.org 2012-04-07 11:33:41 CEST 
---
(In reply to comment #11)
 (In reply to comment #10)
  (In reply to comment #9)
-To my knowledge %defattr(-, root, root) shouldn't be required, but to 
be
honest I've never used it before.
   
   I never really understood that. I used to put it because I saw it in a 
   lot of
   places. Anyway I removed that.
  
  I believe that is for compatibility with RedHat EL 5, and unless you plan to
  package for EPEL 5, it's pointless. As well I'm only currently maintaining 
  love
  for Fedora 15, 16, 17, devel/rawhide
 
 Right, %defattr is there in a lot of packages simply because it never got
 removed
 it is not needed anymore these days...

It's not needed for EL-5 even; it became redundant with rpm 4.4, so the last
supported release that needed it was EL-4, which is now EOL.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Yajo yajo@gmail.com changed:

   What|Removed |Added

 Blocks||30

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #9 from Yajo yajo@gmail.com 2012-04-06 19:24:42 CEST ---
Sorry for the delay.

(In reply to comment #3)
 A bunch of notes, I can do a full review later:
 [...]

Great help, thanks. I followed almost all of these, and your SRPM was of great
help. Just a few points:


 -You missing %post, %postun and %posttrans sections, which are required for
 desktop files with icons: (you can also see my SPRM below)
 https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files

Well, in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
says that is to do when 'an application installs icons into one of the
subdirectories in %{_datadir}/icons/', but that's not the case anymore. Seeing
your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous
condition is not fulfilled anymore. For that reason, I did not add those
scriptlets. Correct me if I'm wrong, please.


 By the way, kudos for the idea of getting the logo from the love file, it 
 never
 occurred to me to do that.

Thanks. If you are thinking about packaging mari0, just mention that you can do
that there too. If not, I can package it.


 -Man pages are not vital for getting your package accepted, but it is 
 suggested
 to look into making one.

I have not a clue about how to do this. I think this should be upstream work,
though.


 -To my knowledge %defattr(-, root, root) shouldn't be required, but to be
 honest I've never used it before.

I never really understood that. I used to put it because I saw it in a lot of
places. Anyway I removed that.

Here is my new SRPM: http://www.mediafire.com/?82odbzgh9jr8vc6

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #10 from Jeremy Newton alexjn...@hotmail.com 2012-04-06 20:51:24 
CEST ---
(In reply to comment #9)
 Sorry for the delay.
 
 (In reply to comment #3)
  A bunch of notes, I can do a full review later:
  [...]
 
 Great help, thanks. I followed almost all of these, and your SRPM was of great

No problem, always up to help :)

  -You missing %post, %postun and %posttrans sections, which are required for
  desktop files with icons: (you can also see my SPRM below)
  https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files
 
 Well, in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
 says that is to do when 'an application installs icons into one of the
 subdirectories in %{_datadir}/icons/', but that's not the case anymore. Seeing
 your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous
 condition is not fulfilled anymore. For that reason, I did not add those
 scriptlets. Correct me if I'm wrong, please.

I believe pixmaps is also a part of the icon cache, thus it still needs to be
updated, though I am not completely sure on this. I'll let you know when I
figure that out. I guess I just always assumed it should be there without
checking.

  By the way, kudos for the idea of getting the logo from the love file, it 
  never
  occurred to me to do that.
 
 Thanks. If you are thinking about packaging mari0, just mention that you can 
 do
 that there too. If not, I can package it.

I have mari0 packaged, I just need to upload it. I got love accepted into
Fedora, so I just want to run a quick test before I upload it.

  -Man pages are not vital for getting your package accepted, but it is 
  suggested
  to look into making one.
 
 I have not a clue about how to do this. I think this should be upstream work,
 though.

It's very simple, you can make one in a few minutes. Take a look at my love
package for an example:
http://kojipkgs.fedoraproject.org/packages/love/0.8.0/2.fc18/src/love-0.8.0-2.fc18.src.rpm
Just open the love.1 with a text editor and the rest is easy.

You can either make one or ask upstream to make one, which I highly doubt they
will. If you do make one, you can send it upstream and they may include it in
the linux version though.

I would like to strongly note that you are not required to make a man page,
though it's just highly suggested.

  -To my knowledge %defattr(-, root, root) shouldn't be required, but to be
  honest I've never used it before.
 
 I never really understood that. I used to put it because I saw it in a lot of
 places. Anyway I removed that.

I believe that is for compatibility with RedHat EL 5, and unless you plan to
package for EPEL 5, it's pointless. As well I'm only currently maintaining love
for Fedora 15, 16, 17, devel/rawhide


On another note, the version of love I submitted for fedora, which is still in
updates testing, is version 0.8.0. Though they have not advertised it on their
website yet, love 0.8.0 has been tagged in their SCM (bitbucket). I'm not sure
what this is all about.
Anyway, Not tetris at the moment does not work on 0.8.0, and I contacted
upstream about this. They said until love 0.8.0 is official released they
don't plan to update Not Tetris.
Naturally this issue puts this review on hold unless you would like to take a
crack at making a patch yourself or would like to contact upstream for one.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #8 from Jeremy Newton alexjn...@hotmail.com 2012-03-11 17:33:34 
CET ---
(In reply to comment #7)
 (In reply to comment #4)
  (In reply to comment #1)
 nottetris.src: W: invalid-license CC-BY-NC-SA
 nottetris.noarch: W: invalid-license CC-BY-NC-SA
That's the license, like it or not.
   
   FYI, that's a non-Free license, which 1. means this needs to go into 
   nonfree
   and 2. should have been listed as another reason why this cannot go into
   Fedora.
  
  I would figure this is due to the fact that, despite the code being publicly
  available, it requires consent of the author?
 
 No, it is because of the NC clause. NC clauses are considered non Free by
 Fedora, Debian, OSI, etc.

Good to know, thanks, I was always confused about that one.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Jeremy Newton alexjn...@hotmail.com changed:

   What|Removed |Added

 CC||alexjn...@hotmail.com

--- Comment #3 from Jeremy Newton alexjn...@hotmail.com 2012-03-10 22:39:54 
CET ---
A bunch of notes, I can do a full review later:

-the Love Review Request has been moved to Fedora (but you probably know that
already):
https://bugzilla.redhat.com/show_bug.cgi?id=802050

-Your desktop file should to be installed via proper methods (ie.
desktop-file-install):
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
this allows you to have feedback for what maybe wrong with your desktop file,
if an issue exists. For example I can tell that one of the fields in your
desktop file should be removed. (see my SPRM below)

-You missing %post, %postun and %posttrans sections, which are required for
desktop files with icons: (you can also see my SPRM below)
https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files

-I would suggest using a secondary source rather than the echo commands, as it
may make the spec a little less legible/clean. Furthermore, a license probably
file should be included (see my SPRM below)

-unzip is not required, as described in the fedora guidelines:
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

-I would suggest to make an attachment for your spec file or upload it
somewhere instead of posting it directly in the comments for proceeding
revisions. I would suggest dropbox, as an account is free and the public folder
allows you to copy the public link.

-You can silence the RPMLint warning by making an empty %build section (see my
SPRM below)

-you seem to have beat me to packaging this, and maybe if you take a look at my
SPRM, as it could help:
http://dl.dropbox.com/u/42480493/nottetris-2.0-1.fc16.src.rpm
By the way, kudos for the idea of getting the logo from the love file, it never
occurred to me to do that.

-If this is your first package, I would guess that you have not yet been
sponsored. If you're not sponsored in either RPM Fusion or Fedora, please block
bug#30.

-Man pages are not vital for getting your package accepted, but it is suggested
to look into making one.

-To my knowledge %defattr(-, root, root) shouldn't be required, but to be
honest I've never used it before.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #4 from Jeremy Newton alexjn...@hotmail.com 2012-03-10 22:42:58 
CET ---
(In reply to comment #1)
   nottetris.src: W: invalid-license CC-BY-NC-SA
   nottetris.noarch: W: invalid-license CC-BY-NC-SA
  That's the license, like it or not.
 
 FYI, that's a non-Free license, which 1. means this needs to go into nonfree
 and 2. should have been listed as another reason why this cannot go into
 Fedora.

I would figure this is due to the fact that, despite the code being publicly
available, it requires consent of the author?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #5 from Jeremy Newton alexjn...@hotmail.com 2012-03-10 22:55:30 
CET ---
Also Group: is depreciated

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #6 from Jeremy Newton alexjn...@hotmail.com 2012-03-10 23:07:50 
CET ---
You can also look at this as another example if it helps:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2219

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

Hans de Goede j.w.r.dego...@gmail.com changed:

   What|Removed |Added

 CC||j.w.r.dego...@gmail.com

--- Comment #7 from Hans de Goede j.w.r.dego...@gmail.com 2012-03-11 08:29:36 
CET ---
(In reply to comment #4)
 (In reply to comment #1)
nottetris.src: W: invalid-license CC-BY-NC-SA
nottetris.noarch: W: invalid-license CC-BY-NC-SA
   That's the license, like it or not.
  
  FYI, that's a non-Free license, which 1. means this needs to go into nonfree
  and 2. should have been listed as another reason why this cannot go into
  Fedora.
 
 I would figure this is due to the fact that, despite the code being publicly
 available, it requires consent of the author?

No, it is because of the NC clause. NC clauses are considered non Free by
Fedora, Debian, OSI, etc.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #1 from Kevin Kofler kevin.kof...@chello.at 2012-03-09 16:22:41 
CET ---
  nottetris.src: W: invalid-license CC-BY-NC-SA
  nottetris.noarch: W: invalid-license CC-BY-NC-SA
 That's the license, like it or not.

FYI, that's a non-Free license, which 1. means this needs to go into nonfree
and 2. should have been listed as another reason why this cannot go into
Fedora.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #2 from Yajo yajo@gmail.com 2012-03-09 19:09:52 CET ---
(In reply to comment #1)
   nottetris.src: W: invalid-license CC-BY-NC-SA
   nottetris.noarch: W: invalid-license CC-BY-NC-SA
  That's the license, like it or not.
 
 FYI, that's a non-Free license, which 1. means this needs to go into nonfree
 and 2. should have been listed as another reason why this cannot go into
 Fedora.

True, I did not know until today. Thanks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.