[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 Orcan Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Blocks|4 | Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #19 from Orcan Ogetbil oget.fed...@gmail.com 2009-01-16 19:03:54 --- Package has been in the repo for a while. Closing the bug. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 --- Comment #14 from NicolasChauvet kwiz...@gmail.com 2008-12-16 10:29:55 --- Well, It seems that the related mac package is nonfree. so It won't be enabled in the freeworld version I guess. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 NicolasChauvet kwiz...@gmail.com changed: What|Removed |Added Blocks|3 |4 --- Comment #15 from NicolasChauvet kwiz...@gmail.com 2008-12-16 12:02:10 --- Package built with mock on F-10 x86 and F-9 x86_64. Tested at runtime on both arches, everything is fine. -- This package (xmms2-freeworld) is APPROVED -- -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 Thorsten Leemhuis fed...@leemhuis.info changed: What|Removed |Added CC||fed...@leemhuis.info Blocks|33 | --- Comment #17 from Thorsten Leemhuis fed...@leemhuis.info 2008-12-16 19:31:10 --- (In reply to comment #16) Package CVS request done -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227
--- Comment #11 from Kevin Kofler kevin.kof...@chello.at 2008-12-16 08:18:59
---
You also have to comment out this line:
Requires: xmms2-mac = %{version}-%{release}
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 --- Comment #12 from Kevin Kofler kevin.kof...@chello.at 2008-12-16 08:25:05 --- Oh, and I'm not sure we need the mac plugin at all: ffmpeg already has a decoder for Monkey's Audio, which is not based on the official non-Free mac, but on libdemac which is rewritten from scratch. On the other hand, that decoder only supports the current format and not the versions from old versions of Monkey's Audio. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 --- Comment #13 from Orcan Ogetbil orcanba...@yahoo.com 2008-12-16 08:35:04 --- Good catch. Thanks. SPEC: http://6mata.com:8014/review/xmms2-freeworld.spec SRPM: http://6mata.com:8014/review/xmms2-freeworld-0.5-5.fc10.src.rpm I am aware of what you said. It is the only decoder that supports old APE files. But I am not sure either. Let's hear what the reviewer will say. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 --- Comment #5 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2008-12-12 21:52:44 --- (In reply to comment #4) (In reply to comment #3) (In reply to comment #2) [...] You should wait for the libraw1394-devel and others pkg-config requirement pulled from ffmpeg-devel. Why do you say ffmpeg-devel needs to Require: libraw1394-devel? I told you that since you have Requires.private libraw1394 in libavcodec.pc, the libraw1394.pc needs to be pulled. If not, the pkg-config libavcodec detection will fail. At this time, they are not added automatically by rpm. Actually, the problem was in FFmpeg's .pc files. This is fixed in ffmpeg-0.4.9-0.54.20081202. The compilation problem is fixed with the attached patch. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 --- Comment #7 from Orcan Ogetbil orcanba...@yahoo.com 2008-12-13 01:33:57 --- Update: SPEC: http://6mata.com:8014/review/xmms2-freeworld.spec SRPM: http://6mata.com:8014/review/xmms2-freeworld-0.5-3.fc10.src.rpm Changelog 0.5-3: - Add meta package - Include more upstream patches for avcodec plugin compilation and fixes - Drop BR's and patches that are irrelevant for compiling freeworld plugins I had to include 6 more upstream patches in order to apply the latest one that fixes avcodec plugin compilation issues with the latest ffmpeg. Actually I included all the avcodec patches since the release of the 0.5 version now. Should I combine all these avcodec patches into one big patch or is this ok? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 --- Comment #1 from Orcan Ogetbil [EMAIL PROTECTED] 2008-12-11 09:39:03 --- Update: Fedora package xmms2 passed the review. SPEC: http://6mata.com:8014/review/xmms2-freeworld.spec SRPM: http://6mata.com:8014/review/xmms2-freeworld-0.5-2.fc10.src.rpm The xmms2-freeworld package is updated in parallel with the changes asked by the Fedora review for the xmms2 package. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 NicolasChauvet kwiz...@gmail.com changed: What|Removed |Added CC||kwiz...@gmail.com Blocks|2 |3 AssignedTo|rpmfusion-package- |kwiz...@gmail.com |rev...@rpmfusion.org| -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 227] Review request: xmms2-freeworld - Plugins for XMMS2 that cannot be included in Fedora
http://bugzilla.rpmfusion.org/show_bug.cgi?id=227 NicolasChauvet kwiz...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from NicolasChauvet kwiz...@gmail.com 2008-12-11 18:48:30 --- compilation failed with the new ffmpeg in rpmfusion rawhide for F-11: --- /usr/lib/ccache/gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -fPIC -DPIC -D_REENTRANT -D_REENTRANT -Idefault/src/include -I../src/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I. -Idefault -I.. ../src/plugins/daap/daap_mdns_avahi.c -c -o default/src/plugins/daap/daap_mdns_avahi.os [134/328] * cc : src/plugins/avcodec/avcodec.c - _build_/default/src/plugins/avcodec/avcodec.os ../src/plugins/avcodec/avcodec.c: In function 'xmms_avcodec_init': ../src/plugins/avcodec/avcodec.c:174: error: 'AVCodecContext' has no member named 'bits_per_sample' ../src/plugins/avcodec/avcodec.c: In function 'xmms_avcodec_read': ../src/plugins/avcodec/avcodec.c:251: warning: implicit declaration of function 'avcodec_decode_audio' /usr/lib/ccache/gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -fPIC -DPIC -Idefault/src/include -I../src/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/ffmpeg -I. -Idefault -I.. ../src/plugins/avcodec/avcodec.c -c -o default/src/plugins/avcodec/avcodec.os ERROR: == Runner == task failed! (return code 129 and task id 167) ERROR: == Task == -- task details begin -- action: cc idx:167 source: [/builddir/build/BUILD/xmms2-0.5DrLecter/src/plugins/avcodec/avcodec.c] target: [b:/builddir/build/BUILD/xmms2-0.5DrLecter/src/plugins/avcodec/avcodec.os] -- task details end -- [135/328] * cc : src/plugins/cdda/cdda.c - _build_/default/src/plugins/cdda/cdda.os /usr/lib/ccache/gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -fPIC -DPIC -Idefault/src/include -I../src/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I. -Idefault -I.. ../src/plugins/cdda/cdda.c -c -o default/src/plugins/cdda/cdda.os Compilation failed (error raised in module Build) -- You should wait for the libraw1394-devel and others pkg-config requirement pulled from ffmpeg-devel. * Is it possible/relevant to have a xmms2-freeworld meta-package or should we handle that with group using comps ? * Maybe someone can think about the mac module (will be nonfree, if allowed to get redistributed). * There is usually no need to rebuild all the modules. That doesn't matter for now, but it would be easier in case of a nosrc.rpm for the mac nonfree plugin (again, if anyone cares). You can at least start to lower the module/dependencies requested to only BuildRequires the common ones along with the freeworld ones. Package built fine on rpmbuild F-9 x86_64. Doing runtime testing now... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
