[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
  namespace||free
 Resolution|--- |EXPIRED

--- Comment #5 from Nicolas Chauvet  ---
Is this review still relevant ? Please re-open if so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

Antonio anto.tra...@gmail.com changed:

   What|Removed |Added

 CC|anto.tra...@gmail.com   |
 Blocks|3   |2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

--- Comment #1 from Antonio anto.tra...@gmail.com 2013-04-13 19:28:28 CEST ---
Created attachment 1075
  -- https://bugzilla.rpmfusion.org/attachment.cgi?id=1075
Autotools files patches

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

Antonio anto.tra...@gmail.com changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com

--- Comment #2 from Antonio anto.tra...@gmail.com 2013-04-13 19:29:13 CEST ---
Hi Gianluca.

- Your package needs aclocal-1.11 and automake-1.11; currently they are missing
in Fedora. It should need an 'autoreconf' task before compiling but should be
better if you do a local re-configuration and include all changes as patches.

I send you a compressed archive with patches; please control them, too. 

- This package provides just a set of profiles, it is a 'noarch' package.
Add a BuildArch tag.

- 'rm -rf $RPM_BUILD_ROOT' line is deprecated
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

--- Comment #3 from Antonio anto.tra...@gmail.com 2013-04-14 00:47:19 CEST ---
To use these profiles, OGMRip needs FAAC libraries.
'Requires:faac' is necessary.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

Antonio anto.tra...@gmail.com changed:

   What|Removed |Added

 Blocks|2   |3

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

--- Comment #4 from Antonio anto.tra...@gmail.com 2013-04-14 01:27:01 CEST ---
(In reply to comment #1)
 Created attachment 1075 [details]
 Autotools files patches

These patches don't consider the patch already included in your package
(ogmrip-profiles-0.3-gettext.patch). Using this patch (that changes
'configure.in' file in top-level directory), it seems affect the compilation:

...
CDPATH=${ZSH_VERSION+.}:  cd .  /bin/sh
/home/sagitter/rpmbuild/BUILD/ogmrip-profiles-0.3/missing --run aclocal-1.12 
CDPATH=${ZSH_VERSION+.}:  cd .  /bin/sh
/home/sagitter/rpmbuild/BUILD/ogmrip-profiles-0.3/missing --run autoconf
 cd .  /bin/sh /home/sagitter/rpmbuild/BUILD/ogmrip-profiles-0.3/missing
--run automake-1.12 --gnu
...

In this way, it seems me that starts again 'aclocal/automake/autoconf' tools.

I obtained a cleaner result with these steps and, for everyone, by creating all
patch files:

1) Executing 'aclocal' 
2) Executing 'automake'
3) Patching 'configure.in' file by 'ogmrip-profiles-0.3-gettext.patch'
4) Executing 'autoconf'

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2696] ogmrip-profiles - Collection of profiles for OGMRip

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2696

Gianluca Sforna gia...@gmail.com changed:

   What|Removed |Added

 Blocks||2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.