[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
https://bugzilla.rpmfusion.org/show_bug.cgi?id=289 Jeremy Newton alexjn...@hotmail.com changed: What|Removed |Added CC||alexjn...@hotmail.com Blocks|2 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com Blocks|3 |2 --- Comment #34 from Richard hobbes1...@gmail.com 2011-10-06 20:53:43 --- Moving this back to the review tracker. Maybe someone will pick it up. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||WONTFIX --- Comment #31 from Allisson Azevedo allis...@gmail.com 2009-01-13 23:20:33 --- Hi all, There is some problems with this package for inclusion on rpmfusion, and the upstream is probably dead. Thanks for all comments, i close this bug as wontfix. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #32 from Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl 2009-01-13 23:41:24 --- I'm sorry to hear you've retracted this package for review. I personally think this package is welcome for RPMFusion. We've uncovered some issues with the package and that's a good thing. That's what reviews are for. In this case, there just needs to be some discussion with GStreamer upstream to find out the best way to solve these issues (like influencing the plugin cache regeneration). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #30 from Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl 2009-01-11 14:45:52 --- I just found another bug in this package. When trying to open a wma9 file, I get this error: $ totem attachment.cgi\?id\=122237\action\=view wine/module: Win32 LoadLibrary failed to load: wmadmod.dll, /usr/lib/win32/wmadmod.dll, /usr/local/lib/win32/wmadmod.dll Failed creating an audio decoder: could not open DMO filter from DLL wmadmod.dll The wma9 file was found at http://bugzilla.gnome.org/show_bug.cgi?id=559924 It looks like there's still some place in pitfdll where the folders /usr/lib/win32 and /usr/local/lib/win32 are mentioned and the './configure --with-dlldir=/usr/lib/codecs' option isn't respected. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #25 from Gianluca Sforna gia...@gmail.com 2009-01-10 13:57:29 --- (In reply to comment #24) What one can do is to apply Andreas's suggestion (i.e. ship the free bits), own the directory were the codecs should land and - either download those codecs automatically (in %post) if possible or - include a fedora.readme containing the instructions on how to manually download the missing bits In the latter case (i.e. if user intervention is needed after installation) it would be nice to mention it in the package description, see for instance mailman spec file. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 alsadi als...@ojuba.org changed: What|Removed |Added CC||als...@ojuba.org --- Comment #26 from alsadi als...@ojuba.org 2009-01-10 17:37:21 --- If this plugin was installed while the win32 codecs weren't installed yet, you can force a gstreamer recheck by removing the directory ~/.gstreamer-0.10 : rm -rf ~/.gstreamer-0.10 should we put something like find /home -type d -name '.gstreamer-0.10' | xargs -r /bin/rm -rf in %post or in %triggerin BTW: we offer emulator with no ROMs and we don't tell the users where to get the ROMs, so I guess there is no problem in shipping this even if there is rpms for dlls -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #27 from Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl 2009-01-10 17:53:55 --- (In reply to comment #26) should we put something like find /home -type d -name '.gstreamer-0.10' | xargs -r /bin/rm -rf in %post or in %triggerin No, that doesn't solve the problem. The problem is that the w32codecs need to be installed before any gstreamer application is launched after the installation of gstreamer-pitfdll. If this isn't done, the w32codecs won't be detected and the user is forced to remove the ~/.gstreamer-0.10 directory before the w32codecs will be detected by gstreamer. The only situation where this command would give the right effect is in a w32codecs RPM package...but as we can't put it in RPMFusion it's a no-go.. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #28 from Gianluca Sforna gia...@gmail.com 2009-01-10 19:56:55 --- (In reply to comment #27) No, that doesn't solve the problem. The problem is that the w32codecs need to be installed before any gstreamer application is launched after the installation of gstreamer-pitfdll. If this isn't done, the w32codecs won't be detected and the user is forced to remove the ~/.gstreamer-0.10 directory before the w32codecs will be detected by gstreamer. Sounds like a bug. Or is that just me? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #14 from Conrad Meyer kon...@tylerc.org 2009-01-09 18:00:05 --- So? It still needs w32codecs -- just because we cannot provide it does not mean it is not a dependency for this package (to be at all useful). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #17 from Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl 2009-01-09 20:49:19 --- I just looked into autodownloader. Unfortunately this program is a non-root program, so it can't write files to /usr/lib/codecs. If we patch gstreamer-pitfdll so it also searches in the user's homedir for the w32codecs and integrate autodownloader in it, users will get to see the autodownloader dialog at the first time any GStreamer application (Totem e.g.) is started. This should be do-able, however it introduces some caveats: - If the user presses the 'cancel' button when autodownloader is run, the user needs to remove the ~/.gstreamer-0.10 directory before the gstreamer plugin cache can be updated - Autodownloader is a GUI program. If some non-graphical gstreamer application is started (when no graphical environment is available) things will mess up - The autodownloader dialog will even get shown when the user tries to play an 'open format' media file (like .ogg files) using a gstreamer-based application - It is possible that the autodownloader dialog will get shown directly after the user login (when a gstreamer based application gets started during the login) On second guess, I don't think autodownloader is a (user-friendly) solution to the problem were having here. Perhaps we can ask the upstream gstreamer devs whether it is possible to add some trick that will allow plugins to request a (forced) plugin cache regeneration? That way, gstreamer-pitfdll can automatically request a plugin cache regeneration whenever new/changed files are found in /usr/lib/codecs -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #19 from Andreas Thienemann andr...@bawue.net 2009-01-09 21:07:22 --- (In reply to comment #18) Having a Requires: dependency on the w32 codecs makes this package not installable on most systems. This is surely not what is intended. Isn't it? This package *needs* w32codec to do *anything*. If they don't have w32codec not being able to install it isn't a problem, as it wouldn't do anything anyway when installed. No, it isn't. The w32codecs are delivered as a tar.gz. Without building your own rpm, this dependency cannot be resolved. We're here to make software installation easier to our users not to ask them to jump through hoops. After all, httpd does need some html files to really be useful. Nevertheless, we allow people to install it even without a dependency on the meta-package website. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #20 from Conrad Meyer kon...@tylerc.org 2009-01-09 21:17:46 --- No, there is actually a w32codec package floating around various places. (Search for it on rpm.pbone.net.) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #21 from Conrad Meyer kon...@tylerc.org 2009-01-09 21:18:35 --- (Mine came from ATrpms, but it appears they no longer ship it.) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #23 from Conrad Meyer kon...@tylerc.org 2009-01-09 21:42:32 --- As opposed to not explicitly listing the dependency at all and expecting users to somehow provide the pieces? How is that better? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #24 from Manuel Wolfshant wo...@fedoraproject.org 2009-01-10 03:03:06 --- (In reply to comment #23) As opposed to not explicitly listing the dependency at all and expecting users to somehow provide the pieces? How is that better? Adding a Requires for a package which neither fedora nor rpmfusion provides is a no-no. IIRC it's not even permitted. You cannot ever be sure that a 3rd party repo will fill the gap. What one can do is to apply Andreas's suggestion (i.e. ship the free bits), own the directory were the codecs should land and - either download those codecs automatically (in %post) if possible or - include a fedora.readme containing the instructions on how to manually download the missing bits -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #10 from Allisson Azevedo allis...@gmail.com 2009-01-05 14:28:08 --- spec: http://allisson.fedorapeople.org/packages/gstreamer-pitfdll/gstreamer-pitfdll.spec srpm: http://allisson.fedorapeople.org/packages/gstreamer-pitfdll/gstreamer-pitfdll-0.9.1.1-3.20080215cvs.fc10.src.rpm Changelog: * Mon Jan 5 2009 Allisson Azevedo allis...@gmail.com 0.9.1.1-3.20080215cvs - Move information about w32codecs for README.Fedora. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #8 from Allisson Azevedo allis...@gmail.com 2009-01-05 12:51:10 --- Update package: spec: http://allisson.fedorapeople.org/packages/gstreamer-pitfdll/gstreamer-pitfdll.spec srpm: http://allisson.fedorapeople.org/packages/gstreamer-pitfdll/gstreamer-pitfdll-0.9.1.1-2.20080215cvs.fc10.src.rpm Changelog: * Mon Jan 5 2009 Allisson Azevedo allis...@gmail.com 0.9.1.1-2.20080215cvs - Added information about w32codecs in description - Added ExclusiveArch for i386 - Added LDFLAGS rules -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #7 from Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl 2009-01-04 15:05:31 --- Here's the review: Please add an extra comment to the description mentioning this plugin requires external win32 codecs which can't be redistributed in RPMFusion due to legal reasons and that these codecs need to be saved in the directory /usr/lib/codecs --- While testing, I've found out you need to install the win32 codecs BEFORE installing this plugin. If you don't, the win32 codecs won't be detected by gstreamer: $ gst-inspect pitfdll Plugin Details: Name: pitfdll Description: DLL-loader elements Filename: /usr/lib/gstreamer-0.10/libpitfdll.so Version: 0.9.1.1 License: GPL Source module:pitfdll Binary package: PitfDLL Origin URL: http://ronald.bitfreak.net/pitfdll/ 0 features: If this plugin was installed while the win32 codecs weren't installed yet, you can force a gstreamer recheck by removing the directory ~/.gstreamer-0.10 : $ rm -rf ~/.gstreamer-0.10 $ gst-inspect-0.10 pitfdll Plugin Details: Name: pitfdll Description: DLL-loader elements Filename: /usr/lib/gstreamer-0.10/libpitfdll.so Version: 0.9.1.1 License: GPL Source module:pitfdll Binary package: PitfDLL Origin URL: http://ronald.bitfreak.net/pitfdll/ qtadec_bin: quicktime binary audio decoder dmodec_wmspdmodv1: DMO wmspdmod decoder version 1 dmodec_wmadmodv3: DMO wmadmod decoder version 3 dmodec_wmadmodv2: DMO wmadmod decoder version 2 dmodec_wmadmodv1: DMO wmadmod decoder version 1 dmodec_wmvdmodv3: DMO wmvdmod decoder version 3 dmodec_wmvdmodv2: DMO wmvdmod decoder version 2 dmodec_wmvdmodv1: DMO wmvdmod decoder version 1 dmodec_wmv9dmodv3: DMO wmv9dmod decoder version 3 dshowdec_ir41_32v4: DS ir41_32 decoder version 4 dshowdec_ir50_32v5: DS ir50_32 decoder version 5 11 features: +-- 11 elements Perhaps it is a good idea to add this information to the description to avoid future (false) bug reports. --- During the %install phase, the directory /usr/lib/codecs is generated, but it isn't part of the %files list. I don't know if this directory should really be owned by this package as it is also used by MPlayer and Xine. Can somebody on the mailing list clarify whether two or more packages can own a directory? --- This package only works on the i386 architecture (it doesn't even compile on x86_64). Please add an 'ExclusiveArch: i386' to the .spec file --- rpmlint has indicated that the plugin has an executable stack. This causes issues with SELinux. To fix this, add the line ... export LDFLAGS=-Wl,-znoexecstack ... to the .spec file, right above the %configure line. I haven't tested if this causes any breakage as I don't have any files at hand which can only be decoded by the win32 codecs. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289
Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl changed:
What|Removed |Added
CC||erik-
||rpmfus...@vanpienbroek.nl
Status|NEW |ASSIGNED
--- Comment #1 from Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl
2009-01-01 19:38:44 ---
Some initial comments:
- Does this package still work with GStreamer 0.10 ? The website only mentions
support for GStreamer 0.8 and the CVS doesn't seem to have any activitity in
the last 10 months
- The rpmlint warning about the executable stack indicates this package will
conflict with SELinux. This is really something that should be looked into
- IIRC, this package only works on the i386 architecture. Thus the spec should
require an ExclusiveArch: i386
- This package is only useful in combination with win32 codecs. Are you (or
someone else) willing to package/maintain this for RPMFusion (non-free) ?
- Why do you perform an 'mkdir -p $RPM_BUILD_ROOT%{_libdir}/codecs/' in the
%install phase? It doesn't seem to have any purpose right now
Full review coming soon
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 Erik van Pienbroek erik-rpmfus...@vanpienbroek.nl changed: What|Removed |Added Blocks||3 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289
--- Comment #2 from Andrea Musuruane musur...@gmail.com 2009-01-01 20:17:25
---
(In reply to comment #1)
- This package is only useful in combination with win32 codecs. Are you (or
someone else) willing to package/maintain this for RPMFusion (non-free) ?
Why should the submitter not be willing to package/maintain this if he put this
for review here?
- Why do you perform an 'mkdir -p $RPM_BUILD_ROOT%{_libdir}/codecs/' in the
%install phase? It doesn't seem to have any purpose right now
I think that that directory is the one where win32 codecs will be placed by
users. Thus this package will own that directory.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #4 from Kevin Kofler kevin.kof...@chello.at 2009-01-01 22:21:41 --- The w32codecs aren't legally distributable. I know some sites do it anyway, but that doesn't mean it's legal. ;-) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=289 --- Comment #6 from Kevin Kofler kevin.kof...@chello.at 2009-01-02 01:41:21 --- There's no license (at least not from the actual copyright holders) which would allow distributing them. The default in copyright law is that distribution is not allowed. A license is needed to allow it. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
