[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

Simone Caronni negativ...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||MOVED

--- Comment #11 from Simone Caronni negativ...@gmail.com 2013-11-21 11:58:44 
CET ---
Closed, merged here:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3034

along with the Skype wrapper for latency, etc.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

Simone Caronni negativ...@gmail.com changed:

   What|Removed |Added

 CC||leamas.a...@gmail.com

--- Comment #10 from Simone Caronni negativ...@gmail.com 2013-11-06 12:02:24 
CET ---
Updated with some tweaks. Just for reference as there is the lpf-skype review
in Fedora running now [1] and the package could be probably moved to RPMFusion
[2] after fpc decision. 

Spec URL: http://slaanesh.fedorapeople.org/skype.spec
SRPM URL: http://slaanesh.fedorapeople.org/skype-4.2.0.11-6.fc19.src.rpm

- Add webkitgtk as requirement; it's required by the welcome screen and not
  pulled in automatically.
- Convert the profile to wrapper for Fedora 20.
- Force PulseAudio latency in Fedora 20+ through an alias to the skype command
  in /etc/profile.d/.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1023714
[2] https://fedorahosted.org/fpc/ticket/362

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

--- Comment #9 from Simone Caronni negativ...@gmail.com 2013-10-04 09:19:50 
CEST ---
(In reply to comment #8)
 Hi, Simone Caronni good to see you around :)

Nice to see you too :)
Lots of friends here! :D

 you may get so ideas from russianfedora
 
 https://github.com/RussianFedora/skype
 http://koji.russianfedora.ru/koji/packageinfo?packageID=97

I've looked at the Russian Fedora package and I think it's horrible. There are
a few things that I really don't like:

- They use different sources for different distribution
- In the case of Fedora they download the rpm and unpack it (why not use the
tarball already?)
- They do a lot of mangling on desktop files etc. which is really not needed,
as rpmlint does not complain
- They create a fake libtiff link, and end up packaging the %_docdir with the
version in it; which breaks the unversioned docdir in Fedora 20:

%doc %{_docdir}/%{name}-%{version}
%{_bindir}/%{name}
%{_bindir}/%{name}-bin
%{_libdir}/libtiff.so.4

The main problem though is that this does not solve the redistribution
licensing issue..

The official package is not in bad shape at all and a wrapper is needed only
for the environment variable as in comment #4. So any idea on the matter? Close
the review at all? Ship the wrapper only for the variable and the automatic
download of the official rpm?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

Simone Caronni negativ...@gmail.com changed:

   What|Removed |Added

 Blocks||2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

--- Comment #1 from Simone Caronni negativ...@gmail.com 2013-10-03 13:13:38 
CEST ---
A note on the package: builds only for i686 but installs perfectly fine on
x86_64 systems by just using yum; dependencies are downloaded correctly.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

Mohamed El Morabity pikachu.2...@gmail.com changed:

   What|Removed |Added

 CC||pikachu.2...@gmail.com

--- Comment #2 from Mohamed El Morabity pikachu.2...@gmail.com 2013-10-03 
13:45:30 CEST ---
The redistribution license of Skype seems very restrictive:
   http://www.skype.com/en/legal/tou/#4
Unless you're explicitely allowed to redistribute Skype through RPM Fusion, I'm
not sure Skype could be repackaged and delivered through third-party means.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

--- Comment #3 from Simone Caronni negativ...@gmail.com 2013-10-03 14:06:04 
CEST ---
Ouch. Since in the wishlist there's a separate section for things that cannot
be redistributed I thought the one in the upper section were check already for
redistribution.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

--- Comment #5 from Simone Caronni negativ...@gmail.com 2013-10-03 15:37:35 
CEST ---
(In reply to comment #4)
 (In reply to comment #3)
 Since installing skype is a bit of a pain, you could consider doing a package
 which will download and install it for the user,
 
 You could use auto-downloader for the download. And then pkexec to do the
 rpm -i of the rpm from skype.
 
 This way people could still just do yum install skype ...
 
 See the usbview package of an example of using pxexec, and see the vavoom
 package for an example of using autodl.

Thanks, I will try; but I'm not sure Skype leaves the tarballs/packages in
place on the servers when a new version comes out and this would need to be
sorted out.

Is an example of using autodl with tarballs also available?

 You could then make this a package with the necessary extra requires (not sure
 if the requires of the skype rpm are complete), and make it ExclusiveArch i686
 and x86_64.

No, package requirements are missing entirely in Skype's official package;
there are no dependencies at all.

 You should then also drop in a /etc/profile.d file with the following in 
 there:
 
 alias skype='PULSE_LATENCY_MSEC=30 skype'

 Otherwise audio won't work in F20+, the latter alone is worth doing a wrapper
 package like this.

Thanks for the hint, I will do. Does it make any harm on lower Fedora or RHEL
distributions?

I was also planning to submit the purple-skype plugin after the Skype review;
do you think that could use that as the main wrapper package? Spec file and
source rpm here:

Spec URL: http://slaanesh.fedorapeople.org/purple-skype.spec

The x86_64 build runs fine with an installed i686 package.

I will update the Review Request when I will have something more to share;
thanks everybody for inputs.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

--- Comment #7 from Simone Caronni negativ...@gmail.com 2013-10-03 16:06:28 
CEST ---
...and guess what: recently (don't know when) skype recreated the rpm package
with all dependencies in place, I can install it on my systems without
dependency issues. Last time I've looked at it; it did not have any dependency;
now it has and even the prelink configuration files are marked as config:

$ rpm -qp --requires skype-4.2.0.11-fedora.i586.rpm 
/bin/sh
/bin/sh
alsa-lib = 1.0.23
config(skype) = 4.2.0.11-fc16
libQtCore.so.4
libQtDBus.so.4
libQtGui.so.4
libQtNetwork.so.4
libQtWebKit.so.4
libQtXml.so.4
libX11.so.6
libXScrnSaver
libXext.so.6
libXss.so.1
libXv
libXv.so.1
libasound.so.2
libasound.so.2(ALSA_0.9)
libasound.so.2(ALSA_0.9.0rc4)
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4)
libc.so.6(GLIBC_2.7)
libdl.so.2
libdl.so.2(GLIBC_2.0)
libdl.so.2(GLIBC_2.1)
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgcc_s.so.1(GLIBC_2.0)
libm.so.6
libm.so.6(GLIBC_2.0)
libm.so.6(GLIBC_2.1)
libpng
libpthread.so.0
libpthread.so.0(GLIBC_2.0)
libpthread.so.0(GLIBC_2.1)
libpthread.so.0(GLIBC_2.2)
libpthread.so.0(GLIBC_2.3.2)
librt.so.1
librt.so.1(GLIBC_2.2)
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.11)
libstdc++.so.6(GLIBCXX_3.4.15)
libstdc++.so.6(GLIBCXX_3.4.9)
qt = 4.6
qtwebkit
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rtld(GNU_HASH)

$ rpm -qplc skype-4.2.0.11-fedora.i586.rpm
/etc/dbus-1/system.d/skype.conf
/etc/prelink.conf.d/skype.conf

It's missing only the %post scriptlets for the icon cache.

The only difference from the dynamic non-rpm version it's that it does not
contain the avatars pngs.

Now I'm asking myself why people keep telling me that installing skype is hard.
The only thing that would need to be put in the wrapper package is the alias
command (alias skype='PULSE_LATENCY_MSEC=30 skype')... is a package really
needed? Probably this ticket can be closed down.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2978] Review request: skype - Skype Messaging and Telephony Client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

Sérgio Basto ser...@serjux.com changed:

   What|Removed |Added

 CC||ser...@serjux.com

--- Comment #8 from Sérgio Basto ser...@serjux.com 2013-10-03 21:35:20 CEST 
---
Hi, Simone Caronni good to see you around :)  
you may get so ideas from russianfedora

https://github.com/RussianFedora/skype 

http://koji.russianfedora.ru/koji/packageinfo?packageID=97

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.