[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

Xavier Bachelot  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||DUPLICATE

--- Comment #11 from Xavier Bachelot  2016-08-11 13:50:04 
CEST ---
Another review for tvheadend has been submitted and accepted, so it is
resolved. However, I'm pretty sure the maintainer wouldn't be against having
some help, so feel free to request to co-maintain.

*** This bug has been marked as a duplicate of bug 4159 ***

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

pe...@perex.cz changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #10 from pe...@perex.cz 2016-08-11 12:53:12 CEST ---
It's not resolved. I'll give another shot when my time permits.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

Mohamed El Morabity  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||pikachu.2...@gmail.com
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

Tomas Smetana t.smet...@gmail.com changed:

   What|Removed |Added

 CC||t.smet...@gmail.com

--- Comment #9 from Tomas Smetana t.smet...@gmail.com 2015-08-20 21:11:29 
CEST ---
Hello.

This seems to be stalled... Which is a pity. It would be great to have
tvheadend easily available in Fedora. (I'm packaging it for myself, which is
how I got here...)

I've taken a look at the spec file and have two suggestions:

* Don't create anything in /home. The standard place for service homes is
/var/lib (compare to e.g., transmission or pulseaudio), so
%{_sharedstatedir}/tvheadend should be the correct place: this requires a patch
for the rpm/tvheadend.sysconfig file too.

* The manual page is still not being installed even though it's present in the
sources:

mkdir -p -m755 %{buildroot}%{_mandir}/man1
install -p -m 644 man/tvheadend.1 %{buildroot}%{_mandir}/man1

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

--- Comment #8 from pe...@perex.cz 2015-05-29 13:39:08 CEST ---
http://www.filebin.ca/23OKDPIhGEPO/tvheadend.spec
http://www.filebin.ca/23OK2TmsgCIo/tvheadend-4.0.3-1.fc21.src.rpm

Changes:

Fixes for issues described in comment#3 .

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

--- Comment #3 from MartinKG mgans...@alice.de 2015-05-28 13:10:20 CEST ---
1. please deactivate bundled software and use system wide software packages
ffmpeg, avahi and uriparser
 - change your build section
 - Add smp_mflags to make
 - remove arm if condition

%build
echo %{version}-%{release}  %{_builddir}/%{buildsubdir}/rpm/version
%configure --disable-lockowner --disable-bundle --disable-libffmpeg_static
make %{?_smp_mflags}


2. change the BuildRequieres dependencies to:
 - change  systemd-units = 1 to systemd-units

BuildRequires:  avahi-devel
BuildRequires:  avahi-libs
BuildRequires:  dbus-devel
BuildRequires:  ffmpeg-devel
BuildRequires:  git wget python
BuildRequires:  openssl-devel
BuildRequires:  systemd-units
BuildRequires:  uriparser-devel
Requires:   systemd-units

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

pe...@perex.cz changed:

   What|Removed |Added

   Attachment #1438|0   |1
is obsolete||

--- Comment #4 from pe...@perex.cz 2015-05-28 15:10:00 CEST ---
Created attachment 1440
  -- https://bugzilla.rpmfusion.org/attachment.cgi?id=1440
Updated spec file for review...

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

pe...@perex.cz changed:

   What|Removed |Added

   Attachment #1440|0   |1
is obsolete||

--- Comment #5 from pe...@perex.cz 2015-05-28 15:12:07 CEST ---
Created attachment 1441
  -- https://bugzilla.rpmfusion.org/attachment.cgi?id=1441
Updated spec file for review (v4.0.3)

Thanks again for review.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

--- Comment #7 from MartinKG mgans...@alice.de 2015-05-28 15:55:04 CEST ---
for reviewing your package it would be better to post a download link in this
format:

Spec URL: link to the .spec file
SRPM URL: link to the .srpm file

and of course a changelog:

%changelog
* Sat Dec 06 2014 Martin Gansser marti...@fedoraproject.org - 3.4.8-1
- rebuild for new version

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

--- Comment #6 from MartinKG mgans...@alice.de 2015-05-28 15:53:29 CEST ---
for reviewing your package it would be better to post a download link in this
format:

Spec URL: link to the .spec file
SRPM URL: link to the .srpm file

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

--- Comment #2 from pe...@perex.cz 2015-05-27 19:15:32 CEST ---
Thanks. New version:
http://www.filebin.ca/23BvCCjBWYxY/tvheadend-4.0.3-1.fc21.src.rpm

These rpmlint errors remain:

tvheadend.x86_64: W: no-documentation
tvheadend.x86_64: W: non-conffile-in-etc /etc/sysconfig/tvheadend
tvheadend.x86_64: W: no-manual-page-for-binary tvheadend
tvheadend.x86_64: W: dangerous-command-in-%pre chown

The sysconfig/chown errors are not errors in my eyes, but I will follow any
direction.

The documentation is missing - I'll write few notes for the initial connection
to the integrated HTTP server, too.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3667] Review request: tvheadend - a TV streaming server and DVR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3667

--- Comment #1 from MartinKG mgans...@alice.de 2015-05-26 11:04:33 CEST ---
this is not a full review:

Rpmlint (installed packages)

tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/fftable.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/stream.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/FFdecsa.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/FFdecsa.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/parallel_064_mmx.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/parallel_128_sse2.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.2/src/descrambler/ffdecsa/parallel_032_int.h

- please report the fsf message upstream.

tvheadend.x86_64: E: explicit-lib-dependency avahi-libs
tvheadend.x86_64: E: explicit-lib-dependency dbus-libs
tvheadend.x86_64: E: explicit-lib-dependency openssl-libs

- rpmlint -I explicit-lib-dependency
explicit-lib-dependency:
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

So, you have to delete the Requires tag avahi-libs, dbus-libs and openssl-libs
in your spec file.

tvheadend.x86_64: W: name-repeated-in-summary C Tvheadend

- please change the summary from
Summary:Tvheadend - a TV streaming server and DVR
  to:
Summary:a TV streaming server and DVR

- please remove 
tvheadend.x86_64: W: spelling-error %description -l en_US backend - backed,
back end, back-end
tvheadend.x86_64: W: incoherent-version-in-changelog v4.0.2 ['4.0.2-1',
'4.0.2-1']

- please correct version in changelog from v4.0.2 to 4.0.2
  and change the Release tag to:
  Release:1%{?dist}

tvheadend.x86_64: W: no-documentation
tvheadend.x86_64: W: non-conffile-in-etc /etc/sysconfig/tvheadend
tvheadend.x86_64: W: no-manual-page-for-binary tvheadend
tvheadend.x86_64: W: dangerous-command-in-%pre chown
2 packages and 0 specfiles checked; 10 errors, 7 warnings.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.