[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|33  |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=33
[Bug 33] Tracker: Packages awaitting CVS Administration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #28 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Nicolas Chauvet from comment #27)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #26)
> > (In reply to Dominik 'Rathann' Mierzejewski from comment #25)
> > > It does seem to work on rawhide with FFmpeg 3.2.4. So I'm guessing this 
> > > is a
> > > bug in FFmpeg. I'll retry with FFmpeg 3.2.x on F25 later.
> > 
> > I've just updated FFmpeg locally to 3.2.4 and HandBrake works fine. I can
> > also see that there are only some new functions added in 3.2.4 when compared
> > to 3.1.7, so the best option for F25 might be to update FFmpeg to 3.2.x.
> 
> If yoou don't test on ffmpeg-3.1.x that is in f25 I'm going to discard the
> update on Handbrake build on f25

Both Richard and I tested it. It's broken with FFmpeg 3.1.x and HandBrake
upstream said it's not a supported combination (they only support libav-12).
You can drop the F25 build for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #27 from Nicolas Chauvet  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #26)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #25)
> > It does seem to work on rawhide with FFmpeg 3.2.4. So I'm guessing this is a
> > bug in FFmpeg. I'll retry with FFmpeg 3.2.x on F25 later.
> 
> I've just updated FFmpeg locally to 3.2.4 and HandBrake works fine. I can
> also see that there are only some new functions added in 3.2.4 when compared
> to 3.1.7, so the best option for F25 might be to update FFmpeg to 3.2.x.

If yoou don't test on ffmpeg-3.1.x that is in f25 I'm going to discard the
update on Handbrake build on f25

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #26 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #25)
> It does seem to work on rawhide with FFmpeg 3.2.4. So I'm guessing this is a
> bug in FFmpeg. I'll retry with FFmpeg 3.2.x on F25 later.

I've just updated FFmpeg locally to 3.2.4 and HandBrake works fine. I can also
see that there are only some new functions added in 3.2.4 when compared to
3.1.7, so the best option for F25 might be to update FFmpeg to 3.2.x.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #25 from Dominik 'Rathann' Mierzejewski  ---
It does seem to work on rawhide with FFmpeg 3.2.4. So I'm guessing this is a
bug in FFmpeg. I'll retry with FFmpeg 3.2.x on F25 later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #24 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Richard from comment #22)
> I'm not sure what the problem is but I had a need an built a package from
> your last link but when I started an encode nothing happened. It would
> create a file but would never progress. Didn't seem to matter what profile I
> chose.

Actually, it does finish eventually but the resulting file contains no video
frames. Also, if you have the decomb filter, it segfaults pretty quickly. I'm
filing an issue with upstream now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #23 from Richard  ---
I just rebuilt my version of the package which uses all bundled versions of
libraries and encoding works...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #22 from Richard  ---
I'm not sure what the problem is but I had a need an built a package from your
last link but when I started an encode nothing happened. It would create a file
but would never progress. Didn't seem to matter what profile I chose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #21 from Dominik 'Rathann' Mierzejewski  ---
I opened new package requests (for master and f25) in pkgdb, but syncing from
bugzilla doesn't work. I get an error about invalid title (no - present).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Depends on||33

--- Comment #20 from Dominik 'Rathann' Mierzejewski  ---
Package CVS request
==
Package Name: HandBrake
Short Description: An open-source multiplatform video transcoder
Owners: rathann
Branches: f26 f25 f24
InitialCC: 
--
License tag: free


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=33
[Bug 33] Tracker: Packages awaitting CVS Administration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Xavier Bachelot  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review+

--- Comment #19 from Xavier Bachelot  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #17)
> (In reply to Xavier Bachelot from comment #16)
> > Created attachment 1750 [details]
> > Version bump, Recommends tweak, debuginfo fix
> > 
> > The interesting part of this patch is the -debuginfo fix, the remaining is
> > trivial.
> 
> That was brilliant! I blame the HB's custom configure script written in
> python.
> 
It took my quite some time and several attempts to figure it out. I was really
puzzled at this issue and the solution came from the specfile included in
HandBrake.

> We can also drop the clip_id patch after libbluray is updated to 1.0.0.
> 
I think it will need to be conditionally applied to %fedora >= 26, as I'll keep
libbluray 0.9.3 for %fedora <= 25 and %rhel.

> Regarding BuildRequires: gcc make, I don't think I should drop them. The
> fedora-review recommendation is out of date. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 .
> 
Yes, agreed. It doesn't hurt anyway and seems more future proof.

> The link to https://fedorahosted.org/FedoraReview/wiki/AutoTools doesn't
> exist anymore, so I'm not sure what the recommendation is.
> 
Probably the best to do is just file a bug upstream.

> Anyway, here's an updated RPM with your patch applied.
> 
> Spec URL: https://www.greysector.net/~rathann/review/HandBrake/HandBrake.spec
> SRPM URL:
> https://www.greysector.net/~rathann/review/HandBrake/HandBrake-1.0.3-1.fc27.
> src.rpm

Thanks, I will take another look this evening but consider the package
APPROVED.
Sorry it took me so long to do the review.

And also, hopefully 1.0.3 helps with Simone's subtitle issue, but this is
upstream's job to fix it, and it should not hold us from importing the package
(but given the writing on downstream distribution of HandBrake on their
website, I don't expect much from them... What a pity...).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Richard  changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com

--- Comment #18 from Richard  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #17)
> 
> Regarding BuildRequires: gcc make, I don't think I should drop them. The
> fedora-review recommendation is out of date. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 .

I've started putting gcc and/or gcc-c++ in my packages but I don't think "make"
is likely to be dropped from the standard buildroot anytime soon. 

Thanks for working on this! I was building it on my own previously.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #17 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Xavier Bachelot from comment #16)
> Created attachment 1750 [details]
> Version bump, Recommends tweak, debuginfo fix
> 
> The interesting part of this patch is the -debuginfo fix, the remaining is
> trivial.

That was brilliant! I blame the HB's custom configure script written in python.

We can also drop the clip_id patch after libbluray is updated to 1.0.0.

Regarding BuildRequires: gcc make, I don't think I should drop them. The
fedora-review recommendation is out of date. See
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 .

The link to https://fedorahosted.org/FedoraReview/wiki/AutoTools doesn't exist
anymore, so I'm not sure what the recommendation is.

Anyway, here's an updated RPM with your patch applied.

Spec URL: https://www.greysector.net/~rathann/review/HandBrake/HandBrake.spec
SRPM URL:
https://www.greysector.net/~rathann/review/HandBrake/HandBrake-1.0.3-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #16 from Xavier Bachelot  ---
Created attachment 1750
  --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1750=edit
Version bump, Recommends tweak, debuginfo fix

The interesting part of this patch is the -debuginfo fix, the remaining is
trivial.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #15 from Xavier Bachelot  ---
Created attachment 1749
  --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1749=edit
Full review

This is the edited review.txt generated with fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #14 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Xavier Bachelot from comment #13)
> A couple notes before a full review (fedora-review doesn't like me for
> whatever reason...)
> 
> - Version 1.0.3 available

Right.

> - HandBrake-debuginfo.x86_64: E: debuginfo-without-sources

That might be related to a bug in rpm that was fixed recently. I'll re-check if
it's gone in current rawhide.

> - Turn "Recommends: libdvdcss" into "%{?fedora:Recommends: libdvdcss}" to
> make it work for EL.
> - Same for "Recommends: gstreamer1-plugins-good"

Right.

> Also, the libbluray patch is in libbluray 1.0.0 which has just been
> released, but this release bumps the soname.

Yes, I double-checked that the patch is included. I'll drop the patch once the
new libbluray is in Fedora for the relevant branches.

PS. I'm back from winter vacations and working through the backlog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #13 from Xavier Bachelot  ---
A couple notes before a full review (fedora-review doesn't like me for whatever
reason...)

- Version 1.0.3 available
- HandBrake-debuginfo.x86_64: E: debuginfo-without-sources
- Turn "Recommends: libdvdcss" into "%{?fedora:Recommends: libdvdcss}" to make
it work for EL.
- Same for "Recommends: gstreamer1-plugins-good"

Also, the libbluray patch is in libbluray 1.0.0 which has just been released,
but this release bumps the soname.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #12 from Simone Caronni  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #11)
> I have one problem, though. The -debuginfo package is empty and I'm not sure
> why.

What do you mean by "empty"? Empty as in no files at all? I did a master branch
build (nothing changed so far from 1.0.2):

$ rpm -qpl HandBrake-debuginfo-1.0.2-2.20170123gitc4a14d3.fc25.x86_64.rpm
/usr/lib/debug
/usr/lib/debug/.build-id
/usr/lib/debug/.build-id/3e
/usr/lib/debug/.build-id/3e/7d4180cd77dda01dc90729708ff5ff34d93c60
/usr/lib/debug/.build-id/3e/7d4180cd77dda01dc90729708ff5ff34d93c60.debug
/usr/lib/debug/.build-id/68
/usr/lib/debug/.build-id/68/9f4ef2938ee06fb7a2fe273c6d22926649ca27
/usr/lib/debug/.build-id/68/9f4ef2938ee06fb7a2fe273c6d22926649ca27.debug
/usr/lib/debug/usr
/usr/lib/debug/usr/bin
/usr/lib/debug/usr/bin/HandBrakeCLI.debug
/usr/lib/debug/usr/bin/ghb.debug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #11 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://www.greysector.net/~rathann/review/HandBrake/HandBrake.spec
SRPM URL:
https://www.greysector.net/~rathann/review/HandBrake/HandBrake-1.0.2-1.fc25.src.rpm

- update to 1.0.2
- avoid unnecessary libva dependency

I have one problem, though. The -debuginfo package is empty and I'm not sure
why. I can see the following errors during build:
+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz
--dwz-low-mem-die-limit 1000 --dwz-max-die-limit 11000
/builddir/build/BUILD/HandBrake-1.0.2
extracting debug info from
/builddir/build/BUILDROOT/HandBrake-1.0.2-1.fc24.x86_64/usr/bin/ghb
readelf: Error: the dynamic segment offset + size exceeds the size of the file
extracting debug info from
/builddir/build/BUILDROOT/HandBrake-1.0.2-1.fc24.x86_64/usr/bin/HandBrakeCLI
readelf: Error: the dynamic segment offset + size exceeds the size of the file

Looks like https://bugzilla.redhat.com/show_bug.cgi?id=1412348 ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #10 from Simone Caronni  ---
--- test/module.defs2017-01-23 22:00:15.0 +0100
+++ test/module.defs2017-01-24 20:02:26.278972593 +0100
@@ -25,9 +25,7 @@

 ifeq (1,$(FEATURE.qsv))
 TEST.GCC.D += USE_QSV HAVE_THREADS=1
-ifeq ($(BUILD.system),linux)
-TEST.GCC.l += va va-drm
-endif
+TEST.GCC.l += va-drm
 endif

 ifeq (1,$(FEATURE.x265))

Patching out the check makes also HandBrake build with a system ffmpeg and
libmfx, but I don't have a way to test atm on an Intel GPU.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #9 from Simone Caronni  ---
Sorry for the delay, I've been busy. Unfortunately even with the latest commits
from the master branch or the 1.0.2 release, any UTF-8 subtitle is not
detected. All my Anime collection is pretty much off.

Looking at the libav/libmfx part.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #8 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://www.greysector.net/~rathann/review/HandBrake/HandBrake.spec
SRPM URL:
https://www.greysector.net/~rathann/review/HandBrake/HandBrake-1.0.1-1.fc25.src.rpm

Switch to stable release (1.0.1).
Restore support for building with bundled libav.

You can build from github snapshot if you comment out the %global tag macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #7 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Simone Caronni from comment #6)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #3)
> > - libva is required to build with QSV.
> 
> Are you sure for this? FFMpeg in RPMFusion is already built with mfx/QSV.

It seems to be referenced here unconditionally if QSV is enabled:

test/module.defs:
ifeq (1,$(FEATURE.qsv))
TEST.GCC.D += USE_QSV HAVE_THREADS=1
ifeq ($(BUILD.system),linux)
TEST.GCC.l += va va-drm
endif
endif

I don't see any option to disable it via configure command line and since it
doesn't hurt anything apart from a small additional build dependency, I put it
in. If you want, feel free to patch it out.

> > - Drop support for building with libav.
> 
> I will make a new test this evening, but my attempts to build with FFMpeg
> months ago showed that it was breaking all UTF-8 subtitles detection (they
> are simply not detected anymore), so it means most of the Asian titles
> (Anime, etc.) and most of the BluRays will not have any subtitle. Can you
> still leave the optional part in, just disabled by default?

Sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Simone Caronni  changed:

   What|Removed |Added

 CC||negativ...@gmail.com

--- Comment #6 from Simone Caronni  ---
(In reply to Xavier Bachelot from comment #2)
> fwiw, the libbluray patch has been sent upstream and afaiu is likely going
> to be included. It might take a while before it's shipped in a release
> though, I'll keep an eye for it...

@Xavier can't we just add it to a 0.9.3 build and remove it when the package
gets updated to 0.9.4? It's easier than trying to remember to remove the patch
in another package. I can push the build in Fedora, if you want.

https://git.videolan.org/?p=libbluray.git;a=commitdiff;h=da50ad6ee5ceef6e81a96af0f2affcfe961c9d9f

(In reply to Dominik 'Rathann' Mierzejewski from comment #3)
> - libva is required to build with QSV.

Are you sure for this? FFMpeg in RPMFusion is already built with mfx/QSV.

> - Drop support for building with libav.

I will make a new test this evening, but my attempts to build with FFMpeg
months ago showed that it was breaking all UTF-8 subtitles detection (they are
simply not detected anymore), so it means most of the Asian titles (Anime,
etc.) and most of the BluRays will not have any subtitle. Can you still leave
the optional part in, just disabled by default?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #5 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Nicolas Chauvet from comment #4)
> Is there any reason the package is case sensitive ?

Yes, it's called that way just about everywhere, including their website and
github repo. However, now that I went back and re-checked their website, I see
there's finally been a 1.0.x release, so I'll roll a package based on that.

> I find it rather hard to remember the exact case when using a dnf install.
> https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:
> NamingGuidelines#Case_Sensitivity
> 
> Can you at least add a virtual provide that is case insensitive ?

Sure thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #4 from Nicolas Chauvet  ---
Is there any reason the package is case sensitive ?
I find it rather hard to remember the exact case when using a dnf install.
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Case_Sensitivity

Can you at least add a virtual provide that is case insensitive ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://www.greysector.net/~rathann/review/HandBrake/HandBrake.spec
SRPM URL:
https://www.greysector.net/~rathann/review/HandBrake/HandBrake-1.0-34.20170119git40ec4eb.fc25.src.rpm

Rebased my changes on top of Simone's 1.0-32.20161129gitfac5e0e:

- Update to latest sources.
- Use make_build macro.
- Fix BRs and drop redundant ones.
- libva is required to build with QSV.
- Soft dependency on gstreamer1-plugins-good for live preview.
- Change hard dependency on libdvdcss to soft.
- libmfx is x86-only.
- Move -cli to the main package.
- Drop support for building with libav.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Xavier Bachelot  changed:

   What|Removed |Added

 CC||xav...@bachelot.org

--- Comment #2 from Xavier Bachelot  ---
fwiw, the libbluray patch has been sent upstream and afaiu is likely going to
be included. It might take a while before it's shipped in a release though,
I'll keep an eye for it...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #1 from Nicolas Chauvet  ---
Few comments:
- Does it really uses the bundled fdk-aac instead of the internal ffmpeg aac
encoder ?
# Use system libraries in place of bundled ones
for module in a52dec %{?_with_fdk:fdk-aac}
...
- We cannot rely on this currently (we might need to restart the discussion)
At least it should be dlopenable.
Requires:   libdvdcss%{_isa}

- What is the point to have -gui -tui separation without any main package ?
I would use handbrake (main) as the default (-gui) package and use -core or
keep -tui as a sub-package.
(even using a virtual provide for lower case handbrake compatibility if not
handled by dnf already).

- Using , %make_build, %make_install, missing BR gcc, gcc-c++

- Remove dependency that are in the default BR (m4, patch, Makefile, etc)

- No appdata ?

Thx for this submit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Blocks||2


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.