[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 qvint changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #23 from qvint --- Import and build of the package have been done successfully: http://koji.rpmfusion.org/koji/packageinfo?packageID=600 Thank you everyone involved. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 leigh scott changed: What|Removed |Added CC||leigh123li...@gmail.com Blocks|30 | Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 [Bug 30] Tracker : Sponsorship Request -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #22 from Akarshan Biswas --- (In reply to Nicolas Chauvet from comment #20) > The other point is that f29 is currently unmaintained for chromium-vaapi, > this isn't acceptable. That is because the dependencies which chromium depends on in fedora 29 are not maintained due to which builds are failing. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114
--- Comment #21 from qvint ---
(In reply to Nicolas Chauvet from comment #20)
> In others words make a new chromium-freeworld package with vaapi and
> "ungoogled" patches ?
ungoogled-chromium breaks a number of features of the vanilla Chromium, so I
wouldn't merge the patches into chromium-freeworld. Examples of broken
features:
1) All help links are broken, F1 opens https://support.9oo91e.qjz9zk.
2) Old user profile (~/.config/chromium) may cause ungoogled-chromium to crash.
3) Passwords and other things are not synced with the google account.
4) Spell checking doesn't work.
5) Browser extensions cannot be installed from the google webstore in a normal
way.
6) Browser extensions are not auto-updated.
7) Settings page contains toggles that have no effect ("Safe Browsing" will
never work in ungoogled-chromium).
8) GCM doesn't work. You can't receive push notifications from sites.
9) Google Cloud Print doesn't work.
So my opinion here is that we should give the users the freedom to choose which
Chromium they want to use. I choose using vanilla Chromium at work and
ungoogled-chromium at home.
> copr repo
Without proprietary codecs, the browser seems to be useless.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #20 from Nicolas Chauvet --- I have an issue to have two differents chromium browser in rpmfusion. Can we investigate to have theses patches merged together with vaapi ? What would be the downside ? In others words make a new chromium-freeworld package with vaapi and "ungoogled" patches ? The other point is that f29 is currently unmaintained for chromium-vaapi, this isn't acceptable. Unfortunately I fear that f29 been unmaintained is a side effect to have later release to use system library. I don't think it gives much good unfortunately. The chromium-libs-media-freeworld complementary package is currently also unmaintained. Anyone to volunteer to maintain it ? So for me having a copr repo is the way to go for now. Specially as it produce a huge load on the infra. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 Akarshan Biswas changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #19 from Akarshan Biswas --- Okay , Package approved! -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #18 from Akarshan Biswas --- (In reply to qvint from comment #17) > Updated to 77.0.3865.90. > > - spec: > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/ > chromium-browser-privacy.spec > - src.rpm: > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/ > chromium-browser-privacy-77.0.3865.90-1.fc31.src.rpm > - nosrc.rpm: > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/ > chromium-browser-privacy-77.0.3865.90-1.fc31.nosrc.rpm > > - binary rpm: > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/ > chromium-browser-privacy-77.0.3865.90-1.fc31.x86_64.rpm > - debuginfo: > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/ > chromium-browser-privacy-debuginfo-77.0.3865.90-1.fc31.x86_64.rpm > - debugsource: > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/ > chromium-browser-privacy-debugsource-77.0.3865.90-1.fc31.x86_64.rpm Since the spec file is totally a copy of chromium-vaapi, I'm going to approve this. If anyone has any doubts/points to make, feel free to do so. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #17 from qvint --- Updated to 77.0.3865.90. - spec: https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/chromium-browser-privacy.spec - src.rpm: https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/chromium-browser-privacy-77.0.3865.90-1.fc31.src.rpm - nosrc.rpm: https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/chromium-browser-privacy-77.0.3865.90-1.fc31.nosrc.rpm - binary rpm: https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/chromium-browser-privacy-77.0.3865.90-1.fc31.x86_64.rpm - debuginfo: https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/chromium-browser-privacy-debuginfo-77.0.3865.90-1.fc31.x86_64.rpm - debugsource: https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-25_1/chromium-browser-privacy-debugsource-77.0.3865.90-1.fc31.x86_64.rpm -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #16 from qvint --- > You need to start a fresh changelog for the chromium-browser-privacy. OK, I restarted the changelog: - https://raw.githubusercontent.com/qvint/ungoogled-chromium-fedora/88571efa5c3e11132aa74130cae2340535e6e625/chromium-browser-privacy.spec -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #15 from Nicolas Chauvet --- (In reply to Akarshan Biswas from comment #14) ... > For NoSource, > > @Nicolas Is there any updates from the last time we discussed about this? No, there is a need to implement the support in koji. Mock would already support it --using the --copyin option. For the record, we need to use nosrc.rpm in the chromium case because it lead to over-load the disk on the infra -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #14 from Akarshan Biswas --- (In reply to qvint from comment #13) > - > https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-23_1/ > chromium-browser-privacy.spec > - You need to start a fresh changelog for the chromium-browser-privacy. Rest is well okay. For NoSource, @Nicolas Is there any updates from the last time we discussed about this? -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #13 from qvint --- > You need to at least provide a spec file and best would be to provide > a nosrc.rpm so the package can be tested. - https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-23_1/chromium-browser-privacy.spec - https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-23_1/chromium-browser-privacy-76.0.3809.132-2.fc30.nosrc.rpm > With that said, such a big package with small time to dedicate is rather > suspicious task to start. I know, that's why I think it should be organized as a chromium-vaapi fork. Reusing vaapi maintenance efforts significantly reduces the time of package updating. > This will be the packager duty, not the infra team's job. I understand that. This is my primary browser, and I'm interested to keep it up-to-date. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #12 from Nicolas Chauvet --- (In reply to qvint from comment #11) > I'm sorry for the AWOL-ness, I'm still interested in the package. I've > decided > to fork the chromium-vaapi repo as it is proven to have the most up-to-date > Chromium in the Fedora world. You need to at least provide a spec file and best would be to provide a nosrc.rpm so the package can be tested. With that said, such a big package with small time to dedicate is rather suspicious task to start. The infra team at rpmfusion has no possibility to do some house keeping of package that need work. Either or not the task should be trivial. This will be the packager duty, not the infra team's job. So I re-iterate my advice to start with a copr project (without the freeworld part that would be forbidden there). -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114
qvint changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|EXPIRED |---
--- Comment #11 from qvint ---
I'm sorry for the AWOL-ness, I'm still interested in the package. I've decided
to fork the chromium-vaapi repo as it is proven to have the most up-to-date
Chromium in the Fedora world.
> I would also like to have the "name issue" sorted. Despite using the name of
> the patchset as a base helps it's also unclear what you want out from google.
> Using a "positive" wording would be more helpful. I'm suggesting to use
> "chromium-browser-privacy"
The upstream is also concerned about its name[1] so I renamed the package to
"chromium-browser-privacy".
I suggest you review only the following changes to chromium-vaapi instead of
the
full SRPM:
1) "Apply ungoogled-chromium modifications" -
https://github.com/qvint/ungoogled-chromium-fedora/commit/fee2c1becb4f49e4433287a85a014f965503fc1a
2) "Rename to chromium-browser-privacy" -
https://github.com/qvint/ungoogled-chromium-fedora/commit/9bd4d868cb69d76ea7e5eddf430ff846d7fa86fe
X) Both commits at once -
https://github.com/qvint/ungoogled-chromium-fedora/compare/chromium-vaapi-f30...chromium-browser-privacy-f30
rpmlint produces the same warnings as for chromium-vaapi except the first one
("spelling-error").
$ rpmlint chromium-browser-privacy-76.0.3809.132-2.fc30.src.rpm
chromium-browser-privacy.src: W: spelling-error %description -l en_US ungoogled
-> googled, goggled
chromium-browser-privacy.src:101: W: mixed-use-of-spaces-and-tabs (spaces: line
17, tab: line 101)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint chromium-browser-privacy-76.0.3809.132-2.fc30.x86_64.rpm
chromium-browser-privacy.x86_64: W: spelling-error %description -l en_US
ungoogled -> googled, goggled
chromium-browser-privacy.x86_64: W: incoherent-version-in-changelog
76.0.3809.132-1 ['76.0.3809.132-2.fc30', '76.0.3809.132-2']
chromium-browser-privacy.x86_64: E: missing-call-to-setgroups-before-setuid
/usr/lib64/chromium-browser-privacy/chrome-sandbox
chromium-browser-privacy.x86_64: E: missing-call-to-chdir-with-chroot
/usr/lib64/chromium-browser-privacy/chromium-browser-privacy
chromium-browser-privacy.x86_64: E: setuid-binary
/usr/lib64/chromium-browser-privacy/chrome-sandbox root 4755
chromium-browser-privacy.x86_64: E: non-standard-executable-perm
/usr/lib64/chromium-browser-privacy/chrome-sandbox 4755
chromium-browser-privacy.x86_64: E: non-executable-script
/usr/lib64/chromium-browser-privacy/xdg-mime 644 /bin/sh
chromium-browser-privacy.x86_64: E: non-executable-script
/usr/lib64/chromium-browser-privacy/xdg-settings 644 /bin/sh
1 packages and 0 specfiles checked; 6 errors, 2 warnings.
RPM downloads:
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-22_1/chromium-browser-privacy-76.0.3809.132-2.fc30.src.rpm
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-22_1/chromium-browser-privacy-76.0.3809.132-2.fc30.x86_64.rpm
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-22_1/chromium-browser-privacy-debuginfo-76.0.3809.132-2.fc30.x86_64.rpm
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2019-09-22_1/chromium-browser-privacy-debugsource-76.0.3809.132-2.fc30.x86_64.rpm
[1] https://github.com/Eloston/ungoogled-chromium/issues/738
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 Nicolas Chauvet changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |EXPIRED --- Comment #10 from Nicolas Chauvet --- Ok, let's close this for now (it can be re-opened at anytime). I would also suggest to use copr.fedoraproject.org to maintain this as the first steps. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #9 from Akarshan Biswas --- (In reply to Nicolas Chauvet from comment #8) > (In reply to Akarshan Biswas from comment #7) > ... > > > I'm suggesting to use "chromium-browser-privacy" > > > > Let's wait for a day, if we receive no response then we can close it I > > guess. > It's usually expected to wait for at least one week. > But anyway this can always be re-opened at some point. hmm. let's close it then. If it becomes active we will re open it. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #8 from Nicolas Chauvet --- (In reply to Akarshan Biswas from comment #7) ... > > I'm suggesting to use "chromium-browser-privacy" > > Let's wait for a day, if we receive no response then we can close it I guess. It's usually expected to wait for at least one week. But anyway this can always be re-opened at some point. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #7 from Akarshan Biswas --- (In reply to Nicolas Chauvet from comment #6) > Is there original submitter still interested in this package ? > > Seems like it was not updated since the review request. Please reminds that > we are not a housekeeping team for packages that maintainers can drop and > forget. If you don't maintain this package, it will be removed from the repo > at some point. (if ever it is introduced in in the first step). > > I would also like to have the "name issue" sorted. Despite using the name of > the patchset as a base helps it's also unclear what you want out from > google. Using a "positive" wording would be more helpful. > I'm suggesting to use "chromium-browser-privacy" Let's wait for a day, if we receive no response then we can close it I guess. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #6 from Nicolas Chauvet --- Is there original submitter still interested in this package ? Seems like it was not updated since the review request. Please reminds that we are not a housekeeping team for packages that maintainers can drop and forget. If you don't maintain this package, it will be removed from the repo at some point. (if ever it is introduced in in the first step). I would also like to have the "name issue" sorted. Despite using the name of the patchset as a base helps it's also unclear what you want out from google. Using a "positive" wording would be more helpful. I'm suggesting to use "chromium-browser-privacy" -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 Akarshan Biswas changed: What|Removed |Added Assignee|rpmfusion-package-review@rp |akarshan.biswas@protonmail. |mfusion.org |com -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #5 from Akarshan Biswas --- @qvint Sorry for the long silence. Can you please update it to latest stable provide the srpm and spec again please? I'm going to review it. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 --- Comment #4 from qvint --- (In reply to Miro Hrončok from comment #3) > Wouldn't the name "ungoogled" be problematic legally? It's just a patchset name. The browser still calls itself "Chromium". -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #3 from Miro Hrončok --- Wouldn't the name "ungoogled" be problematic legally? -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114
--- Comment #2 from qvint ---
(In reply to Akarshan Biswas from comment #1)
> 1) Does it need to build headless in this package? And why is it in a single
> package? I think we already have headless in Fedora?
> 2) You have disabled debug builds. Every package requires debug builds.
> 3) No provides please.
> 4) It's really no need to fix selinux context.
> 5) Remember minizip-compat is being deprecated in Fedora
> (https://bugzilla.redhat.com/show_bug.cgi?id=1632170)
> 6) If it is not for epel, please use system ninja instead.
> 7) Please remove entries which are not required here. For eg. nacl.
> 8) The build is not hardened. Please use Fedora build flags.
Thank you for your feedback, I fixed everything you mentioned.
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2018-12-22_1/ungoogled-chromium.spec
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2018-12-22_1/ungoogled-chromium-71.0.3578.98-2.fc29.src.rpm
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2018-12-22_1/ungoogled-chromium-71.0.3578.98-2.fc29.x86_64.rpm
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2018-12-22_1/ungoogled-chromium-debuginfo-71.0.3578.98-2.fc29.x86_64.rpm
-
https://ungoogled.blob.core.windows.net/ungoogled/review/2018-12-22_1/ungoogled-chromium-debugsource-71.0.3578.98-2.fc29.x86_64.rpm
---
rpmlint on source RPM
---
* E: hardcoded-library-path in /usr/lib/%{chromium_browser_channel}
* E: hardcoded-library-path in
/usr/lib/%{chromium_browser_channel}/%{chromium_browser_channel}.sh
* E: hardcoded-library-path in /usr/lib/chrome-sandbox
That's okay. Caused by `semanage` invocations.
* W: %ifarch-applied-patch Patch122:
chromium-70.0.3538.110-vaapi-i686-fpermissive.patch
See
https://src.fedoraproject.org/rpms/chromium/c/20998a3addbc35bfe1ebda7759cec1d13fa616cf
---
rpmlint on binary RPM
---
* E: explicit-lib-dependency libcanberra-gtk3(x86-64)
Chromium expects this GTK module for some reason.
* W: conffile-without-noreplace-flag /etc/ungoogled-chromium/master_preferences
Contains distro-specific settings.
* E: missing-call-to-setgroups-before-setuid
/usr/lib64/ungoogled-chromium/chrome-sandbox
* E: missing-call-to-chdir-with-chroot
/usr/lib64/ungoogled-chromium/ungoogled-chromium
* E: setuid-binary /usr/lib64/ungoogled-chromium/chrome-sandbox root 4755
* E: non-standard-executable-perm /usr/lib64/ungoogled-chromium/chrome-sandbox
4755
That's okay.
* E: script-without-shebang
/usr/lib64/ungoogled-chromium/pyproto/google/protobuf/internal/__init__.py
* E: htaccess-file /usr/lib64/ungoogled-chromium/resources/inspector/.htaccess
* E: zero-length
/usr/lib64/ungoogled-chromium/resources/inspector/emulated_devices/emulated_devices_module.js
* E: zero-length
/usr/lib64/ungoogled-chromium/resources/inspector/js_profiler/js_profiler_module.js
* E: zero-length
/usr/lib64/ungoogled-chromium/resources/inspector/node_debugger/node_debugger_module.js
Resource files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5114] Review request: ungoogled-chromium - Chromium, sans integration with Google
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5114 Akarshan Biswas changed: What|Removed |Added CC||akarshan.biswas@protonmail. ||com --- Comment #1 from Akarshan Biswas --- 1) Does it need to build headless in this package? And why is it in a single package? I think we already have headless in Fedora? 2) You have disabled debug builds. Every package requires debug builds. 3) No provides please. 4) It's really no need to fix selinux context. 5) Remember minizip-compat is being deprecated in Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1632170) 6) If it is not for epel, please use system ninja instead. 7) Please remove entries which are not required here. For eg. nacl. 8) The build is not hardened. Please use Fedora build flags. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
