[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115
--- Comment #16 from FeRD (Frank Dana) ---
I updated the spec file to use python%{python3_pkgversion} as the dependency,
which should get the package closer to building on EL7. The change is pushed,
but only to the master branch for now. (I didn't bother with a rebuild, no
need.)
Line 126 of the spec replaces a bare `python` command with `python3` in one of
the Makefiles, since `python` won't be a valid command on future Fedora
releases. Not sure whether that'll also need to be adjusted for EL7.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115
--- Comment #15 from FeRD (Frank Dana) ---
(In reply to Nicolas Chauvet from comment #14)
> Seems like there is a transient issue that I've just fixed for el7-free
> target.
> Now it seems like there are only few missing deps on the paper.
> python3 might be solved when CentOS will release 7.7.
> (x264 might not provide x264.pc, I will see if that can be fixed on the x264
> side).
>
> DEBUG util.py:587: Error: No Package found for CImg-devel
> DEBUG util.py:587: Error: No Package found for lilv-devel
> DEBUG util.py:587: Error: No Package found for pkgconfig(sratom-0)
> DEBUG util.py:587: Error: No Package found for pkgconfig(suil-0)
> DEBUG util.py:587: Error: No Package found for pkgconfig(x264)
> DEBUG util.py:587: Error: No Package found for python3
Hmm. `python3` would be `python3.6` on EL7, I know that from OpenShot. A
`BuildRequires: python%{python3_pkgversion}` would generalize it.
The media library deps... I left those in the spec because they were there when
I inherited it, but so much ended up getting bundled due to their heavy
patching that I'm not sure *all* of them are actually needed.
Though it's hard to say for certain, as I just experimentally checked `ldd
/usr/lib64/cinelerra-gg/hveg2enc`. It's linked with the system `libvorbis`,
`libogg`, and `libFLAC`... none of which are listed among the package requires
output by `rpm -q --requires cinelerra-gg`. Seems like rpmbuild's dependency
scanning might be a bit out to lunch.
That seems bad.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #14 from Nicolas Chauvet --- Seems like there is a transient issue that I've just fixed for el7-free target. Now it seems like there are only few missing deps on the paper. python3 might be solved when CentOS will release 7.7. (x264 might not provide x264.pc, I will see if that can be fixed on the x264 side). DEBUG util.py:587: Error: No Package found for CImg-devel DEBUG util.py:587: Error: No Package found for lilv-devel DEBUG util.py:587: Error: No Package found for pkgconfig(sratom-0) DEBUG util.py:587: Error: No Package found for pkgconfig(suil-0) DEBUG util.py:587: Error: No Package found for pkgconfig(x264) DEBUG util.py:587: Error: No Package found for python3 -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #13 from FeRD (Frank Dana) --- (In reply to Nicolas Chauvet from comment #12) > Pease reminds that building for el7 is also appropriate if possible. > (that more than the fedora users base). Is that a hint? ;-) My F30 system doesn't have enough disk to even attempt a build in Mock (the build chroot ends up growing to almost 5 GB, all told, and my /var is not even close to that big). But I fired off an el7-free scratch build in koji. If it works, then great, I guess I can... request a branch for el7, is that how that works? Nevermind, moot point — the scratch build already failed. So we can cross that bridge if we ever come to it. But as things stand, I'm not sure that trying to package an application THIS complex, for an OS I don't use or even have access to, is really feasible. However, if anyone else manages to get it working on el7, I'll happily apply any necessary spec patches and maintain a branch. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #12 from Nicolas Chauvet --- Pease reminds that building for el7 is also appropriate if possible. (that more than the fedora users base). Thx for this work on the package. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 FeRD (Frank Dana) changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #11 from FeRD (Frank Dana) --- Thanks, all set now. The 8-month-old sources from my original review submission didn't build under F30, so rather than fix old code I updated the package to their latest monthly snapshot release. (The new code still didn't build, initially, and required some more adjustments to our build configs, plus the addition of a patch (submitted upstream) to correct an issue building with recent glib versions like the one in rawhide.) But, finally, builds are completed for F29-F31 and rawhide. I tested the F30 build, but only to the extent that I've confirmed that it launches, appears minimally functional, and is able to export a valid and playable MP4 (AVC/AAC) video file. Closing this a Resolved. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #10 from Nicolas Chauvet --- (In reply to FeRD (Frank Dana) from comment #9) > Ping? Request is "Awaiting Review" > > https://admin.rpmfusion.org/pkgdb/package/free/cinelerra-gg/ Done, I don't think there is any notification, so better to ping along to request. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #9 from FeRD (Frank Dana) --- Ping? Request is "Awaiting Review" https://admin.rpmfusion.org/pkgdb/package/free/cinelerra-gg/ -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #8 from FeRD (Frank Dana) --- (In reply to Nicolas Chauvet from comment #7) > This package was approved by never went created in pkgdb. > Done the pkgdb creation, please apply for ACLS if needed. Eep! I _completely_ forgot about this package, sorry. ACLs requested, initial check-in commit ready to be pushed. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #7 from Nicolas Chauvet --- This package was approved by never went created in pkgdb. Done the pkgdb creation, please apply for ACLS if needed. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #6 from Sérgio Basto --- SPEC: https://bugzilla.rpmfusion.org/attachment.cgi?id=1999 SRPM: http://koji.rpmfusion.org/kojifiles/work/tasks/2459/282459/cinelerra-gg-5.1-55.20181217gitd5a0afb.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 Sérgio Basto changed: What|Removed |Added Attachment #1999|text/plain |text/x-rpm-spec mime type|| -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 Sérgio Basto changed: What|Removed |Added CC||ser...@serjux.com Attachment #1999|text/x-rpm-spec |text/plain mime type|| -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Blocks|2 |4
Assignee|rpmfusion-package-review@rp |zebo...@gmail.com
|mfusion.org |
Flags||fedora-review+
--- Comment #5 from Robert-André Mauchin ---
Re-read the previous discussion about unbundling. It should be fine.
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD (unspecified)", "GPL (v2 or later)
(with incorrect FSF address)", "*No copyright* GNU Lesser General
Public License (v2 or later)", "GPL (v2 or later) (with incorrect FSF
address) GNU Lesser General Public License (v2.1 or later)", "BSD
3-clause "New" or "Revised" License", "*No copyright* Creative Commons
Attribution Public License (v3.0)", "GPL (v2 or later)", "*No
copyright* GPL (v2 or later) (with incorrect FSF address)", "*No
copyright* GPL (v2 or later)", "Public domain", "*No copyright*
CeCILL-C License", "*No copyright* CeCILL License (v2.0)", "*No
copyright* Creative Commons Attribution Public License (v4.0)", "*No
copyright* Public domain". 10052 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/cinelerra-
gg/review-cinelerra-gg/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #4 from Nicolas Chauvet --- (In reply to Robert-André Mauchin from comment #3) [...] > Also it compiles everything from thirdparty/, can't it be unbundled? > Compiling all of this is a PITA. This can still be improve on later steps. For now the only important things is to not introduce a package that breaks the distro. (by providing a dependency from another system library or else) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #3 from Robert-André Mauchin --- Any news about this? FLAC, dv, OpenCV seems pretty important for a video editor. # WIP # --with-dv=no \ # --enable-giflib=no \ # --enable-flac=no \ # --enable-libuuid=no \ # --with-opencv=sys \ # --with-thirdparty=no \ # --with-commercial=no \ # --with-libzmpeg=no \ # --enable-static-build=no \ Also it compiles everything from thirdparty/, can't it be unbundled? Compiling all of this is a PITA. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #2 from Nicolas Chauvet --- Any improvement with this ? Anyone to review ? -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 --- Comment #1 from FeRD (Frank Dana) --- rpmlint output: Nothing of consequence. $ rpmlint cinelerra-gg.spec cinelerra-gg-5.1-55.20181217gitd5a0afb.ferd29.src.rpm cinelerra-gg-5.1-55.20181217gitd5a0afb.ferd29.x86_64.rpm cinelerra-gg.src: W: spelling-error %description -l en_US quicktime -> quicklime, quick time, quick-time cinelerra-gg.src: W: spelling-error %description -l en_US avi -> av, vi, avid cinelerra-gg.src: W: spelling-error %description -l en_US ogg -> egg, org, Gog cinelerra-gg.src: W: spelling-error %description -l en_US divx -> div, dive, diva cinelerra-gg.src: W: spelling-error %description -l en_US xvid -> xvi, xvii, avid cinelerra-gg.src: W: spelling-error %description -l en_US goodguy -> good guy, good-guy, goody cinelerra-gg.x86_64: W: spelling-error %description -l en_US quicktime -> quicklime, quick time, quick-time cinelerra-gg.x86_64: W: spelling-error %description -l en_US avi -> av, vi, avid cinelerra-gg.x86_64: W: spelling-error %description -l en_US ogg -> egg, org, Gog cinelerra-gg.x86_64: W: spelling-error %description -l en_US divx -> div, dive, diva cinelerra-gg.x86_64: W: spelling-error %description -l en_US xvid -> xvi, xvii, avid cinelerra-gg.x86_64: W: spelling-error %description -l en_US goodguy -> good guy, good-guy, goody cinelerra-gg.x86_64: W: incoherent-version-in-changelog 5.1-55.20181217gitd5a0afb ['5.1-55.20181217gitd5a0afb.ferd29', '5.1-55.20181217gitd5a0afb.ferd29'] cinelerra-gg.x86_64: W: no-manual-page-for-binary bdwrite cinelerra-gg.x86_64: W: no-manual-page-for-binary cin_db cinelerra-gg.x86_64: W: no-manual-page-for-binary cinelerra-gg cinelerra-gg.x86_64: W: no-manual-page-for-binary zmpeg3cat cinelerra-gg.x86_64: W: no-manual-page-for-binary zmpeg3cc2txt cinelerra-gg.x86_64: W: no-manual-page-for-binary zmpeg3ifochk cinelerra-gg.x86_64: W: no-manual-page-for-binary zmpeg3show cinelerra-gg.x86_64: W: no-manual-page-for-binary zmpeg3toc 2 packages and 1 specfiles checked; 0 errors, 21 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5115] Review Request: cinelerra-gg - A non linear video editor and effects processor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5115 FeRD (Frank Dana) changed: What|Removed |Added Blocks||2 Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2 [Bug 2] Tracker: New packages awaiting review -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
