[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 Nicolas Chauvet changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #13 from Nicolas Chauvet --- Seems imported. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 Vasiliy Glazov changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #12 from leigh scott --- (In reply to leigh scott from comment #10) > (In reply to Vasiliy Glazov from comment #3) > > Approved. > > Thanks for the review can you set the + flag so I can process the request > please? > > Fedora-review flag not approved Can you set it again as I have clubbed the + with my last response :-( -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 leigh scott changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #11 from leigh scott --- @vascom2 When your ready for the gnome-mpv rereview needed for the rename https://github.com/celluloid-player/celluloid Feel free to assign it to me. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 Vasiliy Glazov changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #10 from leigh scott --- (In reply to Vasiliy Glazov from comment #3) > Approved. Thanks for the review can you set the + flag so I can process the request please? Fedora-review flag not approved -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #9 from Akarshan Biswas --- (In reply to Vasiliy Glazov from comment #8) > As I see mpc-qt - not frontend to mpv like smplayer or gnome-mpv. Ut just > use mpv-libs to play video. It's a GUI frontend for mpv. Qt is an alternative toolkit like GTK. Please see: https://github.com/mpv-player/mpv/wiki/Applications-using-mpv -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #8 from Vasiliy Glazov --- As I see mpc-qt - not frontend to mpv like smplayer or gnome-mpv. Ut just use mpv-libs to play video. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #7 from Vasiliy Glazov --- It is not mandatory. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278
--- Comment #6 from Akarshan Biswas ---
(In reply to Vasiliy Glazov from comment #5)
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
>
> If a package contains a GUI application, then it SHOULD install a
> .appdata.xml file into %{_metainfodir}.
Exactly, I don't see any reference of %{metainfodir} in the %file section.
Though I admit I haven't checked the source archive. An appdata file required
before this package can be approved because mpc-qt is one of the GUI frontend
for mpv written in Qt similar to gnome-mpv.
Cheers,
Akarshan Biswas
Pronouns: He/Him/His
TZ=Asia/Kolkata
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278
--- Comment #5 from Vasiliy Glazov ---
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
If a package contains a GUI application, then it SHOULD install a .appdata.xml
file into %{_metainfodir}.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 Akarshan Biswas changed: What|Removed |Added CC||akarshan.biswas@protonmail. ||com --- Comment #4 from Akarshan Biswas --- I might be wrong but I find no mention appdata either in the spec file or in the source rpm. Isn't supposed to add an appdata file to for a GUI application make it discover able in GUI software managers as a rule? Cheers, Akarshan Biswas -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #3 from Vasiliy Glazov --- Approved. -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #2 from leigh scott --- (In reply to Vasiliy Glazov from comment #1) > 1. Change license to GPLv2+. > > 2. In %files section license file must be in > %license LICENSE > not in %doc. > 1 and 2 have been fixed > Are you shure that you want add to repo project with last commit almost a > year ago? Yes -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 --- Comment #1 from Vasiliy Glazov --- 1. Change license to GPLv2+. 2. In %files section license file must be in %license LICENSE not in %doc. Are you shure that you want add to repo project with last commit almost a year ago? -- You are receiving this mail because: You are on the CC list for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|rpmfusion-package-review@rp |vasc...@gmail.com |mfusion.org | Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5278] Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5278 leigh scott changed: What|Removed |Added Group|Package Reviews | -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
