[Bug 11656] Escaping broken with --files-from

2017-10-08 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=11656

Wayne Davison  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #10 from Wayne Davison  ---
The consistent and documented escaping is that some characters get ouput with a
backslash+hash+3-digit octal number. This includes control chars, some
backslashes, and (without -B) high-bit chars.  From the man page:

"The escape idiom that started in 2.6.7 is to output a literal backslash (\)
and a hash (#), followed by exactly 3 octal digits.  For example, a newline
would output as "\#012".  A literal backslash that is in a filename is not
escaped unless it is followed by a hash and 3 digits (0-9)."

One easy way to unescape is thus to filter names through something like this:

perl -pe 's/\\#(\d\d\d)/chr(oct($1))/eg'

(...after any necessary parsing of the output to find the names or twiddle
newlines into nulls).  You'll note that this only matches exactly 3-digits, as
rsync will leave something like "\#5" alone in the output, since it cannot be
confused with an actual escaped char.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 11571] rsync-3.1.1 --link-dest arbitrary limit

2017-10-08 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=11571

Wayne Davison  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Wayne Davison  ---
The limit is now documented.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 12417] Sametimes currupted file after disconnect

2017-10-08 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12417

Wayne Davison  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Re: read dir list with write only option

2017-10-08 Thread Wayne Davison via rsync
On Wed, Sep 6, 2017 at 1:00 AM, Pavel Kasparek via rsync <
rsync@lists.samba.org> wrote:

> when the "write only = yes" option is used on rsync server, [... would a]
> hacked client [...] be able to get the list of remote dir [?]


It wouldn't work. The listing action is a special kind of read operation,
and all read operations are denied by the server when "write only" is used.
I'd also suggest that you specify "refuse options = delete" for a
write-only module.

..wayne..
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Re: --no-omit-dir-times does not override --backup

2017-10-08 Thread Wayne Davison via rsync
On Sat, Sep 16, 2017 at 10:13 AM, Anders Gronberg via rsync <
rsync@lists.samba.org> wrote:

> As I understand the documentation "--backup" without specifying
> "--backup-dir" implicitly sets "--omit-dir-times".
> It is then possible to negate the implied option by specifying it prefixed
> with "--no".
>

No, it is not possible to override that. The backup operations occurring
inside the transfer directories cause the directory times to get tweaked,
so rsync doesn't support trying to keep those times the same (without
moving your backup files elsewhere). There is no error because
--no-omit-dir-times is the default, and rsync expects to override that
default. Yes,, it would be possible to make rsync complain with more a
complicated option setup, but I don't think that the extra complexity is
warranted for this. I've tweaked the man page to mention that it is forced
on.
..wayne..
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 11866] rsync fails (failed to re-stat) when using double fuzzy + link-dest on renamed files

2017-10-08 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=11866

--- Comment #5 from Ben RUBSON  ---
Thank you very much for the merge Wayne !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 11866] rsync fails (failed to re-stat) when using double fuzzy + link-dest on renamed files

2017-10-08 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=11866

Wayne Davison  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Wayne Davison  ---
Thanks for figuring out the issue and providing a patch. I've committed it to
git.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[Bug 12568] Integer overflow still exists in xattrs.c, leading to buffer overflow

2017-10-08 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12568

Wayne Davison  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Wayne Davison  ---
I've committed a fix for this into git. Many thanks for pointing this out.
Sorry for how slow I've been lately.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html