Re: Rsync 3.2.3 released

2020-08-07 Thread Michal Ruprich via rsync
Hi Wayne,

I see that a couple of patches from the rsync-patches tar have
disappeared, like acls.diff or xattrs.diff yet I don't see the changes
in the code. Is there a reason for their removal? Were they applied
differently on the code and are no longer needed?

Thanks for any info on this.

Regards,

Michal Ruprich


On 8/7/20 7:45 AM, Rupert Gallagher via rsync wrote:
> Rsync 3.2.2 ransfer rate on my pet hardware is really poor, so every
> improvement counts.
>
> I noted that rsync writes a gmon file on the source path and leaves it
> there when it terminates. When the source path is read-only, rsync
> complains that it cannot write in it. For optimal use of the input
> bus, no write commands should be used there. Can you look into it?
>
> Also, I have 12GB of cache in ecc ram that rsync is not using. I can
> tell because I see frantic io from the leds of the disks when rsync is
> the only running process. Can you add an option to maximise the use of
> ram cache?
>
> Thank you!
>
>
>  Original Message 
> On 7 Aug 2020, 07:15, Wayne Davison via rsync < rsync@lists.samba.org>
> wrote:
> I have released rsync 3.2.3.  It contains a smattering of bug fixes
> and various enhancements.
>
> To see a summary of all the recent changes, visit this link:
>
>     https://rsync.samba.org/ < href=>ftp/rsync/NEWS#3.2.3">https://rsync.samba.org/ftp/rsync/NEWS#3.2.3
>
> You can download the source tar file and its signature from here:
>
>     https://rsync.samba.org/ < href=>ftp/rsync/rsync-3.2.3.tar.gz">https://rsync.samba.org/ftp/rsync/rsync-3.2.3.tar.gz
>     https://rsync.samba.org/ < href=>ftp/rsync/rsync-3.2.3.tar.gz">https://rsync.samba.org/ftp/rsync/rsync-3.2.3.tar.gz.asc
>
> See the website for other downloads, including diffs, patches, etc.:
>
>     https://rsync.samba.org/
>
> See also rsync on github:
>
>     https://github.com/WayneD/rsync
>
> ..wayne..
>
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


character devices

2020-06-26 Thread Michal Ruprich via rsync
Hi,

I was running a couple of tests on the latest rsync and noticed a
different behavior when it comes to character devices. The test creates
a character device on the client side and a simple text file on the
server side. When copying from server to the client, previously the
character device would get changed to a regular text file after the
transaction but with new rsync, the character device is still a
character device.

Before:

# ls -l /var/tmp/client

crw-rw-rw-. 1 root root 1, 0 Jun 26 05:41
character.device

# ls -l /home/rsynctestuser/rsyncdata

-rw-r--r--. 1 root root   12 Jun 26 05:41
character.device

# rsync --perms --owner --group --times --update --recursive
::my_data /var/tmp/client

# ls -l /var/tmp/client

-rw-r--r--. 1 root root   12 Jun 26 05:46
character.device   <--- the file has changed to a text file


After:

# ls -l /var/tmp/client/

crw-rw-rw-. 1 root root 1, 0 Jun 26 05:46
character.device

# ls -l /home/rsynctestuser/rsyncdata

-rw-r--r--. 1 root root   12 Jun 26 05:46
character.device

#rsync --perms --owner --group --times --update --recursive
::my_data /var/tmp/client

# ls -l /var/tmp/client

crw-rw-rw-. 1 root root 1, 0 Jun 26 05:46
character.device <--- no change in the type of file


I tried to run the newer version with --write-devices but manpage says:
"This option is refused by an rsync daemon.". I am trying to find out
what is the correct behavior in this case. Was the assumption that the
character device would change with the older version wrong? Is there a
way how to let the server rewrite the file? I tried the 'refuse options'
statement in the rsyncd.conf but no luck.

I would truly appreciate any ideas about this.

Thanks and regards,

Michal Ruprich


-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


NFS4 extended attributes confusion

2019-07-25 Thread Michal Ruprich via rsync
Hi,

would someone please clarify the behavior of -X --filter='some_filter'
to me? I was trying to copy a file on a NFS4 mount and some extended
attributes get transferred only when run as a normal user with --super
but not as root. If I have a file on nfs4 mount and I set some extended
attributes like this:

#rsync --version

rsync  version 3.1.3  protocol version 31
Copyright (C) 1996-2018 by Andrew Tridgell, Wayne Davison, and others.
Web site: http://rsync.samba.org/
Capabilities:
    64-bit files, 64-bit inums, 64-bit timestamps, 64-bit long ints,
    socketpairs, hardlinks, symlinks, IPv6, batchfiles, inplace,
    append, ACLs, xattrs, iconv, symtimes, prealloc

...

# nfs4_setfacl -a A::root@localhost:rwaxtcy
/tmp/nfs_test_mountpoint/test_file

# nfs4_setfacl -a A::testuser@localhost:rwaxtcy
/tmp/nfs_test_mountpoint/test_file

# nfs4_getfacl /tmp/nfs_test_mountpoint/test_file

# file: /tmp/nfs_test_mountpoint/test_file
D::OWNER@:x
A::OWNER@:rwatTcCy
A::0:rwaxtcy   <---
A::1000:rwaxtcy  <--
A::GROUP@:rwatcy
A::EVERYONE@:rtcy

Then when I use rsync, different attributes are copied when running as
testuser or root:

ROOT:

# rsync -X --filter='-x! system.nfs4_acl'
/tmp/nfs_test_mountpoint/test_file
/tmp/nfs_test_mountpoint/test_file_synced_root

# nfs4_getfacl /tmp/nfs_test_mountpoint/test_file_synced_root

D::OWNER@:x
A::OWNER@:rwatTcCy
A::0:rxtcy   <---
A::1000:rxtcy    <---
A::GROUP@:rtcy
A::EVERYONE@:rtcy

TESTUSER:

# rsync --super -X --filter='-x! system.nfs4_acl'
/tmp/nfs_test_mountpoint/test_file
/tmp/nfs_test_mountpoint/test_file_synced_user

# nfs4_getfacl /tmp/nfs_test_mountpoint/test_file_synced_user

D::OWNER@:x
A::OWNER@:rwatTcCy
A::0:rwaxtcy   <-
A::1000:rwaxtcy   <---
A::GROUP@:rwatcy
A::EVERYONE@:rtcy

I am really confused as to why the 'wa' attributes get transferred when
initiated as a normal user but not as root. Could anyone bring some
light into this for me?

Thanks.

Michal



-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


Two log files instead of one?

2017-08-30 Thread Michal Ruprich via rsync
Hi all,

I'm a bit confused about the log-file option for the daemon rsync.

What the rsyncd.conf manual page says about the 'log file' option in
rsyncd.conf:

"This setting can be overridden by using the --log-file=FILE or
--dparam=logfile=FILE command-line options.  The former overrides all
the log-file parameters of  the  daemon  and all  module  settings."

And the rsync manual page in the daemon section says:

"This option tells the rsync daemon to use the given log-file name
instead  of  using  the "log file" setting in the config file."

From this I would assume that when I run the daemon like this:
$/usr/bin/rsync --daemon --log-file=/tmp/rsync_test.log --no-detach
"$OPTIONS", I would get one log file - /tmp/rsync_test.log. Instead when
I run rsync from a remote client, two log files are created. There is a
piece of information in the /var/log/rsyncd.log file (the default one
from /etc/rsyncd.conf) and another piece of information in
rsync_test.log. Is this how it is supposed to work or is it a bug?

Thanks.

Michal Ruprich


-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Re: Code inconsistency between release version and git in rsync-3.0.9

2017-05-02 Thread Michal Ruprich via rsync
Ok, this is my mistake. I cloned the git repo and I was looking into the
master. There is no v3.0.9 tag, the last tag for 3.0.x version is v3.0.3
in this branch. I have rsync 3.0.9 as the latest version on my system
and I was trying to determine the severity of changes between v3.0.9 and
v3.1.0. When I was looking for certain commits, I noticed that there are
changes in files that don't really fit the 3.0.9 but I never noticed
that there is a separate working tree for each 3.0.x version.

Sorry for the trouble and thanks for the clarification.


On 04/05/2017 01:36 AM, Robin H. Johnson wrote:
> On Tue, Apr 04, 2017 at 11:12:11AM +0200, Michal Ruprich via rsync wrote:
>> There are huge differences between source files in the version 3.0.9
>> released as a tar.gz and source files in git. I  would assume that the
>> released version would correspond to the version in git but with 3.0.9
>> it is not like that. In 3.1.0 the released and git versions are more or
>> less the same.
> How did you construct this?
>
> I can't reproduce your result. The only differences I see are the generated
> files proto.h, rsync.1, and rsyncd.conf.5.
>
> Here's my test steps, with the output of everything except the final diffstats
> omitted.
>
> $ cd /tmp
> $ tar xvf .../rsync-3.0.9.tar.gz
> $ tar xvf .../rsync-3.1.0.tar.gz
> $ git clone --bare git://git.samba.org/rsync.git /tmp/rsync-git-bare/
> $ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.0.9 v3.0.9
> $ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.1.0 v3.1.0
> $ diff -Nuar rsync-git-3.0.9/ rsync-3.0.9/ --exclude .git --exclude-from 
> rsync-git-3.0.9/.gitignore >rsync-git__rsync-3.0.9.diff
> $ diff -Nuar rsync-git-3.1.0/ rsync-3.1.0/ --exclude .git --exclude-from 
> rsync-git-3.1.0/.gitignore >rsync-git__rsync-3.1.0.diff
> $ diffstat   proto.h   |  405 ++
>  rsync.1   | 3585 
> ++
>  rsyncd.conf.5 |  864 +
>  3 files changed, 4854 insertions(+)
> $ diffstat   proto.h   |  422 ++
>  rsync.1   | 3958 
> ++
>  rsyncd.conf.5 | 1075 +++
>  3 files changed, 5455 insertions(+)
>


-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


Code inconsistency between release version and git in rsync-3.0.9

2017-04-04 Thread Michal Ruprich via rsync
There are huge differences between source files in the version 3.0.9
released as a tar.gz and source files in git. I  would assume that the
released version would correspond to the version in git but with 3.0.9
it is not like that. In 3.1.0 the released and git versions are more or
less the same.

So my question is, from what source files was the 3.0.9 version created?
Thank you.
Regards,

Michal Ruprich

-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html