Re: [rsyslog] potential policy change: fixes for unsupported versions
Thanks to those that commented. Not much feedback, indeed. So my plan is to remove all branches other than v7-stable and master from the public git by the end of the week if there is no strong objection. It's actually something like a testbed. As Adiscon needs to maintain (like RH, Ubuntum, ... does) old versions for its customers, I can restore those branches from the Adiscon internal git if there is hard need to. In the public git, I'll in the future think if it is really worth applying a patch to both v7-stable and master or to master only. If I think it needs to be applied to both, I'll merge up, as I always did. If there is consensus that this is a bad thing, I'll remove v7-stable as well. But from what I have read the consensus is that the majority of folks is sufficiently happy with the merge commits that result from merging up. I guess we'll see how things work out over time. And, again, if there is hard need, I can restore missing things from the Adiscon internal git. Thanks again, Rainer - 2014-11-10 17:18 GMT+01:00 Thomas D. : > Hi, > > On 2014-11-07 16:20, Rainer Gerhards wrote: > > So my question is: do we need to keep fixing the old stuff ... or can we > > really abandon that? > > No. You should only patch the master. > > If the patch is clean (rebased... squashed into suitable commits) > everyone should be able to backport a fix if really needed. > > At least he/she can ask for help so you (Adiscon) would know "This is an > important bugfix..." ;) > > > -Thomas > > ___ > rsyslog mailing list > http://lists.adiscon.net/mailman/listinfo/rsyslog > http://www.rsyslog.com/professional-services/ > What's up with rsyslog? Follow https://twitter.com/rgerhards > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you > DON'T LIKE THAT. > ___ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
Re: [rsyslog] potential policy change: fixes for unsupported versions
Hi, On 2014-11-07 16:20, Rainer Gerhards wrote: > So my question is: do we need to keep fixing the old stuff ... or can we > really abandon that? No. You should only patch the master. If the patch is clean (rebased... squashed into suitable commits) everyone should be able to backport a fix if really needed. At least he/she can ask for help so you (Adiscon) would know "This is an important bugfix..." ;) -Thomas ___ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
Re: [rsyslog] potential policy change: fixes for unsupported versions
On Fri, 7 Nov 2014, Rainer Gerhards wrote: Hi, just to bring out another potential policy change to the full bright light: There was discussion that in order to tidy up commit log, I should no longer merge up branches. As I don't have the time to do manually what currently git does for me, this means I will stop providing fixes for versions other than the currently supported one (8.4.2 at the moment). When I discussed this in Adiscon internally, we saw quite some advantage for us as well: if the unsupported versions are really unsupported, people hopefully would be more likely to update to the current versions. Also, it means a bit of less work for me, which frees up a little bit of resources. I honestly do not know how many folks at all really depend on e.g. v7-stable. My impression is that many, if not most, distros tend to base on a then-current version and apply patches to this baseline. So my question is: do we need to keep fixing the old stuff ... or can we really abandon that? My opinion. bugfixes that have no work-around may be reasonable to add to the last version before the current one, but going back further than that, or including fixes for bugs that can be worked around is doing too much work. maintaining an old version with the idea of only incorporating bugfixes to it over time is a lot of work, and it's fairly error prone (not to mention the ongoing debate as to what types of changes are safe to backport). Maintinance of such trees should be handed off from the main maintainer to someone who has interest in doing all this work. In the cae of rsyslog, the distros are doing some version of this. It may be reasonable for the distro maintainers to step up and maintain offical 'stable' versions for a while (hopefully getting some standardization beween the distros so they can share the work) But for this we really need feedback from the distro maintainers. David Lang ___ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
[rsyslog] potential policy change: fixes for unsupported versions
Hi, just to bring out another potential policy change to the full bright light: There was discussion that in order to tidy up commit log, I should no longer merge up branches. As I don't have the time to do manually what currently git does for me, this means I will stop providing fixes for versions other than the currently supported one (8.4.2 at the moment). When I discussed this in Adiscon internally, we saw quite some advantage for us as well: if the unsupported versions are really unsupported, people hopefully would be more likely to update to the current versions. Also, it means a bit of less work for me, which frees up a little bit of resources. I honestly do not know how many folks at all really depend on e.g. v7-stable. My impression is that many, if not most, distros tend to base on a then-current version and apply patches to this baseline. So my question is: do we need to keep fixing the old stuff ... or can we really abandon that? Feedback is highly appreciated. Thanks, Rainer ___ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
