Re: [rt-users] 3.8.2 message display bug reappears in 3.8.3

2009-06-03 Thread Kevin Falcone
On Jun 2, 2009, at 5:28 AM, Jo Rhett wrote:

 I reported this message display bug about 3 months ago, Kevin agreed
 with the fix, but it's still present in 3.8.3.  Without this fix, if
 you click Show next to an outgoing mail message, regardless of your
 preference settings, text paragraphs are a single long line.

I don't recall agreeing with the fix, but I did ask for it to end up  
in the
bug tracker so it could be tracked.

Its currently slated for review for 3.8.4
http://rt3.fsck.com/Ticket/Display.html?id=13230

As I recall, during triage for 3.8.3 I couldn't immediately replicate
the problem you were solving so we left it for further review when
we had a little more time to replicate.

-kevin



 --- ShowEmailRecord.html_orig   2009-02-23 16:55:17.0 -0800
 +++ ShowEmailRecord.html2009-02-23 16:56:22.0 -0800
  -65,7 +65,7
  my $show;
  $show = sub {
  my $attach = shift;
 -$m-out( 'div id=bodypre style=padding: 2em;' );
 +$m-out( 'div id=body style=white-space: pre-wrap; padding:
 2em;' );
  $m-out( $m-interp-apply_escapes( $attach-Headers, 'h' ) );
  $m-out( \n\n );
  if ( $attach-ContentType =~ m{^multipart/}i ) {
  -76,7 +76,7
  } else {
  $show_content-( $attach );
  }
 -$m-out( '/pre/div' );
 +$m-out( '/div' );
  };

  my $AttachmentObj = new RT::Attachment($session{'CurrentUser'});

 -- 
 Jo Rhett
 Net Consonance : consonant endings by net philanthropy, open source
 and other randomness



 ___
 http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

 Community help: http://wiki.bestpractical.com
 Commercial support: sa...@bestpractical.com


 Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
 Buy a copy at http://rtbook.bestpractical.com


___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sa...@bestpractical.com


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com


Re: [rt-users] 3.8.2 message display bug reappears in 3.8.3

2009-06-03 Thread Jo Rhett
On Jun 3, 2009, at 5:23 AM, Kevin Falcone wrote:
 I reported this message display bug about 3 months ago, Kevin agreed
 with the fix, but it's still present in 3.8.3.  Without this fix, if
 you click Show next to an outgoing mail message, regardless of your
 preference settings, text paragraphs are a single long line.

 I don't recall agreeing with the fix, but I did ask for it to end up
 in the
 bug tracker so it could be tracked.

 Its currently slated for review for 3.8.4
 http://rt3.fsck.com/Ticket/Display.html?id=13230

 As I recall, during triage for 3.8.3 I couldn't immediately replicate
 the problem you were solving so we left it for further review when
 we had a little more time to replicate.


It only happens when you click Show for outbound messages - ie, to  
AdminCcs or Requestors.  Normal ticket display is unaffected.

-- 
Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source  
and other randomness



___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sa...@bestpractical.com


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com


Re: [rt-users] 3.8.2 message display bug reappears in 3.8.3

2009-06-03 Thread Kevin Falcone
On Jun 3, 2009, at 2:47 PM, Jo Rhett wrote:

 On Jun 3, 2009, at 5:23 AM, Kevin Falcone wrote:
 I reported this message display bug about 3 months ago, Kevin agreed
 with the fix, but it's still present in 3.8.3.  Without this fix, if
 you click Show next to an outgoing mail message, regardless of  
 your
 preference settings, text paragraphs are a single long line.

 I don't recall agreeing with the fix, but I did ask for it to end up
 in the
 bug tracker so it could be tracked.

 Its currently slated for review for 3.8.4
 http://rt3.fsck.com/Ticket/Display.html?id=13230

 As I recall, during triage for 3.8.3 I couldn't immediately replicate
 the problem you were solving so we left it for further review when
 we had a little more time to replicate.


 It only happens when you click Show for outbound messages - ie, to
 AdminCcs or Requestors.  Normal ticket display is unaffected.

http://rt3.fsck.com/Ticket/ShowEmailRecord.html?id=13230Transaction=109609Attachment=52649

That looked fine, so I tabled it for 3.8.3 until we could figure out  
what it
was trying to fix.

-kevin

___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sa...@bestpractical.com


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com


Re: [rt-users] 3.8.2 message display bug reappears in 3.8.3

2009-06-03 Thread jmoseley
FWIW, I do not see this behavior using RT 3.8.3 and FireFox 3.0.10.


James Moseley




Jo Rhett jrh...@netconsonance.com wrote:


It only happens when you click Show for outbound messages - ie, to
AdminCcs or Requestors.  Normal ticket display is unaffected.



___
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sa...@bestpractical.com


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com