[rtc-linux] Marijuana,Actavis,Xanax,Diazepam,Subutex,cannabis oil,hash oil,hemp oil FOR SALE..Call/Text/WhatsApp: (614) 758-3044. EMAIL:macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] We are worldwide and legit suppliers of top quality medical marijuana. Call/Text/WhatsApp: (614) 758-3044. EMAIL:macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Diazepam,medical marijuana of all strains and top grade pain. Call/Text/WhatsApp: (614) 758-3044. EMAIL: macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] High grade actavis,hi tech cough,pills and medical marijuana. Call/Text/WhatsApp: (614) 758-3044. EMAIL: macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] CANNABIS, CANNABIS OIL AND OTHER CANNABIS RELATED PRODUCTS FOR SALE. Call/Text/WhatsApp: (614) 758-3044. EMAIL: macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] High suppliers of pain killers, medical marijuana, cannabis oils, etc Call/Text/WhatsApp: (614) 758-3044. EMAIL: macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Blueberry, Moonrock,Purple Haze,Xanax Pain Meds,Medical Marijuana Strains. Call/Text/WhatsApp:(614) 758-3044. EMAIL:macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] High quality medical marijuana and Canabis Oil for cancer treatment for sale. Call/Text/WhatsApp: (614) 758-3044. EMAIL:macksonpresto...@gmail.com

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Quality OG kush,Sour Diesel, greens and pain relief meds Available. Email us at macksonpresto...@gmail.com or Call/Text/WhatsApp (614) 758-3044

2017-04-20 Thread macksonpreston95 
Get High Grade Medical Marijuana, Hash, BHO, HEMP OILS, THC OILS, Cannabis 
Oil FOR SALE We grow them at our farm and sell to our customers directly. 
It means we can offer them at very good, dutch farm prices and we are sure 
of their quality. We got some GOOD MEDICAL marijuana/weeds,hemp oil,wax and 
their SEEDS such as

Sour Diesel
Moonrock 
Jack Herer
Blueberry Yum Yum
Girl Scout Cookies
Pineapple Express
GrandDaddy Purple,
OG Kush,
Sour Og Kush,
Green #,
Jack Dream,
AK-47,
Purple Kush,
Bubba Kush,
Bubblegum Kush,
Blueberry,
Purple-Skunk,
Master Kush,
Purple Haze,
Banana Kush,
Orange kush,
Night Queen,
Big Bud,
Cheese,
BlueDream,
White Russia,
White Widowetc,

HASH OILS FOR SALE

Black oil,
Indian oil,
red oil,
honey oil,
cherry leb oil
Afghani oil
Organic Hemp Oil 16 fl oz Liquid
Kosher Organic Cold Pressed Hemp Oil 8 OZ
Hemp Oil Essential Fatty Acid
WAX OIL
BUTANE OIL

We guarantee the safety passage of your package ,all our packages are 
customized and diplomatic sealed packages this means that they are custom 
free.

Text, Call or WhatsApp us on +1(614)758-3044
emailmacksonpresto...@gmail.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH] rtc: ds1374: Add trickle charger device tree binding

2017-04-20 Thread Moritz Fischer 
On Thu, Apr 20, 2017 at 10:56:34AM -0500, Rob Herring wrote:
> On Mon, Apr 17, 2017 at 03:40:10PM -0700, Moritz Fischer wrote:
> > Introduce a device tree binding for specifying the trickle charger
> > configuration for ds1374. This is based on the code for ds13390.
> > 
> > Signed-off-by: Moritz Fischer 
> > ---
> >  .../devicetree/bindings/rtc/dallas,ds1374.txt  | 18 
> >  drivers/rtc/rtc-ds1374.c   | 54 
> > ++
> >  2 files changed, 72 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt 
> > b/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> > new file mode 100644
> > index 000..4cf5bd7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> > @@ -0,0 +1,18 @@
> > +* Dallas DS1374I2C Real-Time Clock / WDT
> 
> Please remove from trivial-devices.txt, too. (which is moving in 4.12 
> BTW)

Ok, I'll redo this on top of b7e252fcddfa573bb1ee275b53bba6cef85671d4
(Documentation: devicetree: move trivial-devices out of I2C realm) then.

> 
> > +
> > +Required properties:
> > +- compatible: Should contain "dallas,ds1374".
> > +- reg: I2C address for chip
> > +
> > +Optional properties:
> > +- trickle-resistor-ohms : Selected resistor for trickle charger
> > +   Values usable for ds1374 are 250, 2000, 4000
> > +   Should be given if trickle charger should be enabled
> > +- trickle-diode-disable : Do not use internal trickle charger diode
> > +   Should be given if internal trickle charger diode should be disabled
> 
> These should have vendor prefix unless you think they are common.

Well works at least for maxim, dallas & different models like
ds1390, ds1374, so I figured I'd keep the bindings the same.

> 
> > +Example:
> > +   ds1374: rtc@0 {
> > +   compatible = "dallas,ds1374";
> > +   trickle-resistor-ohms = <250>;
> > +   reg = <0>;
> > +   };

Thanks,

Moritz

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

[rtc-linux] Re: [PATCH] rtc: ds1374: Add trickle charger device tree binding

2017-04-20 Thread Rob Herring 
On Mon, Apr 17, 2017 at 03:40:10PM -0700, Moritz Fischer wrote:
> Introduce a device tree binding for specifying the trickle charger
> configuration for ds1374. This is based on the code for ds13390.
> 
> Signed-off-by: Moritz Fischer 
> ---
>  .../devicetree/bindings/rtc/dallas,ds1374.txt  | 18 
>  drivers/rtc/rtc-ds1374.c   | 54 
> ++
>  2 files changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt 
> b/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> new file mode 100644
> index 000..4cf5bd7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> @@ -0,0 +1,18 @@
> +* Dallas DS1374  I2C Real-Time Clock / WDT

Please remove from trivial-devices.txt, too. (which is moving in 4.12 
BTW)

> +
> +Required properties:
> +- compatible: Should contain "dallas,ds1374".
> +- reg: I2C address for chip
> +
> +Optional properties:
> +- trickle-resistor-ohms : Selected resistor for trickle charger
> + Values usable for ds1374 are 250, 2000, 4000
> + Should be given if trickle charger should be enabled
> +- trickle-diode-disable : Do not use internal trickle charger diode
> + Should be given if internal trickle charger diode should be disabled

These should have vendor prefix unless you think they are common.

> +Example:
> + ds1374: rtc@0 {
> + compatible = "dallas,ds1374";
> + trickle-resistor-ohms = <250>;
> + reg = <0>;
> + };

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice

2017-04-20 Thread Enric Balletbo i Serra 
Lee,

On 11/04/17 11:48, Lee Jones wrote:
> On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote:
> 
>> From: Stephen Barber 
>>
>> If the EC supports RTC host commands, expose an RTC device.
> 
> This could be made nicer by checking RTC compatibility in the RTC
> driver.  So register it regardless, then check if the device is
> supported from within.  If it's not supported simply return -ENODEV
> from probe.
> 

Currently rtc-cros-ec and the other subdevices doesn't know how to check the
cros-ec MFD features, to do this I need to export cros_ec_check_features to a
public header and the rtc and other subdrivers should call the check function.

Seems to me more reasonable that the MFD checks the possible cells that can have
and only register the ones that really has (the cros-ec MFD can have different
cells depending on the device). Call every probe for all possible cells seems to
me a unnecessary step. The MFD is able to know which cells has, so IMHO then the
subdrivers are more independent of the MFD.

It's just an opinion so I'll let you the final decision.

Cheers,
 Enric

>> Signed-off-by: Stephen Barber 
>> Signed-off-by: Enric Balletbo i Serra 
>> ---
>>
>> Changes since v1:
>>  - Use PLATFORM_DEVID_AUTO to add the subdevice.
>>
>>  drivers/mfd/cros_ec.c | 18 ++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
>> index bbc17ab..76874be 100644
>> --- a/drivers/mfd/cros_ec.c
>> +++ b/drivers/mfd/cros_ec.c
>> @@ -51,6 +51,10 @@ static const struct mfd_cell ec_pd_cell = {
>>  .pdata_size = sizeof(pd_p),
>>  };
>>  
>> +static const struct mfd_cell ec_rtc_cell = {
>> +.name = "cros-ec-rtc",
>> +};
>> +
>>  static irqreturn_t ec_irq_thread(int irq, void *data)
>>  {
>>  struct cros_ec_device *ec_dev = data;
>> @@ -238,6 +242,16 @@ static void cros_ec_sensors_register(struct 
>> cros_ec_device *ec_dev)
>>  kfree(msg);
>>  }
>>  
>> +static void cros_ec_rtc_register(struct cros_ec_device *ec_dev)
>> +{
>> +int ret;
>> +
>> +ret = mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, _rtc_cell,
>> +  1, NULL, 0, NULL);
>> +if (ret)
>> +dev_err(ec_dev->dev, "failed to add EC RTC\n");
>> +}
>> +
>>  int cros_ec_register(struct cros_ec_device *ec_dev)
>>  {
>>  struct device *dev = ec_dev->dev;
>> @@ -287,6 +301,10 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
>>  if (cros_ec_check_features(ec_dev, EC_FEATURE_MOTION_SENSE))
>>  cros_ec_sensors_register(ec_dev);
>>  
>> +/* Check whether this EC has RTC support */
>> +if (cros_ec_check_features(ec_dev, EC_FEATURE_RTC))
>> +cros_ec_rtc_register(ec_dev);
>> +
>>  if (ec_dev->max_passthru) {
>>  /*
>>   * Register a PD device as well on top of this device.
> 

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH v2 2/5] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-04-20 Thread Enric Balletbo i Serra 


On 11/04/17 11:19, Lee Jones wrote:
> On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote:
> 
>> The cros_ec_dev driver should be used only to expose the Chrome OS Embedded
>> Controller to user-space and should not be used to add MFD devices by
>> calling mfd_add_devices. This patch moves this logic to the MFD cros_ec
>> driver and removes the MFD bits from the character device driver. Also
>> makes independent the IIO driver from the character device as also has no
>> sense.
>>
>> Signed-off-by: Enric Balletbo i Serra 
>> Acked-by: Jonathan Cameron 
>> ---
>>
>>   As pointed by Lee Jones in this thread [1] we should not use the MFD API
>> outside of MFD. For this reason the cros-ec-rtc did not get accepted yet.
>> The reality is that we are calling mfd_add_devices from cros-ec-dev driver
>> already, so this patch get rid off the MFD calls inside the chardev driver
>> and moves to cros-ec MFD. Also I think the chardev device should simply
>> implement the ioctl calls to access to it from userspace.
>>
>> Changes since v1:
>>  - Acked-by: Jonathan Cameron 
>>
>> [1]  https://www.spinics.net/lists/kernel/msg2465099.html
>>
>>  .../iio/common/cros_ec_sensors/cros_ec_sensors.c   |   8 -
>>  .../common/cros_ec_sensors/cros_ec_sensors_core.c  |   8 +-
>>  drivers/iio/light/cros_ec_light_prox.c |   8 -
>>  drivers/iio/pressure/cros_ec_baro.c|   8 -
>>  drivers/mfd/cros_ec.c  | 160 
>> 
>>  drivers/platform/chrome/cros_ec_dev.c  | 161 
>> -
> 
> Did you create this patch with "-M"?
> 

Oops, no, will do in next version

> This also requires a drivers/platform Ack.
> 

Olof, Benson, could one of you take a look at this and ack if you find this it
is ok, please?

Thanks,
 Enric


>>  include/linux/mfd/cros_ec.h|   6 +-
>>  7 files changed, 170 insertions(+), 189 deletions(-)
>>
>> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c 
>> b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
>> index 38e8783..9b53a01 100644
>> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
>> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
>> @@ -191,19 +191,11 @@ static const struct iio_info ec_sensors_info = {
>>  static int cros_ec_sensors_probe(struct platform_device *pdev)
>>  {
>>  struct device *dev = >dev;
>> -struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>> -struct cros_ec_device *ec_device;
>>  struct iio_dev *indio_dev;
>>  struct cros_ec_sensors_state *state;
>>  struct iio_chan_spec *channel;
>>  int ret, i;
>>  
>> -if (!ec_dev || !ec_dev->ec_dev) {
>> -dev_warn(>dev, "No CROS EC device found.\n");
>> -return -EINVAL;
>> -}
>> -ec_device = ec_dev->ec_dev;
>> -
>>  indio_dev = devm_iio_device_alloc(>dev, sizeof(*state));
>>  if (!indio_dev)
>>  return -ENOMEM;
>> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c 
>> b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
>> index 416cae5..0cdb64a 100644
>> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
>> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
>> @@ -41,12 +41,13 @@ int cros_ec_sensors_core_init(struct platform_device 
>> *pdev,
>>  {
>>  struct device *dev = >dev;
>>  struct cros_ec_sensors_core_state *state = iio_priv(indio_dev);
>> -struct cros_ec_dev *ec = dev_get_drvdata(pdev->dev.parent);
>> +struct cros_ec_device *ec_dev = dev_get_drvdata(pdev->dev.parent);
>>  struct cros_ec_sensor_platform *sensor_platform = dev_get_platdata(dev);
>>  
>>  platform_set_drvdata(pdev, indio_dev);
>>  
>> -state->ec = ec->ec_dev;
>> +state->ec = ec_dev;
>> +
>>  state->msg = devm_kzalloc(>dev,
>>  max((u16)sizeof(struct ec_params_motion_sense),
>>  state->ec->max_response), GFP_KERNEL);
>> @@ -59,7 +60,8 @@ int cros_ec_sensors_core_init(struct platform_device *pdev,
>>  
>>  /* Set up the host command structure. */
>>  state->msg->version = 2;
>> -state->msg->command = EC_CMD_MOTION_SENSE_CMD + ec->cmd_offset;
>> +state->msg->command = EC_CMD_MOTION_SENSE_CMD +
>> +sensor_platform->cmd_offset;
>>  state->msg->outsize = sizeof(struct ec_params_motion_sense);
>>  
>>  indio_dev->dev.parent = >dev;
>> diff --git a/drivers/iio/light/cros_ec_light_prox.c 
>> b/drivers/iio/light/cros_ec_light_prox.c
>> index 7217223..2133ddc 100644
>> --- a/drivers/iio/light/cros_ec_light_prox.c
>> +++ b/drivers/iio/light/cros_ec_light_prox.c
>> @@ -181,19 +181,11 @@ static const struct iio_info cros_ec_light_prox_info = 
>> {
>>  static int cros_ec_light_prox_probe(struct platform_device *pdev)
>>  {
>>  struct device *dev = >dev;
>> -struct cros_ec_dev *ec_dev