Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
On Feb 22, 2012, at 4:03 PM, Aaron Patterson wrote: Hi everyone, I just released the following Rails release candidates: * 3.2.2.rc1 * 3.1.4.rc1 * 3.0.12.rc1 Please give these releases a try! Make sure to report any regressions from the past release to the [ruby on rails core mailing list](http://groups.google.com/group/rubyonrails-core). If there are no show stopping regressions reported, I'll release the final versions on Monday. This is your opportunity to prevent me from releasing a version that breaks your app! Please use this opportunity! :-D It would be great to get this patch in: https://github.com/rails/rails/pull/4881 Does it count as a regression if ARes has *never* been able to parse the default Responder's error messages? --Matt Jones -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
Only concern I had is that, why did tenderlove has to do the release again? I thought we're going to rotate release person? :P -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
On Wed, Feb 22, 2012 at 07:45:52PM -0500, Ken Collins wrote: All green from the SQL Server adapter perspective :) Thanks for testing Ken! I appreciate it! 3 3 -- Aaron Patterson http://tenderlovemaking.com/ pgpNh9thTAGFv.pgp Description: PGP signature
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
On Thu, Feb 23, 2012 at 10:24:49AM -0600, Matt Jones wrote: On Feb 22, 2012, at 4:03 PM, Aaron Patterson wrote: Hi everyone, I just released the following Rails release candidates: * 3.2.2.rc1 * 3.1.4.rc1 * 3.0.12.rc1 Please give these releases a try! Make sure to report any regressions from the past release to the [ruby on rails core mailing list](http://groups.google.com/group/rubyonrails-core). If there are no show stopping regressions reported, I'll release the final versions on Monday. This is your opportunity to prevent me from releasing a version that breaks your app! Please use this opportunity! :-D It would be great to get this patch in: https://github.com/rails/rails/pull/4881 Does it count as a regression if ARes has *never* been able to parse the default Responder's error messages? If it never worked, it's not a regression. I'll backport this to 3-2-stable, but you'll have to wait for 3.2.3 before it's released. Sorry! -- Aaron Patterson http://tenderlovemaking.com/ pgp3TWZUPAKRR.pgp Description: PGP signature
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
On Thu, Feb 23, 2012 at 11:25:42AM -0500, Prem Sichanugrist wrote: Only concern I had is that, why did tenderlove has to do the release again? I thought we're going to rotate release person? :P Jon and Santiago have done releases. I'll take this one. Thanks for thinking about me though! :-D -- Aaron Patterson http://tenderlovemaking.com/ pgpiPo98LLelJ.pgp Description: PGP signature
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
The last release was not made by Xavier? -- Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca Sent with Sparrow (http://www.sparrowmailapp.com) On Thursday, 23 February, 2012 at 14:25, Prem Sichanugrist wrote: Only concern I had is that, why did tenderlove has to do the release again? I thought we're going to rotate release person? :P -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com (mailto:rubyonrails-core@googlegroups.com). To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com (mailto:rubyonrails-core+unsubscr...@googlegroups.com). For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
[Rails-core] Bug in nested_attributes_for: question about best way to patch
I've discovered what I'm pretty confident is unexpected behavior in
accepts_nested_attributes_for, and am developing a patch, but I've
encountered a question about how the core team would prefer the
implementation to look.
Here's the bug: when assigning to a belongs_to relationship (and I
believe one-to-one, but I haven't verified yet) if you mark the
association for destruction the association is not unset yet the
record is deleted. This result in both unexpected behavior: the
association seems to still be present in memory after the update, and
in invalid data being saved (foreign key violations) because the
parent record saved still has the association_id set even though the
associated record has been destroyed.
Here is a test demonstrating the error and the expectations:
def
test_should_destroy_an_existing_record_if_there_is_a_matching_id_and_destroy_is_truthy
@ship.pirate.destroy
[1, '1', true, 'true'].each do |truth|
pirate = @ship.reload.create_pirate(:catchphrase = 'Arr')
@ship.update_attributes(:pirate_attributes = { :id =
pirate.id, :_destroy = truth })
assert_raise(ActiveRecord::RecordNotFound) { pirate.reload }
end
end
I've also a partial patch developed: http://pastie.org/3438962
The problem is that to trigger the record deletion, the association
still needs to be there to be walked on the save call.
I have two question:
1. Does everyone agree on the expected behavior?
2. What is the best implementation route: should I maintain a hidden
list/hash on each object of associations that have been unset and
marked for deletion to use both at saving and if someone resets the
object? Or is that capability already essentially available in the
change tracking? Or something different all-together.
Something along these lines already has to be there because updating
the has_many leaves the collection in memory without the marked-for-
destruction records.
--
You received this message because you are subscribed to the Google Groups Ruby
on Rails: Core group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
On Thu, Feb 23, 2012 at 5:27 PM, Rafael Mendonça França rafaelmfra...@gmail.com wrote: The last release was not made by Xavier? Confirm, and 3.2.0 by David. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Re: [Rails-core] [ANN] Rails 3.2.2.rc1, 3.1.4.rc1, and 3.0.12.rc1 have been released!
I've also tested it (3.2.2.rc1) and everything is green :DD Oriol Gual On Thursday 23 de February de 2012 at 22:04, Xavier Noria wrote: On Thu, Feb 23, 2012 at 5:27 PM, Rafael Mendonça França rafaelmfra...@gmail.com (mailto:rafaelmfra...@gmail.com) wrote: The last release was not made by Xavier? Confirm, and 3.2.0 by David. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com (mailto:rubyonrails-core@googlegroups.com). To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com (mailto:rubyonrails-core+unsubscr...@googlegroups.com). For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
