Re: [Rails-core] Reducing ActionCable dependencies?

2016-01-07 Thread Daniel Searles 
Hey Mike,

I would love to follow along and help out anyway I can with this. I'm 
unsure how I can go about doing that as I am still getting my feet wet with 
developing on the Rails core.

- Daniel

On Tuesday, January 5, 2016 at 3:59:58 PM UTC-8, Rafael Mendonça França 
wrote:
>
> Mike,
>
> the Rails core already agreed that this would be the best direction but 
> nobody yet had time to work on this.
>
> If you want to work on this it would be awesome.
>
> Let us know if you need something from our side. If you want to discuss I 
> can invite you to our private Basecamp project.
>
>
>
> On Tue, Jan 5, 2016 at 9:55 PM Mike Perham  
> wrote:
>
>> I've noticed that Rails's gem dependency count has gone from 34 in 4.2.4 
>> to 55 in 5.0.beta1.  I think much of this is due to pulling in all of 
>> Celluloid and EventMachine via ActionCable.  I'd be interesting in working 
>> to minimize this footprint, perhaps by using concurrent-ruby's thread pools 
>> rather than celluloid actors.
>>
>> Is there any interest in me pursuing this work?  Has anyone else 
>> investigated in this direction?
>>
>> Mike
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to rubyonrails-co...@googlegroups.com .
>> To post to this group, send email to rubyonra...@googlegroups.com 
>> .
>> Visit this group at https://groups.google.com/group/rubyonrails-core.
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Re: [Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2016-01-07 Thread Prem Sichanugrist 
I think that might be a good idea. 

Do you mind creating an issue and ping @sikachu on it? Or, do you want to take 
a crack at it? I might be able to look at this tomorrow.

-Prem

> On Jan 7, 2016, at 11:23 AM, Markus D.  wrote:
> 
> +1 Would really ease transition to Rails 5 if I could write my tests the new 
> way already in Rails 4.
> 
> Am Freitag, 12. Juni 2015 04:10:33 UTC+2 schrieb Victor Costan:
> I'm trying to add Rails 5 support to an engine which (among other things) has 
> a generator for controller tests.
> 
> I've ran into the keyword arguments deprecation warning at the bottom of this 
> e-mail, and I'm in a bind now. If I use keyword arguments to get rid of the 
> warnings, I lose Rails 4 compatibility.
> 
> So far, I've managed to write tests that work in current Rails and previous 
> Rails, and I hope I'll be able to do that in the future. Is there any chance 
> that the keyword arguments will be backported to Rails 4 via a gem, like 
> strong_parameters were backported to Rails 3?
> 
> Thank you,
> Victor
> 
> 
> 
> DEPRECATION WARNING: ActionController::TestCase HTTP request methods will 
> accept only
> keyword arguments in future Rails versions.
> 
> Examples:
> 
> get :show, params: { id: 1 }, session: { user_id: 1 }
> process :update, method: :post, params: { id: 1 }
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Re: [Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2016-01-07 Thread Rafael Mendonça França 
I don't think it is necessary. You can still use the same syntax with Rails
4 and Rails 5, you will only see deprecations warnings, and I believe it is
acceptable in this case.

On Thu, Jan 7, 2016 at 4:33 PM Prem Sichanugrist 
wrote:

> I think that might be a good idea.
>
> Do you mind creating an issue and ping @sikachu on it? Or, do you want to
> take a crack at it? I might be able to look at this tomorrow.
>
> -Prem
>
> On Jan 7, 2016, at 11:23 AM, Markus D.  wrote:
>
> +1 Would really ease transition to Rails 5 if I could write my tests the
> new way already in Rails 4.
>
> Am Freitag, 12. Juni 2015 04:10:33 UTC+2 schrieb Victor Costan:
>>
>> I'm trying to add Rails 5 support to an engine which (among other things)
>> has a generator for controller tests.
>>
>> I've ran into the keyword arguments deprecation warning at the bottom of
>> this e-mail, and I'm in a bind now. If I use keyword arguments to get rid
>> of the warnings, I lose Rails 4 compatibility.
>>
>> So far, I've managed to write tests that work in current Rails and
>> previous Rails, and I hope I'll be able to do that in the future. Is there
>> any chance that the keyword arguments will be backported to Rails 4 via a
>> gem, like strong_parameters were backported to Rails 3?
>>
>> Thank you,
>> Victor
>>
>>
>>
>> DEPRECATION WARNING: ActionController::TestCase HTTP request methods will
>> accept only
>> keyword arguments in future Rails versions.
>>
>> Examples:
>>
>> get :show, params: { id: 1 }, session: { user_id: 1 }
>> process :update, method: :post, params: { id: 1 }
>>
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at https://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at https://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.