Re: [Rails-core] Payload names for 'sql.active_record' instrumentation

[Rafael Mendonça França]

Please do investigate, maybe there is no reason for that difference and we
would be really happy to merge a fix for this.
On Wed, Sep 13, 2017 at 5:57 PM Jeremy Green 
wrote:

> When I subscribe to sql.active_record, when a Post is loaded the payload
> name is "Post Load", which is great and seems to set a pattern on payload
> naming. Following that pattern:
>
>- When a Post is created I would expect the payload name to be "Post
>Create" (or something similar).
>- When a Post is updated I would expect the payload name to be "Post
>Update" (or something similar).
>- When a Post is deleted I would expect the payload name to be "Post
>Delete" (or something similar).
>
> Actual behavior is:
>
>
>- When a Post is created the payload name is "SQL".
>- When a Post is updated the payload name is "SQL".
>- When a Post is deleted the payload name is "SQL".
>
> Is there a reason for the difference? If not, would a patch to fix this be
> considered for merging?
>
> Cheers,
> Jeremy
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at https://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

[Rails-core] Payload names for 'sql.active_record' instrumentation

[Jeremy Green]

When I subscribe to sql.active_record, when a Post is loaded the payload 
name is "Post Load", which is great and seems to set a pattern on payload 
naming. Following that pattern:

   - When a Post is created I would expect the payload name to be "Post 
   Create" (or something similar).
   - When a Post is updated I would expect the payload name to be "Post 
   Update" (or something similar).
   - When a Post is deleted I would expect the payload name to be "Post 
   Delete" (or something similar).

Actual behavior is:


   - When a Post is created the payload name is "SQL".
   - When a Post is updated the payload name is "SQL".
   - When a Post is deleted the payload name is "SQL".

Is there a reason for the difference? If not, would a patch to fix this be 
considered for merging?

Cheers,
Jeremy


-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.