Re: [Rails-core] `to_key` return value
They need to return a unique value, not necessarily an array. This shouldn't affect them. Vipul A.M. +91-8149-204995 On Tue, Jan 20, 2015 at 2:14 AM, Matt Jones al2o...@gmail.com wrote: On Jan 17, 2015, at 6:10 AM, Vipul A M vipulnsw...@gmail.com wrote: `to_key` was first introduced in https://github.com/rails/rails/commit/9acd686753c43612984aaa4002e80113fda2b255 As far as I can tell, we have never actually needed to wrap the primary key in an array and don't have its use anywhere. Thoughts on changing this behaviour and just returning single primary field instead? The composite_primary_key user community probably have an opinion on this. They'd be stuck making workarounds to replace this: https://github.com/composite-primary-keys/composite_primary_keys/blob/7a519429600715f7140f3dcda5efe18c73976996/lib/composite_primary_keys/base.rb#L126 --Matt Jones -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
Re: [Rails-core] `to_key` return value
On Jan 17, 2015, at 6:10 AM, Vipul A M vipulnsw...@gmail.com wrote: `to_key` was first introduced in https://github.com/rails/rails/commit/9acd686753c43612984aaa4002e80113fda2b255 As far as I can tell, we have never actually needed to wrap the primary key in an array and don't have its use anywhere. Thoughts on changing this behaviour and just returning single primary field instead? The composite_primary_key user community probably have an opinion on this. They’d be stuck making workarounds to replace this: https://github.com/composite-primary-keys/composite_primary_keys/blob/7a519429600715f7140f3dcda5efe18c73976996/lib/composite_primary_keys/base.rb#L126 —Matt Jones -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout. signature.asc Description: Message signed with OpenPGP using GPGMail
[Rails-core] `to_key` return value
`to_key` was first introduced in https://github.com/rails/rails/commit/9acd686753c43612984aaa4002e80113fda2b255 As far as I can tell, we have never actually needed to wrap the primary key in an array and don't have its use anywhere. Thoughts on changing this behaviour and just returning single primary field instead? Thanks, -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
