Re: [Rails-core] Optional locale argument for pluralize helper

2015-07-07 Thread Rafael Mendonça França
:shipit:

On Tue, Jul 7, 2015 at 1:45 PM Stefan Daschek ste...@daschek.net wrote:

  Since Rails 4 it’ possible to use locale-specific pluralization rules by
 doing something like Produkt.pluralize(:de).

 Is there any reason why ActionView::Helpers::TextHelper#pluralize doesn’t
 accept an (optional) locale argument, too?

 Sample usage (in a view or helper):
 pluralize(Product.count, Produkt, locale: :de)

 As far as I can see, adding an optional keyword argument to
 https://github.com/rails/rails/blob/master/actionview/lib/action_view/helpers/text_helper.rb#L220
 shouldn’t be a problem regarding backwards compatibility.

 Should I prepare a pull request?

 Thanks,
 Stefan
 ​

 --
 You received this message because you are subscribed to the Google Groups
 Ruby on Rails: Core group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to rubyonrails-core+unsubscr...@googlegroups.com.
 To post to this group, send email to rubyonrails-core@googlegroups.com.
 Visit this group at http://groups.google.com/group/rubyonrails-core.
 For more options, visit https://groups.google.com/d/optout.


-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


[Rails-core] Optional locale argument for pluralize helper

2015-07-07 Thread Stefan Daschek
Since Rails 4 it’ possible to use locale-specific pluralization rules by 
doing something like |Produkt.pluralize(:de)|.


Is there any reason why ActionView::Helpers::TextHelper#pluralize 
doesn’t accept an (optional) locale argument, too?


Sample usage (in a view or helper):
|pluralize(Product.count, Produkt, locale: :de)|

As far as I can see, adding an optional keyword argument to 
https://github.com/rails/rails/blob/master/actionview/lib/action_view/helpers/text_helper.rb#L220 
shouldn’t be a problem regarding backwards compatibility.


Should I prepare a pull request?

Thanks,
Stefan

​

--
You received this message because you are subscribed to the Google Groups Ruby on 
Rails: Core group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.