Re: [sage-combinat-devel] Not able to use layout_graphviz

2010-11-27 Thread Nicolas M. Thiery
Hi Sébastien,

On Sat, Nov 27, 2010 at 11:33:49AM +0100, Nicolas M. Thiery wrote:
> > I am trying to use the graphviz functionalities you added in ticket
> > #7004. So, I installed graphviz and the dot2tex spkg as explained in
> > the documentation of layout_graphviz method, but I get the following
> > error when I use it :
> > 
> > sage: g = Graph({2:[3,4]})
> > sage: g.layout_graphviz()
> > Traceback (most recent call last):
> > ...
> > UnboundLocalError: local variable 'positions' referenced before assignment
> > 
> > Are you able to make this (or any) example to work? How should I use it?
> 
> I just checked with sage-4.6 vanilla, and it works. So it must be a
> further patch in the queue that breaks it (and it's most likely my
> fault). I'll check that out now. Thanks for the report!

That was indeed a typo in graph_edge_options-nt.patch. I had
apparently not run the tests with -optional, which gives yet another
proof that untested code is broken code.

Fixed and pushed. Thanks again for the report!

Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" 
http://Nicolas.Thiery.name/

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-de...@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.



Re: [sage-combinat-devel] Not able to use layout_graphviz

2010-11-27 Thread Nicolas M. Thiery
Salut!

On Fri, Nov 26, 2010 at 03:01:20PM -0500, Sébastien Labbé wrote:
> Salut Nicolas et Vincent,
> 
> I am trying to use the graphviz functionalities you added in ticket
> #7004. So, I installed graphviz and the dot2tex spkg as explained in
> the documentation of layout_graphviz method, but I get the following
> error when I use it :
> 
> sage: g = Graph({2:[3,4]})
> sage: g.layout_graphviz()
> Traceback (most recent call last):
> ...
> UnboundLocalError: local variable 'positions' referenced before assignment
> 
> Are you able to make this (or any) example to work? How should I use it?

I just checked with sage-4.6 vanilla, and it works. So it must be a
further patch in the queue that breaks it (and it's most likely my
fault). I'll check that out now. Thanks for the report!

Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" 
http://Nicolas.Thiery.name/

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-de...@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.



[sage-combinat-devel] Not able to use layout_graphviz

2010-11-26 Thread Sébastien Labbé
Salut Nicolas et Vincent,

I am trying to use the graphviz functionalities you added in ticket
#7004. So, I installed graphviz and the dot2tex spkg as explained in
the documentation of layout_graphviz method, but I get the following
error when I use it :

sage: g = Graph({2:[3,4]})
sage: g.layout_graphviz()
Traceback (most recent call last):
...
UnboundLocalError: local variable 'positions' referenced before assignment

Are you able to make this (or any) example to work? How should I use it?

Thank you,

Sébastien

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-de...@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.