[sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
I've only just seen this but it seems that I am the culprit as I was the one who modified #9265. Sorry! Nicolas, thanks for fixing the problem for me. Andrew -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/0S4P8rqy9t8J. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
Thanks, Nicolas -- the queue is now applying properly for me (on 5.4.beta1). cheers, Hugh -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/BpS9PJvI1OoJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
On Wed, Sep 26, 2012 at 01:45:35PM +0200, Nicolas M. Thiery wrote: > On Tue, Sep 25, 2012 at 07:51:10PM -0700, Hugh Thomas wrote: > >I just tried to install the combinat queue on 5.4.beta1, and got rejects > >on tableaux-combinatorics-am.patch. I think the issue is that 5.4.beta1 > >(and 5.4.beta0) have trac_9265_tableaux_categories_am merged, but not the > >most recent version of it. > > > >Since this patch is pretty near the end of the queue, for my purposes I > >can ignore the problem, but I thought I should report the issue. > > Ouch. Thanks for the report, I'll look into this. Fixed! (by reconstructing a small patch containing the difference between trac_9265_tableaux_categories_am.patch as merged in 5.4.beta0 and the final version of this patch). Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
Hi Jeroen! On Wed, Sep 26, 2012 at 04:42:23PM +0200, Jeroen Demeyer wrote: > Short story: for me it was far more important *that* the problem got > fixed, not *how* it got fixed. > > A situation where a ticket is merged but then problems are discovered is > a difficult situation to handle. In the past, I would have re-opened > the ticket and set it to needs_work but that seems to upset people (they > think it will postpone the merging of their patch). So this time, I > decided not to reopen the ticket but my intention was indeed for the > chances to be made on the same ticket. However, ideally it would have > been done in a separate additional patch, leaving the original > already-merged patch alone. But I certainly would have been happy also > with a new ticket. > > I have no idea how any of this affect sage-combinat. Thanks for the clarification! Thinking twice about it, a separate patch is also just fine for the Sage-Combinat queue. So let me take back my wording, and restate it as: ``In case a ticket is in a closed state, do *not* change the corresponding patches. Exception: sometimes the release manager may request a last minute change that: - can and should be implemented before the next official release - is trivial enough to not require unmerging the patch(es) and changing the status of the ticket to needs-work (typically a cosmetic change in the code) In such a case, you can either at your convenience: - Add an extra small patch implementing just that change - Or create a new ticket and do the change there In both cases, it should be done promptly.'' Cheers, Nicolas Anne: I forgot to thank you for your prompt implementation of Jeroen's request at #5457! -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
Short story: for me it was far more important *that* the problem got fixed, not *how* it got fixed. A situation where a ticket is merged but then problems are discovered is a difficult situation to handle. In the past, I would have re-opened the ticket and set it to needs_work but that seems to upset people (they think it will postpone the merging of their patch). So this time, I decided not to reopen the ticket but my intention was indeed for the chances to be made on the same ticket. However, ideally it would have been done in a separate additional patch, leaving the original already-merged patch alone. But I certainly would have been happy also with a new ticket. I have no idea how any of this affect sage-combinat. Jeroen. -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
I should perhaps mention that I think the problem I reported was due to a different ticket (but similar circumstances): trac_9265_tableaux_categories_am. (This is not relevant to the policy discussion, but might be relevant to restoring the queue to maximal sanity.) cheers, Hugh On Wednesday, September 26, 2012 7:27:36 AM UTC-7, Nicolas M. Thiery wrote: > > Hi Anne, Jeroen, > > On Wed, Sep 26, 2012 at 07:10:13AM -0700, Anne Schilling wrote: > > > Lesson to be learned: please everybody refrain from modifying a patch > > > in a ticket that is in the closed state; instead, create a new ticket! > > The merge manager forces us to do so. I do not think this is our > choice. > > Jeroen did not change the ticket status to "needs work" which I think > he would have if his intention was for the change to happen on that > ticket. This seems like more work for him (having to unmerge/remerge > the ticket) and for us (having Sage beta's with various versions of > the ticket merged in). > > Ok, I just asked for clarification on #5457. > > Cheers, > Nicolas > -- > Nicolas M. Thi�ry "Isil" > > http://Nicolas.Thiery.name/ > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/DFyMNpU6YCwJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
Hi Anne, Jeroen, On Wed, Sep 26, 2012 at 07:10:13AM -0700, Anne Schilling wrote: > > Lesson to be learned: please everybody refrain from modifying a patch > > in a ticket that is in the closed state; instead, create a new ticket! > The merge manager forces us to do so. I do not think this is our choice. Jeroen did not change the ticket status to "needs work" which I think he would have if his intention was for the change to happen on that ticket. This seems like more work for him (having to unmerge/remerge the ticket) and for us (having Sage beta's with various versions of the ticket merged in). Ok, I just asked for clarification on #5457. Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
On 9/26/12 4:45 AM, Nicolas M. Thiery wrote: > On Tue, Sep 25, 2012 at 07:51:10PM -0700, Hugh Thomas wrote: >>I just tried to install the combinat queue on 5.4.beta1, and got rejects >>on tableaux-combinatorics-am.patch. I think the issue is that 5.4.beta1 >>(and 5.4.beta0) have trac_9265_tableaux_categories_am merged, but not the >>most recent version of it. >> >>Since this patch is pretty near the end of the queue, for my purposes I >>can ignore the problem, but I thought I should report the issue. > > Ouch. Thanks for the report, I'll look into this. > > Lesson to be learned: please everybody refrain from modifying a patch > in a ticket that is in the closed state; instead, create a new ticket! The merge manager forces us to do so. I do not think this is our choice. Cheers, Anne -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
On Wed, Sep 26, 2012 at 7:45 AM, Nicolas M. Thiery wrote: > On Tue, Sep 25, 2012 at 07:51:10PM -0700, Hugh Thomas wrote: > >I just tried to install the combinat queue on 5.4.beta1, and got > rejects > >on tableaux-combinatorics-am.patch. I think the issue is that > 5.4.beta1 > >(and 5.4.beta0) have trac_9265_tableaux_categories_am merged, but not > the > >most recent version of it. > > > >Since this patch is pretty near the end of the queue, for my purposes > I > >can ignore the problem, but I thought I should report the issue. > > Ouch. Thanks for the report, I'll look into this. > > Lesson to be learned: please everybody refrain from modifying a patch > in a ticket that is in the closed state; instead, create a new ticket! > Does anyone know whether hg can prevent this (can we declare those patches read-only)? Franco -- -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
On Tue, Sep 25, 2012 at 07:51:10PM -0700, Hugh Thomas wrote: >I just tried to install the combinat queue on 5.4.beta1, and got rejects >on tableaux-combinatorics-am.patch. I think the issue is that 5.4.beta1 >(and 5.4.beta0) have trac_9265_tableaux_categories_am merged, but not the >most recent version of it. > >Since this patch is pretty near the end of the queue, for my purposes I >can ignore the problem, but I thought I should report the issue. Ouch. Thanks for the report, I'll look into this. Lesson to be learned: please everybody refrain from modifying a patch in a ticket that is in the closed state; instead, create a new ticket! Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Sage-Combinat queue working on 5.4.beta1
Hi! I just tried to install the combinat queue on 5.4.beta1, and got rejects on tableaux-combinatorics-am.patch. I think the issue is that 5.4.beta1 (and 5.4.beta0) have trac_9265_tableaux_categories_am merged, but not the most recent version of it. Since this patch is pretty near the end of the queue, for my purposes I can ignore the problem, but I thought I should report the issue. cheers, Hugh On Friday, September 21, 2012 2:03:16 AM UTC-7, Nicolas M. Thiery wrote: > > Dear Sage-Combinat devs, > > I just rebased the queue for 5.4.beta1. This boiled down to rebase, as > planned, the functorial construction patches on top of Valentin's > group algebra patch (#6654). I also had to remove a trivial white > space change from concrete_combinatorial_statistics_and_maps-cs.patch. > > Cheers, > Nicolas > -- > Nicolas M. Thi�ry "Isil" > > http://Nicolas.Thiery.name/ > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/YVzN9CwSMYcJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
