Re: [sage-combinat-devel] Re: strange convention for column words of (skew) tableaux

2016-11-29 Thread Anne Schilling
On 11/29/16 4:04 AM, Mike Zabrocki wrote:
> I agree that the two methods should not have the same name.
> My suggestion: deprecate one and call it 'to_word_by_column_reverse' 
> (although it seems weird to bother to include both).
> 
> Can SkewTableau inherit from Tableau and have 'to_word_by_column' there?

I would say the opposite: Tableau should inherit from SkewTableau since
every tableau is also a skew tableau, but not vice versa.

Anne

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-combinat-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-combinat-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-combinat-devel] Re: strange convention for column words of (skew) tableaux

2016-11-29 Thread Mike Zabrocki
I agree that the two methods should not have the same name.
My suggestion: deprecate one and call it 'to_word_by_column_reverse' 
(although it seems weird to bother to include both).

Can SkewTableau inherit from Tableau and have 'to_word_by_column' there?
-Mike

On Monday, 28 November 2016 19:05:48 UTC-5, Andrew wrote:
>
> Yes they should definitely be consistent -- sorry, I misread your email 
> and thought that you wanted the method for skew tableau to be the reverse 
> of that for tableauxnot enough coffee (or maybe too much:).
>
> As it currently stands there are many independent tableaux classes. 
> Ideally, methods like this should live in a common base class so 
> consistency is enforced and we don't re-implement them in each class.
>
> Andrew
>
> On Tuesday, 29 November 2016 09:33:52 UTC+11, Anne Schilling wrote:
>>
>> Hi Andrew, 
>>
>> If someone had just copied the code from Tableaux to SkewTableaux, 
>> then at least it would be consistent. I think it is really bad, 
>> if a method changes convention with a parent, given that one 
>> could be a subclass of the other. 
>>
>> Best, 
>>
>> Anne 
>>
>> On 11/28/16 1:23 PM, Andrew wrote: 
>> > Hi Anne, 
>> > 
>> > One of the problems with tableaux is that almost every possible 
>> variation of any definition is used by some one. With this in mind we 
>> probably should implement variations whenever possible. I don't 
>> > know anything about the history of this particular method (git blame 
>> might help), but I suspect that some one just copied the code from tableaux 
>> to skew tableaux. I certainly have no objection either 
>> > way as I don't use this method. 
>> > 
>> > Andrew 
>> > 
>> > On Tuesday, 29 November 2016 05:41:52 UTC+11, Anne Schilling wrote: 
>> > 
>> > Hi Combinat developers, 
>> > 
>> > Who came up with these conventions: 
>> > 
>> > sage: s=Tableau([[4,5],[6,7],[7],[8]]) 
>> > sage: s.to_word_by_column() 
>> > word: 876475 
>> > sage: s=SkewTableau([[4,5],[6,7],[7],[8]]) 
>> > sage: s.to_word_by_column() 
>> > word: 574678 
>> > 
>> > The column word of a skew tableau is the reverse of that 
>> > of a regular tableau. I think we should make the convention 
>> > the same (using the tableau convention!!!). 
>> > 
>> > What do you think? 
>> > 
>> > Anne 
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-combinat-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-combinat-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-combinat-devel] Re: strange convention for column words of (skew) tableaux

2016-11-28 Thread Anne Schilling
Hi Andrew,

If someone had just copied the code from Tableaux to SkewTableaux,
then at least it would be consistent. I think it is really bad,
if a method changes convention with a parent, given that one
could be a subclass of the other.

Best,

Anne

On 11/28/16 1:23 PM, Andrew wrote:
> Hi Anne,
> 
> One of the problems with tableaux is that almost every possible variation of 
> any definition is used by some one. With this in mind we probably should 
> implement variations whenever possible. I don't
> know anything about the history of this particular method (git blame might 
> help), but I suspect that some one just copied the code from tableaux to skew 
> tableaux. I certainly have no objection either
> way as I don't use this method.
> 
> Andrew
> 
> On Tuesday, 29 November 2016 05:41:52 UTC+11, Anne Schilling wrote:
> 
> Hi Combinat developers,
> 
> Who came up with these conventions:
> 
> sage: s=Tableau([[4,5],[6,7],[7],[8]])
> sage: s.to_word_by_column()
> word: 876475
> sage: s=SkewTableau([[4,5],[6,7],[7],[8]])
> sage: s.to_word_by_column()
> word: 574678
> 
> The column word of a skew tableau is the reverse of that
> of a regular tableau. I think we should make the convention
> the same (using the tableau convention!!!).
> 
> What do you think?
> 
> Anne

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-combinat-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-combinat-devel.
For more options, visit https://groups.google.com/d/optout.


[sage-combinat-devel] Re: strange convention for column words of (skew) tableaux

2016-11-28 Thread Andrew
Hi Anne,

One of the problems with tableaux is that almost every possible variation 
of any definition is used by some one. With this in mind we probably should 
implement variations whenever possible. I don't know anything about the 
history of this particular method (git blame might help), but I suspect 
that some one just copied the code from tableaux to skew tableaux. I 
certainly have no objection either way as I don't use this method.

Andrew

On Tuesday, 29 November 2016 05:41:52 UTC+11, Anne Schilling wrote:
>
> Hi Combinat developers, 
>
> Who came up with these conventions: 
>
> sage: s=Tableau([[4,5],[6,7],[7],[8]]) 
> sage: s.to_word_by_column() 
> word: 876475 
> sage: s=SkewTableau([[4,5],[6,7],[7],[8]]) 
> sage: s.to_word_by_column() 
> word: 574678 
>
> The column word of a skew tableau is the reverse of that 
> of a regular tableau. I think we should make the convention 
> the same (using the tableau convention!!!). 
>
> What do you think? 
>
> Anne 
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-combinat-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-combinat-devel.
For more options, visit https://groups.google.com/d/optout.