[sage-combinat-devel] Re: strange labeling of Dynkin nodes
On Fri, Aug 28, 2009 at 08:10:52AM -0700, Anne Schilling wrote: > Thank you for figuring out what the problem was!! However, did you > push your fix? With all patches applied, I still get the error > and on the patch server I cannot see that you pushed any changes > recently. That was my fourth blame. Fixed! Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
Hi Nicolas, Thank you for figuring out what the problem was!! However, did you push your fix? With all patches applied, I still get the error and on the patch server I cannot see that you pushed any changes recently. Cheers, Anne >> I just downloaded the 4.1.1 binary and ran ./sage -combinat install, >> so I should be working with a fresh version of everything. >> Nevertheless, I still get that the 2 node is connected to the 5 node >> in E7 when I run: >> >> C = CartanType(['E',7]) >> C.dynkin_diagram() > > Thanks. > >> However, when I do >> >> C.dynkin_diagram().show() >> >> then I see the 2 node connected to the 4 node! So, I guess the >> problem is probably in the terminal printing function? > > Definitely. > > And argl ... I take a tripe blame here: > > - First, I wrote the broken code (or more precisely broke Dan's code >while refactoring it) > > - Second, I forgot that multiplicity of spaces are ignored by sage -t. >Hence the tests I had put in type_E.py were not catching the bug. > > - Third I actually had not the 4326 patch applied on my machine, >which is why I could not reproduce the problem. > > I just pushed a fix. Thanks much for the report, and sorry for the > time it took. > > Cheers, > Nicolas --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
On Thu, Aug 27, 2009 at 11:57:57AM -0700, Brant Jones wrote: > I just downloaded the 4.1.1 binary and ran ./sage -combinat install, > so I should be working with a fresh version of everything. > Nevertheless, I still get that the 2 node is connected to the 5 node > in E7 when I run: > > C = CartanType(['E',7]) > C.dynkin_diagram() Thanks. > However, when I do > > C.dynkin_diagram().show() > > then I see the 2 node connected to the 4 node! So, I guess the > problem is probably in the terminal printing function? Definitely. And argl ... I take a tripe blame here: - First, I wrote the broken code (or more precisely broke Dan's code while refactoring it) - Second, I forgot that multiplicity of spaces are ignored by sage -t. Hence the tests I had put in type_E.py were not catching the bug. - Third I actually had not the 4326 patch applied on my machine, which is why I could not reproduce the problem. I just pushed a fix. Thanks much for the report, and sorry for the time it took. Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
Nicolas M. Thiery wrote: > On Wed, Aug 26, 2009 at 08:09:15AM -0700, Anne Schilling wrote: >> sage: DynkinDiagram(["E",7]).edges() >> >> [(1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), >> (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] >> sage: DynkinDiagram(["E",7,1]).edges() >> >> [(0, 1, 1), (1, 0, 1), (1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), >> (4, 2, 1), (4, 3, 1), (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), >> (6, 7, 1), (7, 6, 1)] >> >> So I suppose even in the finite Dynkin diagram 2 is attached to 4, is this >> right? > > Yes. So you can safely do your computations. It's only the printout > that is broken. That is at least reassuring! >> Ok, the offset is probably from e-mail, but I am using the command >> line and in the picture 2 is attached to 5 in the finite Dynkin >> diagram, but to 4 in the affine Dynkin diagram. > > Ok. > >>> Also, please run the tests on cartan_type.py and type_E.py. > > Ok, something is going really wrong with the sage-combinat install on > your machine (and Brant's). Those tests break horribly, whereas on my > machine they 100% pass with Sage 4.1 and 4.1.1 and all sage-combinat > patches applied. I can only guess that the update went somehow wrong. > > Could you try with 4.1.1? The tests pass now, but I still get the strange labeling for finite type in the printout: :/Applications/sage-4.1.1 anne$ ./sage -t devel/sage-combinat/sage/combinat/root_system/type_E.py sage -t "devel/sage-combinat/sage/combinat/root_system/type_E.py" [25.5 s] -- All tests passed! Total time for all tests: 25.5 seconds lolita-2:/Applications/sage-4.1.1 anne$ ./sage -t devel/sage-combinat/sage/combinat/root_system/cartan_type.py sage -t "devel/sage-combinat/sage/combinat/root_system/cartan_type.py" [23.9 s] -- All tests passed! Total time for all tests: 23.9 seconds lolita-2:/Applications/sage-4.1.1 anne$ ./sage -- | Sage Version 4.1.1, Release Date: 2009-08-14 | | Type notebook() for the GUI, and license() for information.| -- Loading Sage library. Current Mercurial branch is: combinat sage: DynkinDiagram(["E",7]) O 2 | | O---O---O---O---O---O 1 3 4 5 6 7 E7 sage: DynkinDiagram(["E",7,1]) O 2 | | O---O---O---O---O---O---O 0 1 3 4 5 6 7 E7~ > > On your 4.1 install, could you qpop -a, qpush -a, sage -b and try > again? This is without qpop -a etc. Perhaps the error message from yesterday was from the strange MacOX test behavior since I did it from the directory root_system yesterday? :/Applications/sage-4.1 anne$ ./sage -t devel/sage-combinat/sage/combinat/root_system/type_E.py sage -t "devel/sage-combinat/sage/combinat/root_system/type_E.py" [31.3 s] -- All tests passed! Total time for all tests: 31.3 seconds lolita-2:/Applications/sage-4.1 anne$ ./sage -t devel/sage-combinat/sage/combinat/root_system/cartan_type.py sage -t "devel/sage-combinat/sage/combinat/root_system/cartan_type.py" [24.9 s] -- All tests passed! Total time for all tests: 24.9 seconds Cheers, Anne --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
On Wed, Aug 26, 2009 at 08:09:15AM -0700, Anne Schilling wrote: > sage: DynkinDiagram(["E",7]).edges() > > [(1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), > (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] > sage: DynkinDiagram(["E",7,1]).edges() > > [(0, 1, 1), (1, 0, 1), (1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), > (4, 2, 1), (4, 3, 1), (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), > (6, 7, 1), (7, 6, 1)] > > So I suppose even in the finite Dynkin diagram 2 is attached to 4, is this > right? Yes. So you can safely do your computations. It's only the printout that is broken. > Ok, the offset is probably from e-mail, but I am using the command > line and in the picture 2 is attached to 5 in the finite Dynkin > diagram, but to 4 in the affine Dynkin diagram. Ok. > > Also, please run the tests on cartan_type.py and type_E.py. Ok, something is going really wrong with the sage-combinat install on your machine (and Brant's). Those tests break horribly, whereas on my machine they 100% pass with Sage 4.1 and 4.1.1 and all sage-combinat patches applied. I can only guess that the update went somehow wrong. Could you try with 4.1.1? On your 4.1 install, could you qpop -a, qpush -a, sage -b and try again? Cheers, Nicolas PS: Sorry for the slow answers; I don't yet have internet access at home, and I am spending quite some time there with Albane setting back everything before the girls come for school. -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
>> Perhaps I am going crazy, but I get: >> >> -- >> | Sage Version 4.1, Release Date: 2009-07-09 | >> | Type notebook() for the GUI, and license() for information.| >> -- >> Loading Sage library. Current Mercurial branch is: combinat >> sage: DynkinDiagram(["E",7,1]) >> >> O 2 >> | >> | >> O---O---O---O---O---O---O >> 0 1 3 4 5 6 7 >> E7~ >> sage: DynkinDiagram(["E",7]) >> >> O 2 >> | >> | >> O---O---O---O---O---O >> 1 3 4 5 6 7 >> E7 >> >> This is with all sage-combinat patches applied. What could be wrong? > > Hmm, hmm, hmm. Can you do: > > DynkinDiagram(["E",7]).edges() > DynkinDiagram(["E",7,1]).edges() sage: DynkinDiagram(["E",7]).edges() [(1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] sage: DynkinDiagram(["E",7,1]).edges() [(0, 1, 1), (1, 0, 1), (1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] So I suppose even in the finite Dynkin diagram 2 is attached to 4, is this right? > to see if it's only the drawing which is wrong (which I expect: to > start with, the "|" should be well aligned with the 4, which it is not > in your picture) or the graph itself. > > Is the copy-paste above in emacs? in the command line? in the notebook? Ok, the offset is probably from e-mail, but I am using the command line and in the picture 2 is attached to 5 in the finite Dynkin diagram, but to 4 in the affine Dynkin diagram. > Also, please run the tests on cartan_type.py and type_E.py. sage -t "4.1/devel/sage-combinat/sage/combinat/root_system/cartan_type.py" ** File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/cartan_type.py", line 182: sage: CartanType(['A',2],['B',2]) Exception raised: Traceback (most recent call last): File "/Applications/sage/local/bin/ncadoctest.py", line 1231, in run_one_test self.run_one_example(test, example, filename, compileflags) File "/Applications/sage/local/bin/sagedoctest.py", line 38, in run_one_example OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/Applications/sage/local/bin/ncadoctest.py", line 1172, in run_one_example compileflags, 1) in test.globs File "", line 1, in CartanType(['A',Integer(2)],['B',Integer(2)])###line 182: sage: CartanType(['A',2],['B',2]) File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/cartan_type.py", line 477, in __call__ return type_reducible.CartanType([ CartanType(subtype) for subtype in t ]) File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/type_reducible.py", line 44, in __init__ self.tools = root_system.type_reducible AttributeError: 'module' object has no attribute 'type_reducible' ** File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/cartan_type.py", line 184: sage: CartanType([['A',2],['B',2]]) Exception raised: Traceback (most recent call last): File "/Applications/sage/local/bin/ncadoctest.py", line 1231, in run_one_test self.run_one_example(test, example, filename, compileflags) File "/Applications/sage/local/bin/sagedoctest.py", line 38, in run_one_example OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/Applications/sage/local/bin/ncadoctest.py", line 1172, in run_one_example compileflags, 1) in test.globs File "", line 1, in CartanType([['A',Integer(2)],['B',Integer(2)]])###line 184: sage: CartanType([['A',2],['B',2]]) File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/cartan_type.py", line 477, in __call__ return type_reducible.CartanType([ CartanType(subtype) for subtype in t ]) File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/type_reducible.py", line 44, in __init__ self.tools = root_system.type_reducible AttributeError: 'module' object has no attribute 'type_reducible' ** File "/Applications/sage-4.1/devel/sage-combinat/sage/combinat/root_system/cartan_type.py", line 186: sage: CartanType(['A',2],['B',2]).is_reducible() Exception raised: Traceback (most recent call last): File "/Applications/sage/local/bin/ncadoctest.py", line 1231, in run_one_test self.r
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
On Wed, Aug 26, 2009 at 07:52:09AM -0700, Anne Schilling wrote: > > Hi Nicolas, > > Perhaps I am going crazy, but I get: > > -- > | Sage Version 4.1, Release Date: 2009-07-09 | > | Type notebook() for the GUI, and license() for information.| > -- > Loading Sage library. Current Mercurial branch is: combinat > sage: DynkinDiagram(["E",7,1]) > > O 2 > | > | > O---O---O---O---O---O---O > 0 1 3 4 5 6 7 > E7~ > sage: DynkinDiagram(["E",7]) > > O 2 > | > | > O---O---O---O---O---O > 1 3 4 5 6 7 > E7 > > This is with all sage-combinat patches applied. What could be wrong? Hmm, hmm, hmm. Can you do: DynkinDiagram(["E",7]).edges() DynkinDiagram(["E",7,1]).edges() to see if it's only the drawing which is wrong (which I expect: to start with, the "|" should be well aligned with the 4, which it is not in your picture) or the graph itself. Is the copy-paste above in emacs? in the command line? in the notebook? Also, please run the tests on cartan_type.py and type_E.py. Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
Hi Nicolas, Perhaps I am going crazy, but I get: -- | Sage Version 4.1, Release Date: 2009-07-09 | | Type notebook() for the GUI, and license() for information.| -- Loading Sage library. Current Mercurial branch is: combinat sage: DynkinDiagram(["E",7,1]) O 2 | | O---O---O---O---O---O---O 0 1 3 4 5 6 7 E7~ sage: DynkinDiagram(["E",7]) O 2 | | O---O---O---O---O---O 1 3 4 5 6 7 E7 This is with all sage-combinat patches applied. What could be wrong? Cheers, Anne >> The labeling of the Dynkin nodes for type E_7 in sage does not >> seem consistent with the labeling of the affine nodes: >> Should we fix this? It would make much more sense to attach node 2 >> in E_7 to node 4 instead of node 5. > > Err ??? > > I could not reproduce that. On my machine, everything is fine: > > sage: DynkinDiagram(["E",7,1]) > > O 2 > | > | > O---O---O---O---O---O---O > 0 1 3 4 5 6 7 > E7~ > sage: DynkinDiagram(["E",7]) > > O 2 > | > | > O---O---O---O---O---O > 1 3 4 5 6 7 > E7 > sage: DynkinDiagram(["E",7,1]).edges() > > [(0, 1, 1), (1, 0, 1), > (1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), (4, 5, 1), > (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] > sage: DynkinDiagram(["E",7]).edges() > > [(1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), (4, 5, 1), > (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] > > Besides, there is an automatic test for this line 1168 of cartan_type.py:: > > We check that :meth:`classical`, :meth:`.dynkin_diagram`, and > :meth:`.special_node` are consistent:: > > sage: for ct in CartanType.samples(affine = True): > ... g1 = ct.classical().dynkin_diagram() > ... g2 = ct.dynkin_diagram() > ... g2.delete_vertex(ct.special_node()) > ... assert sorted(g1.vertices()) == sorted(g2.vertices()) > ... assert sorted(g1.edges()) == sorted(g2.edges()) > > Cheers, > Nicolas > >> sage: CartanType(['E',7]).dynkin_diagram() >> >> O 2 >> | >> | >> O---O---O---O---O---O >> 1 3 4 5 6 7 >> E7 >> >> >> sage: CartanType(['E',7,1]).dynkin_diagram() >> >> O 2 >> | >> | >> O---O---O---O---O---O---O >> 0 1 3 4 5 6 7 >> E7~ >> >> >> For type E_6 things are consistent: >> >> >> sage: CartanType(['E',6]).dynkin_diagram() >> >> O 2 >> | >> | >> O---O---O---O---O >> 1 3 4 5 6 >> E6 >> sage: CartanType(['E',6,1]).dynkin_diagram() >> >> O 0 >> | >> | >> O 2 >> | >> | >> O---O---O---O---O >> 1 3 4 5 6 >> E6~ >> >> >> Anne >> >> Nicolas --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
[sage-combinat-devel] Re: strange labeling of Dynkin nodes
On Tue, Aug 25, 2009 at 04:26:54PM -0700, Anne Schilling wrote: > The labeling of the Dynkin nodes for type E_7 in sage does not > seem consistent with the labeling of the affine nodes: > Should we fix this? It would make much more sense to attach node 2 > in E_7 to node 4 instead of node 5. Err ??? I could not reproduce that. On my machine, everything is fine: sage: DynkinDiagram(["E",7,1]) O 2 | | O---O---O---O---O---O---O 0 1 3 4 5 6 7 E7~ sage: DynkinDiagram(["E",7]) O 2 | | O---O---O---O---O---O 1 3 4 5 6 7 E7 sage: DynkinDiagram(["E",7,1]).edges() [(0, 1, 1), (1, 0, 1), (1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] sage: DynkinDiagram(["E",7]).edges() [(1, 3, 1), (2, 4, 1), (3, 1, 1), (3, 4, 1), (4, 2, 1), (4, 3, 1), (4, 5, 1), (5, 4, 1), (5, 6, 1), (6, 5, 1), (6, 7, 1), (7, 6, 1)] Besides, there is an automatic test for this line 1168 of cartan_type.py:: We check that :meth:`classical`, :meth:`.dynkin_diagram`, and :meth:`.special_node` are consistent:: sage: for ct in CartanType.samples(affine = True): ... g1 = ct.classical().dynkin_diagram() ... g2 = ct.dynkin_diagram() ... g2.delete_vertex(ct.special_node()) ... assert sorted(g1.vertices()) == sorted(g2.vertices()) ... assert sorted(g1.edges()) == sorted(g2.edges()) Cheers, Nicolas > sage: CartanType(['E',7]).dynkin_diagram() > > O 2 > | > | > O---O---O---O---O---O > 1 3 4 5 6 7 > E7 > > > sage: CartanType(['E',7,1]).dynkin_diagram() > > O 2 > | > | > O---O---O---O---O---O---O > 0 1 3 4 5 6 7 > E7~ > > > For type E_6 things are consistent: > > > sage: CartanType(['E',6]).dynkin_diagram() > > O 2 > | > | > O---O---O---O---O > 1 3 4 5 6 > E6 > sage: CartanType(['E',6,1]).dynkin_diagram() > > O 0 > | > | > O 2 > | > | > O---O---O---O---O > 1 3 4 5 6 > E6~ > > > Anne > > Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~--~~~~--~~--~--~---
