Re: [sage-combinat-devel] Root systems do not define variables correctly

2012-07-13 Thread Nicolas M. Thiery
On Fri, Jul 13, 2012 at 08:07:48AM -0400, VulK wrote:
> I guess injecting simple roots would be my choice.

That could make sense since they are the generators. However I am not
sure what name to give them (they are indexed by 1,2,3). In this case,
I guess I'd rather implement inject_shorthands that would inject
respectively "s", "alpha", "alphacheck", ... for
L.simple_reflections(), L.simple_roots(), L.simple_coroots(), ...

> If not possible, at least, it would be cleaner to remove
> inject_variables from the auto completion list for A.

I agree: this method should ideally be lower in the class hierarchy
(it's in CategoryObject right now). If you find a lower class that
covers all current proper use cases, please create a ticket. I guess
Parent would be a good start even though it would not change anything
for root lattices. Otherwise, there could be a comment in the
documentation of CategoryObject.inject_shorthands stating that this
only works for parents whose generators have names that can be mapped
to Python identifiers. Feel free to proceed on that, after checking
whether there has been any discussion on sage-devel/trac recently
about inject_variables.

Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" 
http://Nicolas.Thiery.name/

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.



Re: [sage-combinat-devel] Root systems do not define variables correctly

2012-07-13 Thread VulK
Hi,
I guess injecting simple roots would be my choice.
If not possible, at least, it would be cleaner to remove inject_variables
from the auto completion list for A.
S.

* Nicolas M. Thiery  [2012-07-12 23:47:34]:

> On Thu, Jul 12, 2012 at 11:08:54PM -0400, VulK wrote:
> > I just noticed the following odd behaviour:
> > 
> > > sage: L=RootSystem(['A',2]).root_lattice()
> > > sage: L.inject_variables()
> > > ---
> > > ValueErrorTraceback (most recent call 
> > > last)
> > > ValueError: variable names have not yet been set using
> > 
> > I am running Sage Version 5.1, Release Date: 2012-07-09 with combinat queue
> > both compiled from sources today (I noticed the same behaviour on an old 4.8
> > install and I upgraded to check if had already been addressed).
> > I assume it will suffices to add _assign_names in the definition of
> > root_lattice but I did not have time to check it.
> 
> What would you want this method to do for root lattices?
> 
>   Nicolas
> --
> Nicolas M. Thiéry "Isil" 
> http://Nicolas.Thiery.name/
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sage-combinat-devel" group.
> To post to this group, send email to sage-combinat-devel@googlegroups.com.
> To unsubscribe from this group, send email to 
> sage-combinat-devel+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/sage-combinat-devel?hl=en.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.



Re: [sage-combinat-devel] Root systems do not define variables correctly

2012-07-12 Thread Nicolas M. Thiery
On Thu, Jul 12, 2012 at 11:08:54PM -0400, VulK wrote:
> I just noticed the following odd behaviour:
> 
> > sage: L=RootSystem(['A',2]).root_lattice()
> > sage: L.inject_variables()
> > ---
> > ValueErrorTraceback (most recent call last)
> > ValueError: variable names have not yet been set using
> 
> I am running Sage Version 5.1, Release Date: 2012-07-09 with combinat queue
> both compiled from sources today (I noticed the same behaviour on an old 4.8
> install and I upgraded to check if had already been addressed).
> I assume it will suffices to add _assign_names in the definition of
> root_lattice but I did not have time to check it.

What would you want this method to do for root lattices?

Nicolas
--
Nicolas M. Thiéry "Isil" 
http://Nicolas.Thiery.name/

-- 
You received this message because you are subscribed to the Google Groups 
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to 
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sage-combinat-devel?hl=en.