[sage-devel] Re: Proposal to add "tox" as a standard package - entry point for testing and linting

2020-09-09 Thread Matthias Koeppe 
On Monday, September 7, 2020 at 2:18:34 PM UTC-7, Matthias Koeppe wrote:
>
> tox (https://tox.readthedocs.io/en/latest/) is a popular package that is 
> used by a large number of Python projects as the standard entry point for 
> testing and linting.
> [...] 
>
I propose to make "tox" a standard package of the Sage distribution so that 
> this functionality becomes available by default.
>
> By convention, this requires a vote here on sage-devel.
>
>
Thanks everyone. This is now https://trac.sagemath.org/ticket/30416 
, needs review


-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/aacc76f1-ea5f-4f5b-aa1f-7b110c00c54co%40googlegroups.com.

[sage-devel] Policy proposal: spkg-configure.m4 script for all new standard Sage packages

2020-09-09 Thread John H Palmieri 
I have a Sage policy proposal:

- For any new standard Sage package PKG, we strongly recommend, require if 
at all possible, that the package comes with an spkg-configure.m4 script in 
build/pkgs/PKG. There should also be a directory build/pkgs/PKG/distros.

Neither the spkg-configure.m4 file nor the distros directory seems to be 
documented anywhere, so https://trac.sagemath.org/ticket/30543 adds 
documentation for these and also states this new "policy". (It's not really 
a policy, just a strong recommendation. Some packages are written 
explicitly for Sage or otherwise won't have good system replacements, so I 
don't think we should require it.)

If you approve, I would also request that you, as Sage developers, pay 
attention when you're reviewing tickets. If someone is proposing a new 
standard package, please keep this policy in mind.

-- 
John

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/681260ed-675f-4c70-b267-9226ddb29b22o%40googlegroups.com.

Re: [sage-devel] Policy proposal: spkg-configure.m4 script for all new standard Sage packages

2020-09-09 Thread Dima Pasechnik 
On Wed, Sep 9, 2020 at 10:40 PM John H Palmieri 
wrote:

> I have a Sage policy proposal:
>
> - For any new standard Sage package PKG, we strongly recommend, require if
> at all possible, that the package comes with an spkg-configure.m4 script in
> build/pkgs/PKG. There should also be a directory build/pkgs/PKG/distros.
>
> Neither the spkg-configure.m4 file nor the distros directory seems to be
> documented anywhere, so https://trac.sagemath.org/ticket/30543 adds
> documentation for these and also states this new "policy". (It's not really
> a policy, just a strong recommendation. Some packages are written
> explicitly for Sage or otherwise won't have good system replacements, so I
> don't think we should require it.)
>
> If you approve, I would also request that you, as Sage developers, pay
> attention when you're reviewing tickets. If someone is proposing a new
> standard package, please keep this policy in mind.
>

but this only makes sense for software installable by means of
`./configure+make` rather than with `pip`.



>
> --
> John
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/681260ed-675f-4c70-b267-9226ddb29b22o%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq1FNAQubtR2ZGtO_oBygZTPaGkutZQzm%3DsCMgjTE-Yxjw%40mail.gmail.com.

Re: [sage-devel] Policy proposal: spkg-configure.m4 script for all new standard Sage packages

2020-09-09 Thread Matthias Koeppe 
On Wednesday, September 9, 2020 at 2:44:00 PM UTC-7, Dima Pasechnik wrote:
>
>
> On Wed, Sep 9, 2020 at 10:40 PM John H Palmieri  > wrote:
>
>> I have a Sage policy proposal:
>>
>> - For any new standard Sage package PKG, we strongly recommend, require 
>> if at all possible, that the package comes with an spkg-configure.m4 script 
>> in build/pkgs/PKG. There should also be a directory build/pkgs/PKG/distros.
>>
>> Neither the spkg-configure.m4 file nor the distros directory seems to be 
>> documented anywhere, so https://trac.sagemath.org/ticket/30543 adds 
>> documentation for these and also states this new "policy". (It's not really 
>> a policy, just a strong recommendation. Some packages are written 
>> explicitly for Sage or otherwise won't have good system replacements, so I 
>> don't think we should require it.) [...]
>>
>
+1. Good idea to document this.
 

> but this only makes sense for software installable by means of 
> `./configure+make` rather than with `pip`.
>

It also makes sense for Python packages that are installed using "pip" but 
merely provide scripts and are not expected to be used within the same 
Python process as sagelib. Example: tox (added in 
https://trac.sagemath.org/ticket/30416), and the Jupyter notebook (
https://trac.sagemath.org/ticket/30124).  

(See discussion in the Meta-ticket regarding "spkg-configure", 
https://trac.sagemath.org/ticket/27330).


 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ef500340-b3bc-4381-a2ac-348404c9db88o%40googlegroups.com.

[sage-devel] Re: Beta 12 not building (Homebrew singular issue?)

2020-09-09 Thread Matthias Koeppe 
On Wednesday, September 9, 2020 at 6:49:36 PM UTC-7, Zachary Scherr wrote:
>
>I tried to build the most recent beta version of sage and it would 
> appear that it's taking issue with the fact that I have singular installed 
> on my Mac 10.15.6 through homebrew.  Homebrew's version is singular 4.1.3p2 
> and when I try to build sage I get errors like:
>
> "In file included from 
> build/cythonized/sage/rings/polynomial/plural.cpp:684:
> /usr/local/include/singular/Singular/libsingular.h:15:10: fatal error: 
> 'polys/shiftop.h' file not found
> #include "polys/shiftop.h"
>
>
Could you run the following please:
./sage -sh -c 'pkg-config --cflags singular'


-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/bc8bb997-5b27-4d2f-862e-89e2393e8cf8o%40googlegroups.com.

[sage-devel] Re: Beta 12 not building (Homebrew singular issue?)

2020-09-09 Thread Matthias Koeppe 
On Wednesday, September 9, 2020 at 7:57:18 PM UTC-7, Matthias Koeppe wrote:
>
> On Wednesday, September 9, 2020 at 6:49:36 PM UTC-7, Zachary Scherr wrote:
>>
>>I tried to build the most recent beta version of sage and it would 
>> appear that it's taking issue with the fact that I have singular installed 
>> on my Mac 10.15.6 through homebrew.  Homebrew's version is singular 4.1.3p2 
>> and when I try to build sage I get errors like:
>>
>> "In file included from 
>> build/cythonized/sage/rings/polynomial/plural.cpp:684:
>> /usr/local/include/singular/Singular/libsingular.h:15:10: fatal error: 
>> 'polys/shiftop.h' file not found
>> #include "polys/shiftop.h"
>>
>>
> Could you run the following please:
> ./sage -sh -c 'pkg-config --cflags singular'
>
>
Also could you post the output of "env"? 
(Do you use .homebrew-build-env to set environment variables?)

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/95ade090-5d5f-4ca4-8f02-96488db304b1o%40googlegroups.com.

[sage-devel] Re: Beta 12 not building (Homebrew singular issue?)

2020-09-09 Thread Zachary Scherr 
Hi Matthias,

   Running ./sage -sh -c 'pkg-config --cflags singular' with home-brew's 
singular installed gives:

-DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG 
-DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG 
-I/Users/zscherr/sage/develop/local/include/singular

my env is a mess, but I do source .homebrew-build-env, here is what I think 
are the relevant variables:

PATH=/usr/local/opt/gettext/bin:/Users/zscherr/perl5/bin:/usr/local/sbin:/usr/local/Cellar/modules/4.5.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/opt/X11/bin:/Library/Apple/usr/bin
PKG_CONFIG_PATH=/usr/local/opt/zlib/lib/pkgconfig:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig:/usr/local/opt/openblas/lib/pkgconfig:/usr/local/lib/pkgconfig:
LIBRARY_PATH=/usr/local/opt/gcc@9/lib/gcc/9:/usr/local/opt/readline/lib:/usr/local/lib
CPATH=/usr/local/opt/readline/include:/usr/local/include
ACLOCAL_PATH=/usr/local/opt/gettext/share/aclocal:

As expected, if I brew uninstall singular then running ./sage -sh -c 
'pkg-config --cflags singular' gives

-DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG 
-DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG 
-I/Users/zscherr/sage/develop/local/include/singular

I was able to build beta 11 so I can try to git bisect if you think that 
would be useful.




On Wednesday, September 9, 2020 at 11:04:16 PM UTC-4 Matthias Koeppe wrote:

> On Wednesday, September 9, 2020 at 7:57:18 PM UTC-7, Matthias Koeppe wrote:
>>
>> On Wednesday, September 9, 2020 at 6:49:36 PM UTC-7, Zachary Scherr wrote:
>>>
>>>I tried to build the most recent beta version of sage and it would 
>>> appear that it's taking issue with the fact that I have singular installed 
>>> on my Mac 10.15.6 through homebrew.  Homebrew's version is singular 4.1.3p2 
>>> and when I try to build sage I get errors like:
>>>
>>> "In file included from 
>>> build/cythonized/sage/rings/polynomial/plural.cpp:684:
>>> /usr/local/include/singular/Singular/libsingular.h:15:10: fatal error: 
>>> 'polys/shiftop.h' file not found
>>> #include "polys/shiftop.h"
>>>
>>>
>> Could you run the following please:
>> ./sage -sh -c 'pkg-config --cflags singular'
>>
>>
> Also could you post the output of "env"? 
> (Do you use .homebrew-build-env to set environment variables?)
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/4b970fb5-c11f-4c4e-8bac-cdfd38096f20n%40googlegroups.com.

[sage-devel] Re: Beta 12 not building (Homebrew singular issue?)

2020-09-09 Thread Matthias Koeppe 
You don't happen to set CFLAGS or CPPFLAGS by any chance? 

The problem in the failing compile command from your log is that 
"-I/Users/zscherr/sage/develop/local/include" appears after 
"-I/usr/local/include". It should appear before. 

gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common 
-dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot 
/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk 
-I/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include 
-I/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/Tk.framework/Versions/8.5/Headers
 
-I./sage/cpython -I/Users/zscherr/sage/develop/local/include/singular 
-I/Users/zscherr/sage/develop/build/pkgs/sagelib/src 
-I/Users/zscherr/sage/develop/build/pkgs/sagelib/src/sage/ext 
-I/usr/local/Cellar/python@3.8/3.8.5/Frameworks/Python.framework/Versions/3.8/include/python3.8
 
-I/Users/zscherr/sage/develop/local/lib/python3.8/site-packages/numpy/core/include
 
-Ibuild/cythonized -I/usr/local/include 
-I/usr/local/opt/openssl@1.1/include -I/usr/local/opt/sqlite/include 
-I/Users/zscherr/sage/develop/local/include 
-I/usr/local/Cellar/python@3.8/3.8.5/Frameworks/Python.framework/Versions/3.8/include/python3.8
 
-c 
build/cythonized/sage/algebras/letterplace/free_algebra_element_letterplace.cpp 
-o 
build/temp.macosx-10.15-x86_64-3.8/build/cythonized/sage/algebras/letterplace/free_algebra_element_letterplace.o
 
-fno-strict-aliasing -DCYTHON_CLINE_IN_TRACEBACK=1 -DSING_NDEBUG 
-DOM_NDEBUG -I/Users/zscherr/sage/develop/local/include/singular -std=c++11

On Wednesday, September 9, 2020 at 8:52:07 PM UTC-7, Zachary Scherr wrote:
>
>Running ./sage -sh -c 'pkg-config --cflags singular' with home-brew's 
> singular installed gives:
>
> -DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG 
> -DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG 
> -I/Users/zscherr/sage/develop/local/include/singular
>
> my env is a mess, but I do source .homebrew-build-env, here is what I 
> think are the relevant variables:
>
>
> PATH=/usr/local/opt/gettext/bin:/Users/zscherr/perl5/bin:/usr/local/sbin:/usr/local/Cellar/modules/4.5.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/opt/X11/bin:/Library/Apple/usr/bin
>
> PKG_CONFIG_PATH=/usr/local/opt/zlib/lib/pkgconfig:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig:/usr/local/opt/openblas/lib/pkgconfig:/usr/local/lib/pkgconfig:
>
> LIBRARY_PATH=/usr/local/opt/gcc@9/lib/gcc/9:/usr/local/opt/readline/lib:/usr/local/lib
> CPATH=/usr/local/opt/readline/include:/usr/local/include
> ACLOCAL_PATH=/usr/local/opt/gettext/share/aclocal:
>
> As expected, if I brew uninstall singular then running ./sage -sh -c 
> 'pkg-config --cflags singular' gives
>
> -DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG -DSING_NDEBUG 
> -DOM_NDEBUG -DSING_NDEBUG -DOM_NDEBUG 
> -I/Users/zscherr/sage/develop/local/include/singular
>
> I was able to build beta 11 so I can try to git bisect if you think that 
> would be useful.
>
>
>
>
> On Wednesday, September 9, 2020 at 11:04:16 PM UTC-4 Matthias Koeppe wrote:
>
>> On Wednesday, September 9, 2020 at 7:57:18 PM UTC-7, Matthias Koeppe 
>> wrote:
>>>
>>> On Wednesday, September 9, 2020 at 6:49:36 PM UTC-7, Zachary Scherr 
>>> wrote:

I tried to build the most recent beta version of sage and it would 
 appear that it's taking issue with the fact that I have singular installed 
 on my Mac 10.15.6 through homebrew.  Homebrew's version is singular 
 4.1.3p2 
 and when I try to build sage I get errors like:

 "In file included from 
 build/cythonized/sage/rings/polynomial/plural.cpp:684:
 /usr/local/include/singular/Singular/libsingular.h:15:10: fatal error: 
 'polys/shiftop.h' file not found
 #include "polys/shiftop.h"


>>> Could you run the following please:
>>> ./sage -sh -c 'pkg-config --cflags singular'
>>>
>>>
>> Also could you post the output of "env"? 
>> (Do you use .homebrew-build-env to set environment variables?)
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/cc37e026-8ba5-432d-87ed-a30e654137d0o%40googlegroups.com.