Re: [sage-devel] "Disputed" PRs: Please vote, it matters

[Kwankyu Lee]

These disputed PRs under voting need input from the sage community. 
I think the release manager should deal with a disputed PR that got 
"positive review" from voting separately and give at least a week or two 
before deciding on it (to merge). 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ccf6e114-db34-4f6b-9410-abaa91bb660an%40googlegroups.com.

Re: [sage-devel] "Disputed" PRs: Please vote, it matters

[David Roe]

I will echo Matthias here.  We just spent multiple months working out this
new process.  In order to make it work, people need to help make judgements
about which of these PRs should proceed and be included in Sage.

I understand that participating in these particular PRs can be daunting:
the people involved have strongly held opinions, many of the issues
involved are technical, and the comment history on some of these PRs is
very long.  I especially encourage those of you with substantial packaging
background to help resolve these PRs, but other developers are welcome to
participate in voting as well.
David

On Fri, Mar 15, 2024 at 10:42 PM Matthias Koeppe 
wrote:

> Dear all:
> Please take the time to participate in the voting process for the
> "disputed" PRs.
>
>
> https://github.com/sagemath/sage/pulls?q=is%3Aopen+label%3Adisputed+is%3Apr+label%3A%22s%3A+needs+review%22%2C%22s%3A+positive+review%22+sort%3Aupdated-desc
>
> Participation matters!
>
> Matthias
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/8934391b-e5a6-45cb-ab4f-713e8dfdd3f1n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAChs6_kw2m0nOnnkuX8A2YxeG9yy%2B9FbQTK75ASUxkYofTbxqw%40mail.gmail.com.

[sage-devel] "Disputed" PRs: Please vote, it matters

[Matthias Koeppe]

Dear all:
Please take the time to participate in the voting process for the 
"disputed" PRs.

https://github.com/sagemath/sage/pulls?q=is%3Aopen+label%3Adisputed+is%3Apr+label%3A%22s%3A+needs+review%22%2C%22s%3A+positive+review%22+sort%3Aupdated-desc

Participation matters!

Matthias

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/8934391b-e5a6-45cb-ab4f-713e8dfdd3f1n%40googlegroups.com.

Re: [sage-devel] Re: Help and Advice | Arithmetic of Jacobians in the Split/Real Model is Broken

[Giacomo Pope]

Back again with more class questions and general advice help

While getting all the old sage code into this new project, I realised there 
are places where we really rely on the underlying curve classes. One 
example is that we need

```
def dimension():
return 1
```

To avoid some crashes, but more generally we also need `rational_points()` 
which lives all the way inside `Algebraic_scheme`. There's also a whole 
bunch of other things...

I started exploring more and I found `Curve_generic` which we can create 
with the data I already have:

```
sage: H = HyperellipticCurveSmoothModel(x^5 + x + 1)
sage: C = Curve_generic(H._projective_model.ambient_space(), 
H._projective_model.defining_polynomials())
sage: type(C)

sage: C
Generic Curve over Rational Field defined by -X^5*Z - X*Z^5 - Z^6 + Y^2
sage: C.ambient_space()
2-d toric variety covered by 3 affine patches
```

this gets us some of the way and I think is an OK starting point, but then 
things like asking for the curve crash for weighted projective space:

```
sage: Curve(H)
---
TypeError Traceback (most recent call last)
.
TypeError: ambient space neither affine nor projective
```

and calls to things like C.rational_points() have more issues

```
sage: C.rational_points(bounds=2)
---
KeyError  Traceback (most recent call last)
.
AttributeError: 'SchemeHomset_points_subscheme_toric_field_with_category' 
object has no attribute 'points'
```

Which just goes to show that these toric varieties are a little 
underdeveloped.

Something which might be really nice would be 

```
class WeightedProjectiveCurve(Curve_generic, 
AlgebraicScheme_subscheme_toric):
```

Intended to mirror the similar:

```
class ProjectiveCurve(Curve_generic, AlgebraicScheme_subscheme_projective):
```

This could then be the class which is inherited by the Hyperelliptic curve 
class and we could aim for better coverage here.

Any opinions on this? Any idea of people who might have thought about or 
made progress in this area?

Otherwise, the project continues. Functions for finite fields are all 
working, generic functions mostly and the padic functions are a WIP as we 
need to adapt to the fact we have different points at infinity (and I dont 
know how to properly handle the case when there's two (yet)).

Finally, looking at the rational_points() method itself, this is something 
people have at least considered:

```
.. TODO::

Implement Stoll's model in weighted projective space to
resolve singularities and find two points (1 : 1 : 0) and
(-1 : 1 : 0) at infinity.
```


On Wednesday, March 13, 2024 at 6:23:38 PM UTC Giacomo Pope wrote:

> Thanks so much for the context
>
> Oh interesting. In this case I wonder whether we should work on and 
> include a new class (maybe something as simple as a WeightedProjectiveSpace 
> and a curve from this) mirroring the implementation for the plane curves. 
> Alternatively I could go into the old plane curve code and write these 
> useful functions specifically for the hyperelliptic curves (and here even 
> gain that these algorithms can be optimised). For example, I already had to 
> include a `dimension()` method on the curve to properly compute the 
> Jacobian. Potentially AlgebraicScheme_subscheme_toric is indeed the wrong 
> inheritance
>
> On Wednesday, March 13, 2024 at 6:18:12 PM UTC Nils Bruin wrote:
>
>> One thing that may deserve a cursory check is the overhead involved in 
>> inheriting from AlgebraicScheme_subscheme_toric class . Some parent 
>> structures are optimized for prolonged use *after* creation and may do a 
>> lot of caching/precomputation. There may be scenarios where one wants to 
>> construct *lots* of hyperelliptic curves (for instance, when computing 
>> reductions of hyperelliptic curves mod lots of primes). An expensive parent 
>> may then add undue overhead. In that case it may be better to spin off the 
>> functionality required into a "lightweight" structure that gets wrapped in 
>> the expensive, full functionality parent. After all, for core algorithms a 
>> hyperelliptic curve is just a 3*g+5 length sequence of ring/field elements: 
>> the coefficients of the defining equation.
>>
>> There are of course also odd genus hyperelliptic curves that cover a 
>> genus 0 curve that is not isomorphic to a P^1, but computing in their 
>> Jacobians has its own problems, so you should probably not try to include 
>> them in your current design.
>>
>> One thing that may be worthwhile: hyperelliptic curves do inherit some 
>> interesting functionality from plane curves (particularly via their affine 
>> patch) in the form of "riemann_surface". It may be worth keeping that, even 
>> if the particular code there could be expanded to work much more 
>> efficiently on 

[sage-devel] Re: Vote: Sage Code of Conduct

[Kwankyu Lee]

Congratulations!!!

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/f84bc17d-5765-4b87-9052-46371f2bfeeen%40googlegroups.com.

[sage-devel] Re: Vote: Sage Code of Conduct

[David Roe]

Hi all,
With 18 people voting there was a relevant tie.  The new committee is

Nils Bruin (nbr...@sfu.ca, nbruin on github) - sorry again for the earlier
misspelling!
J-P Labbé (jeanphilippela...@gmail.com, jplab on github)
John Palmieri (jhpalmier...@gmail.com, jhpalmieri on github)
Viviane Pons (vivianep...@gmail.com, VivianePons on github)
David Roe (roed.m...@gmail.com, roed314 on github)
Julian Rüth (julian.ru...@fsfe.org, saraedum on github)

Thank you to everyone for voting!

I also want to thank Vincent Delecroix, David Joyner, Harald Schilly, and
William Stein for their service on the committee up until this year.
David

On Thu, Mar 7, 2024 at 1:13 PM David Roe  wrote:

> Dear Sage developers,
> Thank you for those you nominated people for the committee following my
> request
> ,
> and thank you for those of you willing to serve.  The nominees are
>
> Nils Braun (nbr...@sfu.ca)
> J-P Labbé (jeanphilippela...@gmail.com, jplab on github)
> John Palmieri (jhpalmier...@gmail.com, jhpalmieri on github)
> Viviane Pons (vivianep...@gmail.com, VivianePons on github)
> David Roe (roed.m...@gmail.com, roed314 on github)
> Julian Rüth (julian.ru...@fsfe.org, saraedum on github)
> William Stein (wst...@gmail.com, williamstein on github)
> Yuan Zhou (xiaoyuan...@gmail.com, yuan-zhou on github)
>
> Please send votes to sage-cond...@googlegroups.com* by Thursday, March
> 14.  We are using approval voting
> , so you can vote
> for as many candidates as you like.  The committee will include at least
> the top 5 candidates, and will be enlarged to include all tied candidates
> if there is a tie for 5th place.  Note that you can choose to vote for more
> or less than 5 candidates if you like.
>
> Discussion of candidates is allowed (feel free to continue this thread),
> but please be respectful.  If you want to see the participation of these
> candidates in the Sage community, you can search by name on sage-devel
>  and on github
> .
>
> Thanks for voting,
> David
> for the Sage Code of Conduct Committee
>
> * We are replacing sage-ab...@googlegroups.com with
> sage-cond...@googlegroups.com; they currently have the same membership.
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAChs6_n7XCSxeFu2GAkhc%3DDWwTm4hT8u0k-cOuTBF84tEN8GMw%40mail.gmail.com.