Re: [sage-devel] Re: source code tarball?

2024-04-11 Thread Dima Pasechnik 
to be fixed by https://github.com/sagemath/sage/pull/37791
Please review.

Dima

On Wednesday, April 10, 2024 at 5:19:56 PM UTC+1 John Cremona wrote:

> Thanks, that's the page I was expecting.
>
> I think it would be a good idea to have that linked more obviously, but  I 
> am not able to make a PR right now.
>
> I found a tarball on GitHub on the releases page, so made progress, though 
> as I reported elsewhere I have not yet been able to build sage from it on 
> one machine.
>
> John
>
>
>
> On Wed, 10 Apr 2024, 15:24 julian...@fsfe.org,  wrote:
>
>> I guess the idea is that further down on this page, you are told to 
>> follow the instructions in the README here 
>> https://github.com/sagemath/sage/#readme which in turn tells you get the 
>> "sources" from here https://www.sagemath.org/download-source.html.
>>
>> I agree that this is not terribly intuitive, however, the wikipedia link 
>> was introduced in
>>
>> commit 5cddc06a8118d8fb9211fe8232b1183daba9f01f
>> Date:   Tue Mar 29 15:11:07 2011 +0100
>>
>> So it's been there for quite a while but certainly the surroundings have 
>> been modified quite a bit since then.
>>
>> If you want to create a PR to change that link, I am happy to give it 
>> positive review.
>>
>> julian
>>
>> On Wednesday, April 10, 2024 at 11:56:23 AM UTC+3 John Cremona wrote:
>>
>>> In the first line of 
>>> https://doc.sagemath.org/html/en/installation/source.html#sec-installation-from-sources
>>>  
>>> the words "source code" are a link to the wikipedia page for "source code", 
>>> which is not very helpful.  I was expecting it to be a link to page shoing 
>>> where to download a tarball.  I sometimes use the tarball to install from 
>>> source, instead of using a git clone -- I assume that has not been 
>>> discontinued?
>>>
>>> John
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to sage-devel+...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/sage-devel/52db9220-62b4-4fc5-ac5a-f77bd040a9b7n%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/b52110d7-408b-40f6-8401-c526d0261d93n%40googlegroups.com.

Re: [sage-devel] SEGV caused by CTL-C in C/C++ code probably related to signals

2024-04-11 Thread dimpase 
On Thu, Apr 11, 2024 at 03:30:34PM +0300, Georgi Guninski wrote:
> Are the non-crashing codepaths in consistent state?
> SEGV is in general sign of memory corruption and it may lead to wrong
> math results or possibly have security implications.

Here is an attempt to fix it; it appears that the call to
characteristic() which causes a crash is a leftover which can simply be
removed.
https://github.com/dimpase/sage/pull/6
(not yet a PR to the Sage repo, just want to see results of tests)

Dima

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ZhhTnNiy9fsLjcVJ%40hilbert.homenet.telecomitalia.it.


signature.asc
Description: PGP signature

Re: [sage-devel] Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-04-11 Thread Matthias Koeppe 
I will not respond further on this in this thread.

On Thursday, April 11, 2024 at 1:15:52 PM UTC-7 Dima Pasechnik wrote:

>
>
> On 11 April 2024 21:47:57 CEST, Matthias Koeppe  
> wrote:
> >Once again, the workflow files in .github/workflows have to be statically 
> >present in a repository so that Actions work.
> >And the .devcontainers files have to be statically present in a 
> repository 
> >so that Codespaces work. 
>
> Yes, sure, as I said, you can have it statically present, and test a 
> submodule containing sagelib from there.
>
> There is nothing hard to design here, once you split the repo this way.
>
>
> >
> >If you want to propose a design for breaking our repository into multiple 
> >repositories, work it out first. Learn about the relevant technological 
> >restrictions. 
> >It does not make sense to develop it here in a question-and-answer game. 
> >In particular, this cannot be done here in this thread about governance; 
> >it's only a distraction.
> >
> >Matthias
> >
> >
> >On Thursday, April 11, 2024 at 12:36:20 PM UTC-7 Dima Pasechnik wrote:
> >
> >On 11 April 2024 18:06:42 CEST, Matthias Koeppe  
> >wrote: 
> >>On Thursday, April 11, 2024 at 4:28:12 AM UTC-7 dim...@gmail.com wrote: 
> >> 
> >>On Wed, Apr 10, 2024 at 04:23:13PM -0700, Matthias Koeppe wrote: 
> >>> On Wednesday, April 10, 2024 at 3:25:16 PM UTC-7 Dima Pasechnik wrote: 
> >>> Necessary reminder that we're discussing, as the subject says, the 
> files 
> >>> that control the GitHub workflows and the Codespaces. 
> >>> What a developer may do on their local machine does not matter. 
> >> 
> >>But there is no difference here between a CI and a local machine here. 
> >>A CI is perfectly capable of doing 
> >>"git submodule update --remote" 
> >>and proceed. 
> >> 
> >> 
> >>No. These files are processed by GitHub before any custom code can be 
> run. 
> >
> >Are you saying that "git submodule..." cannot be triggered by 
> >repository_dispatch hook? 
> >So GH Actions cannot be triggered by a submodule update? 
> >
> >
> >
> >> 
> >
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/e49e8408-c44b-4179-8867-3c13e7a79e82n%40googlegroups.com.

Re: [sage-devel] Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-04-11 Thread Dima Pasechnik 



On 11 April 2024 21:47:57 CEST, Matthias Koeppe  
wrote:
>Once again, the workflow files in .github/workflows have to be statically 
>present in a repository so that Actions work.
>And the .devcontainers files have to be statically present in a repository 
>so that Codespaces work. 

Yes, sure, as I said, you can have it statically present, and test a submodule 
containing sagelib from there.

There is nothing hard to design here, once you split the repo this way.


>
>If you want to propose a design for breaking our repository into multiple 
>repositories, work it out first. Learn about the relevant technological 
>restrictions. 
>It does not make sense to develop it here in a question-and-answer game. 
>In particular, this cannot be done here in this thread about governance; 
>it's only a distraction.
>
>Matthias
>
>
>On Thursday, April 11, 2024 at 12:36:20 PM UTC-7 Dima Pasechnik wrote:
>
>On 11 April 2024 18:06:42 CEST, Matthias Koeppe  
>wrote: 
>>On Thursday, April 11, 2024 at 4:28:12 AM UTC-7 dim...@gmail.com wrote: 
>> 
>>On Wed, Apr 10, 2024 at 04:23:13PM -0700, Matthias Koeppe wrote: 
>>> On Wednesday, April 10, 2024 at 3:25:16 PM UTC-7 Dima Pasechnik wrote: 
>>> Necessary reminder that we're discussing, as the subject says, the files 
>>> that control the GitHub workflows and the Codespaces. 
>>> What a developer may do on their local machine does not matter. 
>> 
>>But there is no difference here between a CI and a local machine here. 
>>A CI is perfectly capable of doing 
>>"git submodule update --remote" 
>>and proceed. 
>> 
>> 
>>No. These files are processed by GitHub before any custom code can be run. 
>
>Are you saying that "git submodule..." cannot be triggered by 
>repository_dispatch hook? 
>So GH Actions cannot be triggered by a submodule update? 
>
>
>
>> 
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/A3395AC1-7AE8-436A-B1AE-B864F5E79BA8%40gmail.com.

Re: [sage-devel] Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-04-11 Thread Matthias Koeppe 
Once again, the workflow files in .github/workflows have to be statically 
present in a repository so that Actions work.
And the .devcontainers files have to be statically present in a repository 
so that Codespaces work. 

If you want to propose a design for breaking our repository into multiple 
repositories, work it out first. Learn about the relevant technological 
restrictions. 
It does not make sense to develop it here in a question-and-answer game. 
In particular, this cannot be done here in this thread about governance; 
it's only a distraction.

Matthias


On Thursday, April 11, 2024 at 12:36:20 PM UTC-7 Dima Pasechnik wrote:

On 11 April 2024 18:06:42 CEST, Matthias Koeppe  
wrote: 
>On Thursday, April 11, 2024 at 4:28:12 AM UTC-7 dim...@gmail.com wrote: 
> 
>On Wed, Apr 10, 2024 at 04:23:13PM -0700, Matthias Koeppe wrote: 
>> On Wednesday, April 10, 2024 at 3:25:16 PM UTC-7 Dima Pasechnik wrote: 
>> Necessary reminder that we're discussing, as the subject says, the files 
>> that control the GitHub workflows and the Codespaces. 
>> What a developer may do on their local machine does not matter. 
> 
>But there is no difference here between a CI and a local machine here. 
>A CI is perfectly capable of doing 
>"git submodule update --remote" 
>and proceed. 
> 
> 
>No. These files are processed by GitHub before any custom code can be run. 

Are you saying that "git submodule..." cannot be triggered by 
repository_dispatch hook? 
So GH Actions cannot be triggered by a submodule update? 



> 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ccfbffb1-4989-4be4-bcbb-b2680f7394ean%40googlegroups.com.

Re: [sage-devel] Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-04-11 Thread Dima Pasechnik 



On 11 April 2024 18:06:42 CEST, Matthias Koeppe  
wrote:
>On Thursday, April 11, 2024 at 4:28:12 AM UTC-7 dim...@gmail.com wrote:
>
>On Wed, Apr 10, 2024 at 04:23:13PM -0700, Matthias Koeppe wrote: 
>> On Wednesday, April 10, 2024 at 3:25:16 PM UTC-7 Dima Pasechnik wrote: 
>> Necessary reminder that we're discussing, as the subject says, the files 
>> that control the GitHub workflows and the Codespaces. 
>> What a developer may do on their local machine does not matter. 
>
>But there is no difference here between a CI and a local machine here. 
>A CI is perfectly capable of doing 
>"git submodule update --remote" 
>and proceed.
>
>
>No. These files are processed by GitHub before any custom code can be run.

Are you saying that "git submodule..." cannot be triggered by 
repository_dispatch hook?
So GH Actions cannot be triggered by a submodule update?



>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/D6F9CBA3-4EF6-430C-A534-46B7514CD975%40gmail.com.

Re: [sage-devel] Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-04-11 Thread Matthias Koeppe 
On Thursday, April 11, 2024 at 4:28:12 AM UTC-7 dim...@gmail.com wrote:

On Wed, Apr 10, 2024 at 04:23:13PM -0700, Matthias Koeppe wrote: 
> On Wednesday, April 10, 2024 at 3:25:16 PM UTC-7 Dima Pasechnik wrote: 
> Necessary reminder that we're discussing, as the subject says, the files 
> that control the GitHub workflows and the Codespaces. 
> What a developer may do on their local machine does not matter. 

But there is no difference here between a CI and a local machine here. 
A CI is perfectly capable of doing 
"git submodule update --remote" 
and proceed.


No. These files are processed by GitHub before any custom code can be run.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/7c04399f-9b63-4bb1-a7ca-4ac0687dc776n%40googlegroups.com.

Re: [sage-devel] SEGV caused by CTL-C in C/C++ code probably related to signals

2024-04-11 Thread Georgi Guninski 
Are the non-crashing codepaths in consistent state?
SEGV is in general sign of memory corruption and it may lead to wrong
math results or possibly have security implications.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAGUWgD-WWBUq7dyA-SWYrm761fKcQBe%3DRNkR_GL%3DxqZF%2BNveLA%40mail.gmail.com.

Re: [sage-devel] SEGV caused by CTL-C in C/C++ code probably related to signals

2024-04-11 Thread dimpase 
On Thu, Apr 11, 2024 at 09:27:15AM +0300, Georgi Guninski wrote:
> Giving short testcase, can someone else reproduce it?
> Also attaching backtrace.

yes, I can reproduce this on a recent 10.4.beta - the backtrace I get it
more or less the same as the one attached - and it's in an unexpected to
me place, in src/sage/rings/finite_rings/integer_mod_ring.py.
If I read the backtrace right, 
sa2si_ZZmod() - in Cython interface to Singular  -
is called from Python code, then sa2si_ZZmod() calls characteristic() in the 
line

nr2mModul = d.parent().characteristic()

As sa2si_ZZmod() is declared noexcept(), we see

Exception ignored in: 'sage.libs.singular.singular.sa2si_ZZmod'

But then in characteristic() an attempt to handle the exception is made,
and it leads to a crash. Should 

nr2mModul = d.parent().characteristic()

be wrapped in some cysignals functions, or we currently just have to
means to deal with it?



KeyboardInterrupt:
sage: x,y=var('x,y');n=10**6
: while True:  so=solve_mod(x*y-1,n)
^C---
KeyboardInterrupt Traceback (most recent call last)
File 
/mnt/opt/Sage/sage-dev/src/sage/rings/finite_rings/integer_mod_ring.py:1029, in 
IntegerModRing_generic.characteristic(self)
   1025 ans.append(Factorization([(p, e - 1)]) *
   1026factor(p - 1, int_=(self.__order < 2**31)))
   1027 return ans
-> 1029 def characteristic(self):
   1030 """
   1031 EXAMPLES::
   1032
   (...)
   1038 18
   1039 """
   1040 return self.__order

File src/cysignals/signals.pyx:341, in 
cysignals.signals.python_check_interrupt()

KeyboardInterrupt:
Exception ignored in: 'sage.libs.singular.singular.sa2si_ZZmod'
Traceback (most recent call last):
  File 
"/mnt/opt/Sage/sage-dev/src/sage/rings/finite_rings/integer_mod_ring.py", line 
1029, in characteristic
def characteristic(self):

  File "src/cysignals/signals.pyx", line 341, in 
cysignals.signals.python_check_interrupt
KeyboardInterrupt:

/usr/lib/python3.11/site-packages/cysignals/signals.cpython-311-x86_64-linux-gnu.so(+0x9beb)[0x7f0fea9a6beb]
/usr/lib/python3.11/site-packages/cysignals/signals.cpython-311-x86_64-linux-gnu.so(+0x9caf)[0x7f0fea9a6caf]
/usr/lib/python3.11/site-packages/cysignals/signals.cpython-311-x86_64-linux-gnu.so(+0xb7d0)[0x7f0fea9a87d0]
/lib64/libc.so.6(+0x39660)[0x7f0ff85a0660]
/usr/lib64/libgmp.so.10(__gmpz_cmp_ui+0x0)[0x7f0fe9b96a20]
/usr/lib64/libpolys-4.3.2.so(+0xf9dce)[0x7f0e9ceb1dce]
/mnt/opt/Sage/sage-dev/src/sage/libs/singular/polynomial.cpython-311-x86_64-linux-gnu.so(+0x7427)[0x7f0e9d22d427]
/mnt/opt/Sage/sage-dev/src/sage/rings/polynomial/multi_polynomial_libsingular.cpython-311-x86_64-linux-gnu.so(+0x4c072)[0x7f0e9d284072]
/mnt/opt/Sage/sage-dev/src/sage/rings/polynomial/multi_polynomial_libsingular.cpython-311-x86_64-linux-gnu.so(+0x4c908)[0x7f0e9d284908]
/usr/lib64/libpython3.11.so.1.0(+0x1acf22)[0x7f0ff88d1f22]
/mnt/opt/Sage/sage-dev/src/sage/rings/polynomial/polynomial_element.cpython-311-x86_64-linux-gnu.so(+0x2d6ea)[0x7f0fa1bb16ea]
/mnt/opt/Sage/sage-dev/src/sage/rings/polynomial/polynomial_element.cpython-311-x86_64-linux-gnu.so(+0x2dc8d)[0x7f0fa1bb1c8d]
/usr/lib64/libpython3.11.so.1.0(+0x1acf22)[0x7f0ff88d1f22]
/mnt/opt/Sage/sage-dev/src/sage/categories/map.cpython-311-x86_64-linux-gnu.so(+0x13db0)[0x7f0fe93e8db0]
/mnt/opt/Sage/sage-dev/src/sage/structure/parent.cpython-311-x86_64-linux-gnu.so(+0x2dbb9)[0x7f0fe9445bb9]
/mnt/opt/Sage/sage-dev/src/sage/rings/polynomial/multi_polynomial_libsingular.cpython-311-x86_64-linux-gnu.so(+0x6fe67)[0x7f0e9d2a7e67]
/usr/lib64/libpython3.11.so.1.0(_PyObject_Call+0x68)[0x7f0ff887fa28]
/usr/lib64/libpython3.11.so.1.0(_PyEval_EvalFrameDefault+0x57e3)[0x7f0ff8825613]
/usr/lib64/libpython3.11.so.1.0(+0x1741f5)[0x7f0ff88991f5]
/usr/lib64/libpython3.11.so.1.0(+0x252600)[0x7f0ff8977600]
/usr/lib64/libpython3.11.so.1.0(_PyEval_EvalFrameDefault+0x6daf)[0x7f0ff8826bdf]
/usr/lib64/libpython3.11.so.1.0(+0x1741f5)[0x7f0ff88991f5]
/usr/lib64/libpython3.11.so.1.0(+0x186381)[0x7f0ff88ab381]
/usr/lib64/libpython3.11.so.1.0(+0x1867cc)[0x7f0ff88ab7cc]
/usr/lib64/libpython3.11.so.1.0(_PyEval_EvalFrameDefault+0x7034)[0x7f0ff8826e64]
/usr/lib64/libpython3.11.so.1.0(PyEval_EvalCode+0x22c)[0x7f0ff897fecc]
/usr/lib64/libpython3.11.so.1.0(+0x255b50)[0x7f0ff897ab50]
/usr/lib64/libpython3.11.so.1.0(_PyEval_EvalFrameDefault+0x699d)[0x7f0ff88267cd]
/usr/lib64/libpython3.11.so.1.0(+0x1738dd)[0x7f0ff88988dd]
/usr/lib64/libpython3.11.so.1.0(_PyEval_EvalFrameDefault+0xa61d)[0x7f0ff882a44d]
/usr/lib64/libpython3.11.so.1.0(+0x1738dd)[0x7f0ff88988dd]
/usr/lib64/libpython3.11.so.1.0(_PyEval_EvalFrameDefault+0xa61d)[0x7f0ff882a44d]
/usr/lib64/libpython3.11.so.1.0(+0x174a95)[0x7f0ff8899a95]
/usr

Re: [sage-devel] Governance proposal: Maintainer/code-owner model for .ci, .devcontainer, .github/workflows, tox.ini

2024-04-11 Thread dimpase 
On Wed, Apr 10, 2024 at 04:23:13PM -0700, Matthias Koeppe wrote:
> On Wednesday, April 10, 2024 at 3:25:16 PM UTC-7 Dima Pasechnik wrote:
> 
> On Wed, Apr 10, 2024 at 11:10 PM Matthias Koeppe  
> wrote:
> 
> On Wednesday, April 10, 2024 at 2:40:18 PM UTC-7 Dima Pasechnik wrote:
> 
> There is simply no need to keep the .gitsubmodules -
> 
> the only file in the main repo affected by "git submodule update --remote" 
> - 
> always synchronized, commit-wise, for everyone.
> 
> 
> There is. Without doing that, the changes made in the submodule won't take 
> effect. 
> 
> This is not true.
> 
>   git submodule update --remote
> 
> will pick up submodules changes just fine.
> 
> 
> Necessary reminder that we're discussing, as the subject says, the files 
> that control the GitHub workflows and the Codespaces.
> What a developer may do on their local machine does not matter.

But there is no difference here between a CI and a local machine here.
A CI is perfectly capable of doing 
"git submodule update --remote" 
and proceed.


> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/b178151b-6c80-4a8c-a93d-04fc824f969dn%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/Zhe2Ke9VxXXQFFco%40hilbert.homenet.telecomitalia.it.


signature.asc
Description: PGP signature