Re: [sage-devel] Re: 8.2.beta0 Doctest error on tensorfield.py

[Eric Gourgoulhon]

Le lundi 18 décembre 2017 19:01:48 UTC+1, vdelecroix a écrit :
>
> This is fixed in 
>
>   https://trac.sagemath.org/ticket/24396 
>
>
Thank you Vincent!

And Eric you should be in copy of that ticket 
>
>
No, I wasn't: for some reason, I did not receive any notification from Trac 
for this ticket, despite you put me in CC. 

Best regards,

Eric.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: 8.2.beta0 Doctest error on tensorfield.py

[Eric Gourgoulhon]

Hi Simon,

Le lundi 18 décembre 2017 18:37:14 UTC+1, Simon King a écrit :
>
> Hi Eric, 
>
> On 2017-12-18, Eric Gourgoulhon  
> wrote: 
> > Le lundi 18 décembre 2017 15:58:30 UTC+1, Vincent Klein a écrit : 
> > I don't know what is the policy here: should all the lines that depend 
> on 
> > the one marked "# long time" be marked "# long time" as well, so that 
> "sage 
> > -t" without "--long" is successful ? 
>
> Of course! The same holds for "# optional: bla". All subsequent lines 
> have to be marked in the same way, unless they work the same regardless 
> whether the previous lines have been executed or not. 
>
>
Thanks for your answer. Indeed, this seems the only sensible thing to do!

Best regards,

  Eric.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Re: [sage-devel] Re: 8.2.beta0 Doctest error on tensorfield.py

[Vincent Delecroix]

This is fixed in

 https://trac.sagemath.org/ticket/24396

And Eric you should be in copy of that ticket

On 18/12/2017 15:26, Eric Gourgoulhon wrote:

Hi,

Le lundi 18 décembre 2017 15:58:30 UTC+1, Vincent Klein a écrit :


Hi all,

I get the following errors with a fresh 8.2.beta0 install (after "make
distclean" "make").
I have the sames errors on Ubuntu 14.04 and 16.04.
Traceback:

sage -t --warn-long 17.5 src/sage/manifolds/differentiable/tensorfield.py
# 3 doctests failed



That's because without the --long option, some doctest lines (those marked
with "# long time") are skipped, which causes some subsequent tests to
fail.
If one adds --long, all doctests are passed:
sage -t --long src/sage/manifolds/differentiable/tensorfield.py

I don't know what is the policy here: should all the lines that depend on
the one marked "# long time" be marked "# long time" as well, so that "sage
-t" without "--long" is successful ?

Eric.



--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: 8.2.beta0 Doctest error on tensorfield.py

[Simon King]

Hi Eric,

On 2017-12-18, Eric Gourgoulhon  wrote:
> Le lundi 18 décembre 2017 15:58:30 UTC+1, Vincent Klein a écrit :
> I don't know what is the policy here: should all the lines that depend on 
> the one marked "# long time" be marked "# long time" as well, so that "sage 
> -t" without "--long" is successful ?

Of course! The same holds for "# optional: bla". All subsequent lines
have to be marked in the same way, unless they work the same regardless
whether the previous lines have been executed or not.

Best regards,
Simon

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: 8.2.beta0 Doctest error on tensorfield.py

[Vincent Klein]

Ok i have read --long instead of --warn-long.
Thanks for your answer. 

Le lundi 18 décembre 2017 16:26:56 UTC+1, Eric Gourgoulhon a écrit :
>
> Hi,
>
> Le lundi 18 décembre 2017 15:58:30 UTC+1, Vincent Klein a écrit :
>>
>> Hi all, 
>>
>> I get the following errors with a fresh 8.2.beta0 install (after "make 
>> distclean" "make").
>> I have the sames errors on Ubuntu 14.04 and 16.04.
>> Traceback:
>>
>> sage -t --warn-long 17.5 
>> src/sage/manifolds/differentiable/tensorfield.py  # 3 doctests failed
>>
>>
> That's because without the --long option, some doctest lines (those marked 
> with "# long time") are skipped, which causes some subsequent tests to 
> fail. 
> If one adds --long, all doctests are passed:
> sage -t --long src/sage/manifolds/differentiable/tensorfield.py
>
> I don't know what is the policy here: should all the lines that depend on 
> the one marked "# long time" be marked "# long time" as well, so that "sage 
> -t" without "--long" is successful ?
>
> Eric.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: 8.2.beta0 Doctest error on tensorfield.py

[Eric Gourgoulhon]

Hi,

Le lundi 18 décembre 2017 15:58:30 UTC+1, Vincent Klein a écrit :
>
> Hi all, 
>
> I get the following errors with a fresh 8.2.beta0 install (after "make 
> distclean" "make").
> I have the sames errors on Ubuntu 14.04 and 16.04.
> Traceback:
>
> sage -t --warn-long 17.5 src/sage/manifolds/differentiable/tensorfield.py  
> # 3 doctests failed
>
>
That's because without the --long option, some doctest lines (those marked 
with "# long time") are skipped, which causes some subsequent tests to 
fail. 
If one adds --long, all doctests are passed:
sage -t --long src/sage/manifolds/differentiable/tensorfield.py

I don't know what is the policy here: should all the lines that depend on 
the one marked "# long time" be marked "# long time" as well, so that "sage 
-t" without "--long" is successful ?

Eric.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.