[sage-devel] Re: sage -t and detection of sage library files

2009-04-25 Thread Nicolas M. Thiery

  For information: the patch suggested on #5852 seems to work fine on my
  machine (macbook pro ubuntu intrepid)
 
 Well, give the complexity of the patch why did you not do a formal
 review then? :)

I got scared by your comments that it could be system dependent, which
I don't want to dwelve into :-)

Cheers,
Nicolas
--
Nicolas M. Thiéry Isil nthi...@users.sf.net
http://Nicolas.Thiery.name/

--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-25 Thread mabshoff



On Apr 24, 11:51 pm, Nicolas M. Thiery nicolas.thi...@u-psud.fr
wrote:
   For information: the patch suggested on #5852 seems to work fine on my
   machine (macbook pro ubuntu intrepid)

  Well, give the complexity of the patch why did you not do a formal
  review then? :)

 I got scared by your comments that it could be system dependent, which
 I don't want to dwelve into :-)

No problem - I talked to Gonzalo a little more about the
implementation and will do the formal review in the morning after I
catch up with sleep :)

 Cheers,
                                 Nicolas

Cheers,

Michael

 --
 Nicolas M. Thiéry Isil nthi...@users.sf.nethttp://Nicolas.Thiery.name/
--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-24 Thread Robert Bradshaw

On Apr 24, 2009, at 12:21 AM, Nicolas M. Thiery wrote:

   Hi!

 I just upgrade to 3.4.1, and on my machine sage -t is broken for files
 in subdirectories. For example:

 -- 
 
 zephyr-~sage-main/sagesage -t monoids/free_monoid.py
 sage -t  3.4.rc0/devel/sage-main/sage/monoids/free_monoid.py
   File ./free_monoid.py, line 18
 from monoids/free_monoid import *
 ^
 SyntaxError: invalid syntax

  [0.4 s]
 exit code: 1024

 --
 The following tests failed:


 sage -t  3.4.rc0/devel/sage-main/sage/monoids/free_monoid.py
 Total time for all tests: 0.4 seconds
 -- 
 

 Seems like sage -t misdetects the file as not beeing in sage's source
 tree and trying to (incorrectly) import it.

 Anyone else running into the same problem?

Yes, I got this too. I thought it was just because I was working in a  
non-upgraded branch (of an upgraded Sage), but it seems to be more  
common than that.

- Robert



--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-24 Thread John Cremona

This problem has been around for a while.  It works ok if you give an
absolute pathname.

Having said that, I just realised that the testing I have been doing
on a clone of 3.4.1 was working fine with a relative pathname.

Perhaps it is because Nicolas is working on an upgrade from 3.4.rc0
(as you can see from his path) rather than a fresh 3.4.1?

John

2009/4/24 Robert Bradshaw rober...@math.washington.edu:

 On Apr 24, 2009, at 12:21 AM, Nicolas M. Thiery wrote:

   Hi!

 I just upgrade to 3.4.1, and on my machine sage -t is broken for files
 in subdirectories. For example:

 --
 
 zephyr-~sage-main/sagesage -t monoids/free_monoid.py
 sage -t  3.4.rc0/devel/sage-main/sage/monoids/free_monoid.py
   File ./free_monoid.py, line 18
 from monoids/free_monoid import *
 ^
 SyntaxError: invalid syntax

  [0.4 s]
 exit code: 1024

 --
 The following tests failed:


 sage -t  3.4.rc0/devel/sage-main/sage/monoids/free_monoid.py
 Total time for all tests: 0.4 seconds
 --
 

 Seems like sage -t misdetects the file as not beeing in sage's source
 tree and trying to (incorrectly) import it.

 Anyone else running into the same problem?

 Yes, I got this too. I thought it was just because I was working in a
 non-upgraded branch (of an upgraded Sage), but it seems to be more
 common than that.

 - Robert



 


--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-24 Thread mabshoff



On Apr 24, 1:16 am, John Cremona john.crem...@gmail.com wrote:

Hi,

 This problem has been around for a while.  It works ok if you give an
 absolute pathname.

 Having said that, I just realised that the testing I have been doing
 on a clone of 3.4.1 was working fine with a relative pathname.

 Perhaps it is because Nicolas is working on an upgrade from 3.4.rc0
 (as you can see from his path) rather than a fresh 3.4.1?

 John

I remember a discussion about the problem, but did not see any fixes
in 3.4.1. If someone knows a ticket and/or even better a patch please
let us know so we can get this reviewed and fixed.

Cheers,

Michael
--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-24 Thread Nicolas M. Thiery

On Fri, Apr 24, 2009 at 01:23:25AM -0700, mabshoff wrote:
 
 
 
 On Apr 24, 1:16 am, John Cremona john.crem...@gmail.com wrote:
 
 Hi,
 
  This problem has been around for a while.  It works ok if you give an
  absolute pathname.
 
  Having said that, I just realised that the testing I have been doing
  on a clone of 3.4.1 was working fine with a relative pathname.
 
  Perhaps it is because Nicolas is working on an upgrade from 3.4.rc0
  (as you can see from his path) rather than a fresh 3.4.1?
 
  John
 
 I remember a discussion about the problem, but did not see any fixes
 in 3.4.1. If someone knows a ticket and/or even better a patch please
 let us know so we can get this reviewed and fixed.

For information: the patch suggested on #5852 seems to work fine on my
machine (macbook pro ubuntu intrepid)

Nicolas
--
Nicolas M. Thiéry Isil nthi...@users.sf.net
http://Nicolas.Thiery.name/

--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-24 Thread Gonzalo Tornaria

On Fri, Apr 24, 2009 at 10:06 PM, mabshoff mabsh...@googlemail.com wrote:
 Gonzalo: Can you please post a proper patch for bugfixes you suggest -
 I am happt to convert your diff into a proper patch attributed to you,
 but if you did it would just be easier :)

It seems I have some trouble understanding what's a proper patch
(b/c I've been observed before on this regard). However, in the case
in hand (#5852), there's no hg repo tracking that file, so I fail to
see what else you would expect from me...

Gonzalo

--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: sage -t and detection of sage library files

2009-04-24 Thread mabshoff

On Apr 24, 6:27 pm, Gonzalo Tornaria torna...@math.utexas.edu wrote:

Hi Gonzalo,

 On Fri, Apr 24, 2009 at 10:06 PM, mabshoff mabsh...@googlemail.com wrote:
  Gonzalo: Can you please post a proper patch for bugfixes you suggest -
  I am happt to convert your diff into a proper patch attributed to you,
  but if you did it would just be easier :)

 It seems I have some trouble understanding what's a proper patch
 (b/c I've been observed before on this regard). However, in the case
 in hand (#5852), there's no hg repo tracking that file, so I fail to
 see what else you would expect from me...

Oops, my bad about the repo.  But posting a unified in this particular
case would be nice. This is so trivial I can obviously do it locally.

 Gonzalo

Cheers,

Michael
--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---