Re: [sage-release] Re: Sage 10.1.beta3 released
It is https://github.com/sagemath/sage/pull/35787 . -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-release/7b818b72-de75-43c1-bfb6-13f7588ca8bcn%40googlegroups.com.
Re: [sage-release] Re: Sage 10.1.beta3 released
I replaced old tests with "random" by new ones with "random" (and forgot these two). Some other tests do check consistency. All that the function really does is converting a pari output back into a point on the elliptic curve. Therefore the test checks if pari runs without error and if the returned is a point on the curve. Checking if it is a generator modulo torsion would be checking if pari gets this right. Is that what we should do? But this discussing should happen on a pull request. I repeat my question: Do I open a new one or is the faulty initial one reopened? (Trac tickets used to be reopened, that is why I ask). Chris On Friday, 16 June 2023 at 01:39:46 UTC+1 tsc...@ucdavis.edu wrote: > I don't think it should be random; that has the chance of hiding actual > bugs. I think we should check that it belongs to a particular set > (specifically, the one from John's comment). > > Best, > Travis > > > On Thursday, June 15, 2023 at 5:15:52 AM UTC+9 chris wuthrich wrote: > >> I agree with John. Lines 2380 and 2388 need a "random output" for that >> reason, like the other calls of that function have already. >> Is this a new pull request or is the old #35626 >> https://github.com/sagemath/sage/pull/35626 opened again for corrections? >> >> Chris >> >> On Wednesday, 14 June 2023 at 17:49:21 UTC+1 John Cremona wrote: >> >>> On Tue, 13 Jun 2023 at 17:06, John Cremona wrote: >>> >>>> The elliptic curve failure might be a consequence of the recently >>>> merged PR #35626 about using libpari to compute ranks and generators. >>>> >>>> I'll take a look to at least see if the output you get is >>>> mathematically correct -- generators are not unique. >>>> >>> >>> I was right. This curve has rank 1 and torsion (Z/2Z)^2 so if P is one >>> generator (of infinte order) then there are 3 other, P+T for T a point of >>> order 2. The one your are getting is one of these. >>> >>> So we conclude that we cannot reply on pari always returning the same >>> generator despite random seeds etc being fixed in doctests. I don't know >>> why that is, but if it is the case then this (and other similar) doctests >>> will have to be written accordingly. >>> >>> >>>> >>>> John >>>> >>>> >>>> On Tue, 13 Jun 2023, 17:00 Emmanuel Charpentier, < >>>> emanuel.c...@gmail.com> wrote: >>>> >>>>> On Debian testing running on core i7 + 16 GB RAM, upgrading 10.1.beta2 >>>>> to 10.1.beta3 and rinning ptestlong gives 3 permanent failures : >>>>> -- >>>>> sage -t --long --warn-long 207.1 >>>>> --random-seed=291812591553963182024849035945523427319 >>>>> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >>>>> sage -t --long --warn-long 207.1 >>>>> --random-seed=291812591553963182024849035945523427319 >>>>> src/sage/coding/linear_code.py # 2 doctests failed sage -t --long >>>>> --warn-long 207.1 --random-seed=291812591553963182024849035945523427319 >>>>> src/sage/coding/code_constructions.py # 1 doctest failed >>>>> -- >>>>> >>>>> The last two have been already reported a few times, and seem >>>>> cosmetic. The first one is new and seemingly *not* cosmetic : >>>>> charpent@zen-book-flip:/usr/local/sage-10$ sage -t --long --warn-long >>>>> 207.1 --random-seed=291812591553963182024849035945523427319 >>>>> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >>>>> Running doctests with ID 2023-06-13-17-49-08-8dac2a23. Git branch: >>>>> develop >>>>> Git ref: 10.1.beta0-453-g443b7549ad Running with >>>>> SAGE_LOCAL='/usr/local/sage-10/local' and >>>>> SAGE_VENV='/usr/local/sage-10/local/var/lib/sage/venv-python3.11' Using >>>>> --optional=debian,dot2tex,fricas,gap_jupyter,gap_packages,libsemigroups,msolve,pip,pysingular,sage,sage_spkg,singular_jupyter >>>>> >>>>> Features to be detected: >>>>> 4ti2,benzene,bliss,buckygen,conway_polynomials,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_jones_numfield,database_knotinfo,dvipng,fpylll,gfan,graphv
Re: [sage-release] Re: Sage 10.1.beta3 released
I agree with John. Lines 2380 and 2388 need a "random output" for that reason, like the other calls of that function have already. Is this a new pull request or is the old #35626 https://github.com/sagemath/sage/pull/35626 opened again for corrections? Chris On Wednesday, 14 June 2023 at 17:49:21 UTC+1 John Cremona wrote: > On Tue, 13 Jun 2023 at 17:06, John Cremona wrote: > >> The elliptic curve failure might be a consequence of the recently merged >> PR #35626 about using libpari to compute ranks and generators. >> >> I'll take a look to at least see if the output you get is mathematically >> correct -- generators are not unique. >> > > I was right. This curve has rank 1 and torsion (Z/2Z)^2 so if P is one > generator (of infinte order) then there are 3 other, P+T for T a point of > order 2. The one your are getting is one of these. > > So we conclude that we cannot reply on pari always returning the same > generator despite random seeds etc being fixed in doctests. I don't know > why that is, but if it is the case then this (and other similar) doctests > will have to be written accordingly. > > >> >> John >> >> >> On Tue, 13 Jun 2023, 17:00 Emmanuel Charpentier, >> wrote: >> >>> On Debian testing running on core i7 + 16 GB RAM, upgrading 10.1.beta2 >>> to 10.1.beta3 and rinning ptestlong gives 3 permanent failures : >>> -- >>> sage -t --long --warn-long 207.1 >>> --random-seed=291812591553963182024849035945523427319 >>> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >>> sage -t --long --warn-long 207.1 >>> --random-seed=291812591553963182024849035945523427319 >>> src/sage/coding/linear_code.py # 2 doctests failed sage -t --long >>> --warn-long 207.1 --random-seed=291812591553963182024849035945523427319 >>> src/sage/coding/code_constructions.py # 1 doctest failed >>> -- >>> >>> The last two have been already reported a few times, and seem cosmetic. >>> The first one is new and seemingly *not* cosmetic : >>> charpent@zen-book-flip:/usr/local/sage-10$ sage -t --long --warn-long >>> 207.1 --random-seed=291812591553963182024849035945523427319 >>> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >>> Running doctests with ID 2023-06-13-17-49-08-8dac2a23. Git branch: develop >>> Git ref: 10.1.beta0-453-g443b7549ad Running with >>> SAGE_LOCAL='/usr/local/sage-10/local' and >>> SAGE_VENV='/usr/local/sage-10/local/var/lib/sage/venv-python3.11' Using >>> --optional=debian,dot2tex,fricas,gap_jupyter,gap_packages,libsemigroups,msolve,pip,pysingular,sage,sage_spkg,singular_jupyter >>> >>> Features to be detected: >>> 4ti2,benzene,bliss,buckygen,conway_polynomials,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_jones_numfield,database_knotinfo,dvipng,fpylll,gfan,graphviz,imagemagick,ipython,jupymake,kenzo,latte_int,lrcalc_python,lrslib,mcqd,meataxe,mpmath,msolve,nauty,networkx,numpy,palp,pandoc,pdf2svg,pdftocairo,pexpect,phitigra,pillow,plantri,polytopes_db,polytopes_db_4d,pplpy,primecountpy,ptyprocess,pynormaliz,pyparsing,python_igraph,requests,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.gap,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modules,sage.plot,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.rings.real_mpfr,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,scipy,singular,sphinx,sympy,tdlib >>> >>> Doctesting 1 file. sage -t --long --warn-long 207.1 >>> --random-seed=291812591553963182024849035945523427319 >>> src/sage/schemes/elliptic_curves/ell_rational_field.py >>> ** File >>> "src/sage/schemes/elliptic_curves/ell_rational_field.py", line 2380, in >>> sage.schemes.elliptic_curves.ell_rational_field.EllipticCurve_rational_field.? >>> >>> Failed example: E.gens(use_database=False, algorithm="pari",pari_effort=4) >>> Expected: [(611429153205013185025/9492121848205441 : >>> 15118836457596902442737698070880/924793900700594415341761 : 1)] Got: >>> [(-38749202011873484470143/306317326339867638016 : >>> 678721624672968530804232808604865/5361142413550167706041194328064 : 1)] >>> ** 1 >>> item had failures: 1 of 100 in >>> sage.schemes.elliptic_curves.ell_rational_field.EllipticCurve_rational_field.? >>> >>> [896 tests, 1 failure, 241.41 s] >>> -- sage >>> -t --long --warn-long 207.1 >>> --random-seed=291812591553963182024849035945523427319 >>> src/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctest failed >>> -
Re: [sage-release] Re: Sage 9.1.beta0 released
Thanks for the help. I upgraded devtoolset to 7, but it is still pkg-config 0.27.1 there. So that didn't help. Markus' suggestion solved it. Chris -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-release/825eef3a-d263-42ee-8af1-1a591a5ff35d%40googlegroups.com.
[sage-release] Re: Sage 9.1.beta0 released
make build after pulling 9.1.beta0 produces an error below. I have no problems compiling 9.0. This is on centos 7 with devtoolset-4 enabled. Sorry if this is noise produced by me making an error. Happy to provide any other information. make -j4 build/make/Makefile --stop make[1]: Entering directory `/local/pmzcw/prog/sage' ./bootstrap -d make[2]: Entering directory `/local/pmzcw/prog/sage' rm -rf config configure build/make/Makefile-auto.in make[2]: Leaving directory `/local/pmzcw/prog/sage' bootstrap:69: installing 'config/config.rpath' configure.ac:113: installing 'config/config.guess' configure.ac:113: installing 'config/config.sub' configure.ac:68: installing 'config/install-sh' configure.ac:68: installing 'config/missing' configure.ac:453: error: possibly undefined macro: AC_CONFIG_COMMANDS If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure:10801: error: possibly undefined macro: PKG_CHECK_VAR configure:10802: error: possibly undefined macro: AC_CONFIG_LINKS configure:10807: error: possibly undefined macro: AC_MSG_WARN make dist-clean also fails with checking BLAS library... openblas ./configure: line 10801: syntax error near unexpected token `OPENBLASPCDIR,' ./configure: line 10801: `PKG_CHECK_VAR(OPENBLASPCDIR, openblas, pcfiledir,' If you would like to try to build Sage anyway (to help porting), export the variable 'SAGE_PORT' to something non-empty. make[1]: *** [build/make/Makefile] Error 1 make[1]: Leaving directory `/local/pmzcw/prog/sage' make: *** [dist-clean] Error 2 Chris -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-release/6726a7ab-37c3-423d-bf28-1fd5e764e478%40googlegroups.com.
